unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dani Moncayo <dmoncayo@gmail.com>
To: Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: Bootstrap failure on MS-Windows
Date: Wed, 6 Nov 2013 16:38:26 +0100	[thread overview]
Message-ID: <CAH8Pv0hpWrA-OAhFS8ydBcveEjyB3K2vOhDLXejBC6Cqw219pA@mail.gmail.com> (raw)
In-Reply-To: <CAH8Pv0gQzhGEinfTr4mAQtCzJ2fqF1O-xOyNB994e8WoT-yDLg@mail.gmail.com>

> So this is the final patch that has worked for me:

I want to suggest the following simplification/improvement.  It is
tested on a real bootstrap.

Explanation:
* The ouput of "pwd -W" is in windows-native format (c:/foo/bar), and
we are converting it to MSYS-format (/c/foo/bar) and then converting
it back to windows-native format.  That double conversion is obviously
pointless.
* "${srcdir}" should expand to an existing directory.  If somehow it
expands to anything else, it is better to error out, because something
is going wrong.  So I've chained the commands with "&&" instead of
";".


diff --git a/Makefile.in b/Makefile.in
index 984dcea..3de8209 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -351,7 +351,7 @@ msys_sed_sh_escape=sed -e 's/[];$$*.^[]/\\\\&/g'
 # the data directory.  "pwd -W" produces Windows-style 'd:/foo/bar'
 # absolute directory names, so we use it here to countermand that lossage.
 epaths-force-w32: FRC
- @(w32srcdir=`cd "${srcdir}"; pwd -W | sed -e 's,^\([A-Za-z]\):,/\1,'
| ${msys_to_w32}` ; \
+ @(w32srcdir=`cd "${srcdir}" && pwd -W` ; \
   prefixpattern=`echo '${prefix}' | ${msys_to_w32} | ${msys_sed_sh_escape}` ; \
   locallisppath=`echo '${locallisppath}' | ${msys_lisppath_to_w32} |
${msys_prefix_subst}` ; \
   sed < ${srcdir}/nt/epaths.nt > epaths.h.$$$$ \



-- 
Dani Moncayo



  parent reply	other threads:[~2013-11-06 15:38 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-02 18:04 Bootstrap failure on MS-Windows Dani Moncayo
2013-11-02 18:52 ` Glenn Morris
2013-11-05  8:24   ` Glenn Morris
2013-11-05 18:14     ` Dani Moncayo
2013-11-05 18:26       ` Eli Zaretskii
2013-11-05 19:46         ` Dani Moncayo
2013-11-05 20:05           ` Eli Zaretskii
2013-11-05 21:08             ` Dani Moncayo
2013-11-05 21:52               ` Glenn Morris
2013-11-06 15:38               ` Dani Moncayo [this message]
2013-11-06 20:32                 ` Glenn Morris
2013-11-06 20:50                   ` Eli Zaretskii
2013-11-06 20:55                     ` Glenn Morris
2013-11-12  2:42                 ` Glenn Morris
2013-11-06  0:27             ` Óscar Fuentes
2013-11-06  1:35               ` Glenn Morris
2013-11-06  1:42                 ` Glenn Morris
2013-11-06 13:59             ` Andy Moreton
2013-11-06 17:08               ` Eli Zaretskii
2013-11-06 20:24                 ` Andy Moreton
2013-11-08 10:32                   ` Andy Moreton
2013-11-08 11:02                     ` Eli Zaretskii
2013-11-08 13:34                       ` Andy Moreton
2013-11-08 14:18                         ` Eli Zaretskii
2013-11-09 12:36                           ` Andy Moreton
2013-11-09 13:19                             ` Eli Zaretskii
2013-11-10 21:21                               ` Andy Moreton
2013-11-09 13:24                             ` Jarek Czekalski
2013-11-09 13:51                               ` Eli Zaretskii
2013-11-09 14:33                                 ` Dani Moncayo
2013-11-09 15:18                                   ` Eli Zaretskii
2013-11-05 20:29           ` Glenn Morris
2013-11-05 21:09             ` Dani Moncayo
2013-11-05 20:29         ` Glenn Morris
2013-11-05 18:27       ` Glenn Morris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAH8Pv0hpWrA-OAhFS8ydBcveEjyB3K2vOhDLXejBC6Cqw219pA@mail.gmail.com \
    --to=dmoncayo@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).