From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_Paulo_Labegalini_de_Carvalho?= Newsgroups: gmane.emacs.devel Subject: Re: Initial fontification in sh-mode with tree-sittter Date: Thu, 27 Oct 2022 18:48:33 -0600 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000b8b00f05ec0d9e12" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6942"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Oct 28 02:49:19 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooDYl-0001dD-DF for ged-emacs-devel@m.gmane-mx.org; Fri, 28 Oct 2022 02:49:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooDYH-0004VQ-OW; Thu, 27 Oct 2022 20:48:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooDYG-0004VI-9W for emacs-devel@gnu.org; Thu, 27 Oct 2022 20:48:48 -0400 Original-Received: from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ooDYE-00019I-IP for emacs-devel@gnu.org; Thu, 27 Oct 2022 20:48:47 -0400 Original-Received: by mail-oi1-x236.google.com with SMTP id r187so4606724oia.8 for ; Thu, 27 Oct 2022 17:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=XG3Qg07vsmMcRMwK7ixwelgHknsXXFpamAQKgSXjQFM=; b=TYKMWLiODXBQti7lP/y6xup56e1UJq10JMq6QozfgH92BtwzUSy3WY2BLbG87eM1bl X+DWOvDMeHHm71TJX/i16/4I16Ts1VbvR1LlvFHH17E2E7rfk+Kkfq71BY0q/ez8tcPL UWpwuQva267Jx2TLkOjz4m2wfPO/2uUKys/tcDYbHYIIBmE75P7OFfTinsjfzbYX3r8y LZcuI5ZLuFURUU3Uun1XV2Pnai2oQAOxvwjlpOQdLOLoLCiGcdhx3CAJ5h5JzHcWjoyr IHFnwpYgdDN7OfWFIaDH+bXaUFevC8UYbMUCKWMCfnpmZCsnCjbVoT45M5HC+UY1npXK dITg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=XG3Qg07vsmMcRMwK7ixwelgHknsXXFpamAQKgSXjQFM=; b=MdbjQgULrA/p1Pp1EA+rLLDEBnIM6Zdmx+CmGk6r8TNysq0eKmrUWG8jL7g++nm3SA NsDzRmvxta9ZOTkIN0ODSgHhJgtONfYOvHsWMAvHQfK+T9V0APE2fHR0m5dIUdp8lfNQ /CSeBn3jgmDYNHxv8fZ8iyjPLUcbEyCQDA3p7aKBWdrIL34aokhr42b5AxWI8+ly+GO6 YTAd1db2jtoI/mt1SSaBEkRm0fLnfQPymxfrLI+wocdsXJzlnXlq0HCc0Nwlw0cFgzQi T2fD4BRSgXjRg0oPnnmnhYRyeLicfCQSGoOFtiJmExjgFRermILQH55ifJZZfHixvRSF 6f4A== X-Gm-Message-State: ACrzQf3dVCwTLH8YAf5MxlSTsQlLeGtUPvC6mmsi4NUZZhnG5BuFWqFH 1TMmd6BwIWE45hulo1D/GLIQme+gICpTq6Kj7yA= X-Google-Smtp-Source: AMsMyM55sTy9vIYpfQKNw0busY8h9wCE9fAiw3Sm8Q7kpQFd8tOkIoiV0U/eaaZhmRQtmdHf9LpX+InwgWXMBdRI9SM= X-Received: by 2002:a05:6808:1187:b0:353:a617:6acd with SMTP id j7-20020a056808118700b00353a6176acdmr6729562oil.105.1666918125185; Thu, 27 Oct 2022 17:48:45 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::236; envelope-from=jaopaulolc@gmail.com; helo=mail-oi1-x236.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298650 Archived-At: --000000000000b8b00f05ec0d9e12 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 27, 2022 at 6:18 PM Stefan Kangas wrote: > Are those faces really needed? Is it not enough with just the > font-lock-* faces we already have? > They are not needed but might be desirable for users that want to highlight those parts of the code that do not have a font-lock* face to them. Would it be better to define them as font-lock faces instead? > If the answer is that we do need them, should they really be marked > private? I thought the point of a face was allowing users and themes to > customize them. > You are right, those should not be private. --=20 Jo=C3=A3o Paulo L. de Carvalho Ph.D Computer Science | IC-UNICAMP | Campinas , SP - Brazil Postdoctoral Research Fellow | University of Alberta | Edmonton, AB - Canad= a joao.carvalho@ic.unicamp.br joao.carvalho@ualberta.ca --000000000000b8b00f05ec0d9e12 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Thu, Oct 27, 2022 at 6:18 PM Stefan Ka= ngas <stefankangas@gmail.com> wrote:
Are those faces really needed?=C2=A0 Is it not enough with just the
font-lock-* faces we already have?

--
--000000000000b8b00f05ec0d9e12--