From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_Paulo_Labegalini_de_Carvalho?= Newsgroups: gmane.emacs.devel Subject: Re: New defun navigation for tree-sitter (Was: Code navigation for sh-mode with Tree-sitter) Date: Tue, 13 Dec 2022 11:48:35 -0700 Message-ID: References: <1B9F9B3A-A757-4A65-9653-CD0112EB8895@gmail.com> <5BB6E79A-B1FA-40F4-B48A-DADF63A30DDC@gmail.com> <0B190C0C-24BE-490C-9C7D-1439B77EE9D5@gmail.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000ecdf6a05efba111b" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38552"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , Alan Mackenzie , emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 13 19:49:32 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5ALM-0009ng-CD for ged-emacs-devel@m.gmane-mx.org; Tue, 13 Dec 2022 19:49:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5AKk-0000nu-EK; Tue, 13 Dec 2022 13:48:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5AKg-0000nZ-FH for emacs-devel@gnu.org; Tue, 13 Dec 2022 13:48:50 -0500 Original-Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5AKe-0000ZV-TV for emacs-devel@gnu.org; Tue, 13 Dec 2022 13:48:50 -0500 Original-Received: by mail-ej1-x631.google.com with SMTP id kw15so38778120ejc.10 for ; Tue, 13 Dec 2022 10:48:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=lcIJORmpuL6xlBDmOFEIVWZprK7BFNzfX+toywI3+cU=; b=edOi9bkuWFGV/QIih9oSw4Bw88SX4vPtKFlZViFestSDPzV0d0qTcGI8dsLvQyGebl pBCfHXZTb1bdEsyqnPS1bXWtP/T8/vpgy9TqpdEDjC1QBGGZViXh0I2zVXyKRAkjZMGy D+wevdoWhrn6tjoihxzYM/D5iBz0k+duKddsXiUhgxQtaNDeSBRBAuZV9iQXjuugm4Lv ez1nRI72i7HyCHCTb2YVwRWuTp7kaYKRAEOPyQbgRXvjQU7hgLii8leAEjjbpXoBsp8w yz4U2pOZF8ML8lcmMrG7nHqIDLfTxXTvYDiLhIdeeHHtHiWaPuyyeePQCbegCeKQJLR6 ZpoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lcIJORmpuL6xlBDmOFEIVWZprK7BFNzfX+toywI3+cU=; b=iahKXye2qt0rq7ZpzC2gCJ/E5QprbF15dV3GTptFlIlbJd7ou9Xw/0JHDnDScQnfAj 0RWnUCfacWzmdOFR5AMN1g2QLlokLH6MDfjTe1TMgJwJBPG6fZGWpTrMTLbw0vpoEZwa n/YFFKJwdKf3P+IfaIk6O9QU240RpAc0MMq+o0QqpDBI8L5oHE1MfX7WAZ2VgFP+fx5G 58cW4e+0BrLl/X4IN1Kh3BOx7G+axYM9JwsjB7H07LA0Xnr3kSaw6WGUa9OcGuvy17Bv oK8oteKJ0oEMAeoZPYWOupJYPZeyCs7lxfnamYEW9UUFutIZrX8l4zkyYgsCpYvq5g04 nvNg== X-Gm-Message-State: ANoB5pnoOLxmld/3vmMz88yN+hYdmejlQf52aboHV2ZNBmVhW+KEFuxQ uKUSJ40h4WsrMsnX/priod4xvg+GcPP8W3ozjJE= X-Google-Smtp-Source: AA0mqf4GHFgATeU9seraoWLLt8PBb8e1+CEYnRckbTOxUGllWOjqzf7uDFKNTxR0mHdc8N3Fq9h/peYit2EsuLRH+6Y= X-Received: by 2002:a17:906:8383:b0:7c1:19ea:dda with SMTP id p3-20020a170906838300b007c119ea0ddamr7617122ejx.31.1670957327243; Tue, 13 Dec 2022 10:48:47 -0800 (PST) In-Reply-To: <0B190C0C-24BE-490C-9C7D-1439B77EE9D5@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=jaopaulolc@gmail.com; helo=mail-ej1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301345 Archived-At: --000000000000ecdf6a05efba111b Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Dec 13, 2022 at 11:07 AM Yuan Fu wrote: > Treesit--navigate-defun should, as you did in bash-ts-mode, only navigate > in the same level (siblings) or higher (parents). Could you show an examp= le > of the unexpected behavior? I must have forgotten to evaluate something on my setup file. It is indeed working as you described. Sorry for the noise. Should I add key bindings to use the new tree-sitter navigation functions to bash-ts-mode or is it planned an integration with beginning/end-of-defun= ? --=20 Jo=C3=A3o Paulo L. de Carvalho Ph.D Computer Science | IC-UNICAMP | Campinas , SP - Brazil Postdoctoral Research Fellow | University of Alberta | Edmonton, AB - Canad= a joao.carvalho@ic.unicamp.br joao.carvalho@ualberta.ca --000000000000ecdf6a05efba111b Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

On Tue, Dec 13, 2022 at 11:07 AM Yuan Fu = <casouri@gmail.com> wrote:
Treesit--navigate-defun should, as you did in bash-ts-mode, only navigate i= n the same level (siblings) or higher (parents). Could you show an example = of the unexpected behavior?

I must have forgotten to e= valuate something on my setup file. It is indeed working as you described. = Sorry for the noise.

Should I add key bindings to use the new tree-s= itter navigation functions to bash-ts-mode or is it planned an integration = with beginning/end-of-defun?
=C2=A0
--
Jo= =C3=A3o Paulo L. de Carvalho
Ph.D Computer Science | =C2=A0IC-UNICAMP | = Campinas , SP - Brazil
Postdoctoral Research Fellow | University of Albe= rta | Edmonton, AB - Canada
--000000000000ecdf6a05efba111b--