From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.devel Subject: Re: Requesting review before pushing patch to ELPA Date: Wed, 4 Feb 2015 01:24:01 -0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e010d92007b3adb050e3fbff4 X-Trace: ger.gmane.org 1423041849 31373 80.91.229.3 (4 Feb 2015 09:24:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2015 09:24:09 +0000 (UTC) Cc: emacs-devel To: bruce.connor.am@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 04 10:24:09 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YIwBs-00064D-UK for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 10:24:09 +0100 Original-Received: from localhost ([::1]:35239 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIwBs-0002Lm-9D for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 04:24:08 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53703) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIwBo-0002LV-9f for emacs-devel@gnu.org; Wed, 04 Feb 2015 04:24:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIwBm-0000a7-QW for emacs-devel@gnu.org; Wed, 04 Feb 2015 04:24:04 -0500 Original-Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]:41480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIwBm-0000Zz-Jp for emacs-devel@gnu.org; Wed, 04 Feb 2015 04:24:02 -0500 Original-Received: by mail-oi0-f52.google.com with SMTP id h136so354657oig.11 for ; Wed, 04 Feb 2015 01:24:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=Y2dVKOw1vfLS1/XwEqK9qjBFDJ0XhqKymdoMWMGJsvQ=; b=uhAeZNVUT/QfJUlRGsM2Z+G1YLW/injmdpvfpTfUnYQBj3XDmdF+FgA7NN8/FvESZf xOOH0yIT3I4oegl5v9JskUw3hzg3i5qn9IPAESKmDt3WIfEuPNBOQJ8/WaKwHhppfBA4 0GjOmjbO42uJS9/QdrZNeXXEn7nM2oIUCX3lwVg601G9DCOq6f0B6IPMW1TxlaDB9Xe9 LX1DhH/7eIdiZBJX7RkUVOnWgNKCJzxYWpwSbJEqBHfb9DNB3QVKBsRdybOXXjUlYshs jeUSGWH94PBo3qkO4yJlztvZ6uW5IVc2Q2Q5uQM9zWzgNxyHn4chmVUAEP6lOF8RsPkz MR3g== X-Received: by 10.60.78.169 with SMTP id c9mr18273436oex.78.1423041841804; Wed, 04 Feb 2015 01:24:01 -0800 (PST) Original-Received: by 10.76.24.106 with HTTP; Wed, 4 Feb 2015 01:24:01 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: fVqe4_YhwGL2kJ1sL7Ey22mGZ_s X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182361 Archived-At: --089e010d92007b3adb050e3fbff4 Content-Type: text/plain; charset=ISO-8859-1 Hi Artur, I am interested in the "git details". Please elaborate. On Tue, Feb 3, 2015 at 4:13 AM, Artur Malabarba wrote: > If that package is only used for testing, you can also just not merge > it into elpa and do your testing elsewhere (e.g. Travis+github). > That's what I did with Names, because the tests involved a lot of > packages from other people with a ton of changes made by me. I'm not > saying I couldn't put those inside the Elpa/package/ directory, but it > was easier this way than to worry about copyrights. > > I can go into the `git' details necessary for this if you'd like. > > 2015-02-03 5:57 GMT+00:00 Jackson Hamilton >: > > On the "Copyright (C) 2014 Johan Andersson", are you suggesting I change > the > > copyright notice in ert-async.el myself, or that I should contact the > author > > and tell him to change it? > > > > In either case that seems inappropriate. > > > > context-coloring/languages/javascript/libraries/ also includes 3 > JavaScript > > libraries with their own copyright notices. These appear to be licensed > > under the FreeBSD license. Should they be handled specially? > > > > Regards, > > Jackson > > > > On Mon, Feb 2, 2015 at 9:58 AM, Stefan Monnier > > > wrote: > >> > >> > which included 247 commits. I am not sure if these should be squashed, > >> > but > >> > based on the commit log it seems like this subtree approach is how > other > >> > people are managing their externally-maintained packages, so I assume > it > >> > is > >> > okay to add the whole history. > >> > >> Indeed, it's OK to keep the history. > >> > >> > On top of that, I added 2 patches so that I could test ELPA locally. I > >> > was > >> > able to install my package via a "local-elpa" as described in the > >> > README. > >> > The patches for that are attached in this email. > >> > >> I think the hydra-test.el has been fixed by someone else in the > >> mean time. As for your change: > >> > >> > +./context-coloring/libraries/ert-async.el:;; Copyright (C) 2014 Johan > >> > Andersson > >> > >> I think this change is incorrect. IIUC this is johan.rejeep@gmail.com > >> we're talking bout, and he signed the copyright assignment forms, so > >> the line in ert-async.el should say "Copyright (C) 2014 Free Software > >> Foundation, Inc" (at which point you won't need any change to > >> copyright_exceptions). > >> > >> > >> Stefan > > > > > --089e010d92007b3adb050e3fbff4 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hi Artur, I am interested in the "git details". = Please elaborate.

On Tue, Feb 3, 2015 at 4:13 AM, Artur Malabarba <bruce.c= onnor.am@gmail.com> wrote:
= If that package is only used for testing, you can also just not merge
it into elpa and do your testing elsewhere (e.g. Travis+github).
That's what I did with Names, because the tests involved a lot of
packages from other people with a ton of changes made by me. I'm not saying I couldn't put those inside the Elpa/package/ directory, but it<= br> was easier this way than to worry about copyrights.

I can go into the `git' details necessary for this if you'd like.

2015-02-03 5:57 GMT+00:00 Jackson Hamilton <jackson@jacksonrayhamilton.com>:
> On the "Copyright (C) 2014 Johan Andersson", are you suggest= ing I change the
> copyright notice in ert-async.el myself, or that I should contact the = author
> and tell him to change it?
>
> In either case that seems inappropriate.
>
> context-coloring/languages/javascript/libraries/ also includes 3 JavaS= cript
> libraries with their own copyright notices. These appear to be license= d
> under the FreeBSD license. Should they be handled specially?
>
> Regards,
> Jackson
>
> On Mon, Feb 2, 2015 at 9:58 AM, Stefan Monnier <monnier@iro.umontreal.ca>
> wrote:
>>
>> > which included 247 commits. I am not sure if these should be = squashed,
>> > but
>> > based on the commit log it seems like this subtree approach i= s how other
>> > people are managing their externally-maintained packages, so = I assume it
>> > is
>> > okay to add the whole history.
>>
>> Indeed, it's OK to keep the history.
>>
>> > On top of that, I added 2 patches so that I could test ELPA l= ocally. I
>> > was
>> > able to install my package via a "local-elpa" as de= scribed in the
>> > README.
>> > The patches for that are attached in this email.
>>
>> I think the hydra-test.el has been fixed by someone else in the >> mean time.=A0 As for your change:
>>
>> > +./context-coloring/libraries/ert-async.el:;; Copyright (C) 2= 014 Johan
>> > Andersson
>>
>> I think this change is incorrect.=A0 IIUC this is johan.rejeep@gmail.com
>> we're talking bout, and he signed the copyright assignment for= ms, so
>> the line in ert-async.el should say "Copyright (C) 2014 Free = Software
>> Foundation, Inc" (at which point you won't need any chang= e to
>> copyright_exceptions).
>>
>>
>>=A0 =A0 =A0 =A0 =A0Stefan
>
>

--089e010d92007b3adb050e3fbff4--