From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.devel Subject: Requesting review for change to lisp/textmodes/sgml-mode.el Date: Wed, 25 Feb 2015 02:35:50 -0800 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=001a11409f08fd4102050fe73292 X-Trace: ger.gmane.org 1424860568 1622 80.91.229.3 (25 Feb 2015 10:36:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2015 10:36:08 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 25 11:36:08 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YQZK3-0000nc-Tx for ged-emacs-devel@m.gmane.org; Wed, 25 Feb 2015 11:36:08 +0100 Original-Received: from localhost ([::1]:53659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQZK2-0007IV-SS for ged-emacs-devel@m.gmane.org; Wed, 25 Feb 2015 05:36:06 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34857) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQZJt-00079R-Tg for emacs-devel@gnu.org; Wed, 25 Feb 2015 05:36:02 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YQZJo-0003Ut-P5 for emacs-devel@gnu.org; Wed, 25 Feb 2015 05:35:57 -0500 Original-Received: from mail-oi0-x234.google.com ([2607:f8b0:4003:c06::234]:49940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YQZJo-0003UW-IW for emacs-devel@gnu.org; Wed, 25 Feb 2015 05:35:52 -0500 Original-Received: by mail-oi0-f52.google.com with SMTP id u20so2471352oif.11 for ; Wed, 25 Feb 2015 02:35:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:date:message-id:subject:from:to:content-type; bh=38kqgqHyGnSaiLFNbwdiUhHyVYJQrVJ4KvPrDQp03LE=; b=XbLV8naiQ2VQN+LenAATENmgZNuXymw4M6mGNNPl8Ez0pEBfYQBVLmlkI/E549aGv5 hWYlwtsQB+1oONEgZvOiqJU8fwIBV4ywmZOLi2y85HT67X1g42vdjaFL3zNbksfMomae syaDTylhuVvglpHpBb5Hn0a5L7wa4uVCBvtBweVG7umt8ji8EAbPaNFHhcHDlMY3hfgO dGTh8Y79zCAJAbDvxz1el1377fZmXP1Q9p4NcTuwz80b5XuGsSWC+KnDhAXdq3Tpku2e R+fIjq392GBokphiP6I88EMq2s+OPjCvnNj2svm8YkQRg1gd0iuIUaAQcXZnTsoiU9hL 3qqw== X-Received: by 10.202.104.194 with SMTP id o63mr1655199oik.56.1424860550845; Wed, 25 Feb 2015 02:35:50 -0800 (PST) Original-Received: by 10.76.43.242 with HTTP; Wed, 25 Feb 2015 02:35:50 -0800 (PST) X-Google-Sender-Auth: 1LRsJ-xftTqrRRhnzumuUWa18wQ X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183487 Archived-At: --001a11409f08fd4102050fe73292 Content-Type: multipart/alternative; boundary=001a11409f08fd40fc050fe73290 --001a11409f08fd40fc050fe73290 Content-Type: text/plain; charset=ISO-8859-1 Hello comrades, I made an adjustment (fix?) to the way SGML attributes are indented. Previously, if one wrote a form like the following: He could break the attribute onto a new line and it would be indented like so: But sgml-basic-offset defaults to 2, not 3, so it doesn't make much sense that the attribute is indented by 3 spaces. And if I (setq sgml-basic-offset 4), now my attributes are indented by 5 spaces. Personally I do not expect this behavior, I expect the indentation to match. Perhaps it could be argued that the extra space helps to improve readability; maybe so, but it still seems to contradict the offset value. In teams where many people use editors that insert multiples of N spaces or tabs, this +1 indentation strategy feels rather alienating. I think it would be better to stick to a multiple of the specified offset when an attribute is sitting on its own line. Hence the attached patch to remove the +1 indentation behavior. Thanks for reviewing, Jackson --001a11409f08fd40fc050fe73290 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Hello comrades,

I made an ad= justment (fix?) to the way SGML attributes are indented.

Previously, if one wrote a form like the following:

<element attribute=3D"value">

=
He could break the attribute onto a new line and it would be indented = like so:

<element
=A0 =A0attribute=3D= "value">

But sgml-basic-offset defaul= ts to 2, not 3, so it doesn't make much sense that
the attrib= ute is indented by 3 spaces.

And if I (setq sgml-b= asic-offset 4), now my attributes are indented by 5
spaces. Perso= nally I do not expect this behavior, I expect the indentation to
= match.

Perhaps it could be argued that the extra s= pace helps to improve readability;
maybe so, but it still seems t= o contradict the offset value. In teams where many
people use edi= tors that insert multiples of N spaces or tabs, this +1
indentati= on strategy feels rather alienating. I think it would be better to
stick to a multiple of the specified offset when an attribute is sitting = on its
own line.

Hence the attached patc= h to remove the +1 indentation behavior.

Thanks fo= r reviewing,
Jackson
--001a11409f08fd40fc050fe73290-- --001a11409f08fd4102050fe73292 Content-Type: text/x-patch; charset=US-ASCII; name="0001-lisp-textmodes-sgml-mode.el-sgml-calculate-indent-Fi.patch" Content-Disposition: attachment; filename="0001-lisp-textmodes-sgml-mode.el-sgml-calculate-indent-Fi.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_i6kl46v30 RnJvbSA0ZTRmNDUxOTY0MTk0NmVlMGIzNjgzNjY0NmZiMzM5Y2JhZmFkMTgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWNrc29uIFJheSBIYW1pbHRvbiA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgpEYXRlOiBXZWQsIDI1IEZlYiAyMDE1IDAxOjU2OjQ5IC0wODAwClN1 YmplY3Q6IFtQQVRDSF0gKiBsaXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwgKHNnbWwtY2FsY3Vs YXRlLWluZGVudCk6IEZpeAogaW5kZW50LgoKUHJldmlvdXNseSwgU0dNTCBhdHRyaWJ1dGVzIHdl cmUgYWx3YXlzIGluZGVudGVkIG9uZSBhZGRpdGlvbmFsIHNwYWNlCnBhc3QgYHNnbWwtYmFzaWMt b2Zmc2V0Jy4gVGhpcyBmaXhlcyB0aGF0LgotLS0KIGxpc3AvQ2hhbmdlTG9nICAgICAgICAgICAg ICB8IDUgKysrKysKIGxpc3AvdGV4dG1vZGVzL3NnbWwtbW9kZS5lbCB8IDQgKystLQogMiBmaWxl cyBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv bGlzcC9DaGFuZ2VMb2cgYi9saXNwL0NoYW5nZUxvZwppbmRleCBmYzI4OTNlLi4xNzcxN2UwIDEw MDY0NAotLS0gYS9saXNwL0NoYW5nZUxvZworKysgYi9saXNwL0NoYW5nZUxvZwpAQCAtMSwzICsx LDggQEAKKzIwMTUtMDItMjUgIEphY2tzb24gUmF5IEhhbWlsdG9uICA8amFja3NvbkBqYWNrc29u cmF5aGFtaWx0b24uY29tPgorCisJKiBsaXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwgKHNnbWwt Y2FsY3VsYXRlLWluZGVudCk6IEZpeAorCWF0dHJpYnV0ZSBpbmRlbnRhdGlvbi4KKwogMjAxNS0w Mi0yNSAgU3RlZmFuIE1vbm5pZXIgIDxtb25uaWVyQGlyby51bW9udHJlYWwuY2E+CiAKIAkqIGVt YWNzLWxpc3AvZWRlYnVnLmVsIChlZGVidWctLWRpc3BsYXkpOiBTYXZlLWV4Y3Vyc2lvbiAoYnVn IzE5NjExKS4KZGlmZiAtLWdpdCBhL2xpc3AvdGV4dG1vZGVzL3NnbWwtbW9kZS5lbCBiL2xpc3Av dGV4dG1vZGVzL3NnbWwtbW9kZS5lbAppbmRleCAxMmQ5OGM4Li44ODdjNzBkIDEwMDY0NAotLS0g YS9saXNwL3RleHRtb2Rlcy9zZ21sLW1vZGUuZWwKKysrIGIvbGlzcC90ZXh0bW9kZXMvc2dtbC1t b2RlLmVsCkBAIC0xNTEwLDEzICsxNTEwLDEzIEBAIExDT04gaXMgdGhlIGxleGljYWwgY29udGV4 dCwgaWYgYW55LiIKICAgICAoYHBpIG5pbCkKIAogICAgIChgdGFnCi0gICAgIChnb3RvLWNoYXIg KDErIChjZHIgbGNvbikpKQorICAgICAoZ290by1jaGFyIChjZHIgbGNvbikpCiAgICAgIChza2lw LWNoYXJzLWZvcndhcmQgIl4gXHRcbiIpCTtTa2lwIHRhZyBuYW1lLgogICAgICAoc2tpcC1jaGFy cy1mb3J3YXJkICIgXHQiKQogICAgICAoaWYgKG5vdCAoZW9scCkpCiAJIChjdXJyZW50LWNvbHVt bikKICAgICAgICA7OyBUaGlzIGlzIHRoZSBmaXJzdCBhdHRyaWJ1dGU6IGluZGVudC4KLSAgICAg ICAoZ290by1jaGFyICgxKyAoY2RyIGxjb24pKSkKKyAgICAgICAoZ290by1jaGFyIChjZHIgbGNv bikpCiAgICAgICAgKCsgKGN1cnJlbnQtY29sdW1uKSBzZ21sLWJhc2ljLW9mZnNldCkpKQogCiAg ICAgKGB0ZXh0Ci0tIAoxLjkuMQoK --001a11409f08fd4102050fe73292--