From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.devel Subject: Re: Requesting review before pushing patch to ELPA Date: Mon, 2 Feb 2015 21:57:45 -0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c3025ef56c1c050e28bf3d X-Trace: ger.gmane.org 1422943075 11615 80.91.229.3 (3 Feb 2015 05:57:55 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 3 Feb 2015 05:57:55 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Feb 03 06:57:55 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YIWUh-0003Rt-Hl for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2015 06:57:51 +0100 Original-Received: from localhost ([::1]:57857 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIWUg-0004z4-Pw for ged-emacs-devel@m.gmane.org; Tue, 03 Feb 2015 00:57:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIWUd-0004yz-Fp for emacs-devel@gnu.org; Tue, 03 Feb 2015 00:57:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YIWUc-0000UB-Ck for emacs-devel@gnu.org; Tue, 03 Feb 2015 00:57:47 -0500 Original-Received: from mail-oi0-x233.google.com ([2607:f8b0:4003:c06::233]:32943) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YIWUc-0000U6-6T for emacs-devel@gnu.org; Tue, 03 Feb 2015 00:57:46 -0500 Original-Received: by mail-oi0-f51.google.com with SMTP id x69so47685280oia.10 for ; Mon, 02 Feb 2015 21:57:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=fF9wWVTyMvcjfKQ7WobT2/3YMRI6rMI9Vb+nkAuuwgc=; b=vCAu9dj6eDiooJo+QJjrxjUuETYs/VSCdlR3u/JCm+iBaj2Ojr0scPWrgW20f7xNcJ dCU1o1MgxFLryBMkrNnBPRnbMG+KrE2wz/sIDH6eENnJH6FKdKBfyYQJyLGSOX/bYRdc CdoYEPX98/ia+RjDdZ2UTilbOeX5h39YpCYhsY0YGuHpptIaPphKcIqT1e9K46lQLl+i 8G8pJP+KDCxOxxxlJR2ET2O4KmB/FXIzsJI9UTf7ETkmgWEfGSG4p3QUQ/wpKMedexiU j5vKVZh5ZugGXZguieyFSgEwhuRdZWi0nyfJ7znBwdwCTyYo4Fn2YU9BcLexE4jIhbGI tpnA== X-Received: by 10.60.67.5 with SMTP id j5mr10820934oet.21.1422943065564; Mon, 02 Feb 2015 21:57:45 -0800 (PST) Original-Received: by 10.76.24.106 with HTTP; Mon, 2 Feb 2015 21:57:45 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: l59aLP9HixPlKI3T2-Nkh85sqbk X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::233 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182310 Archived-At: --001a11c3025ef56c1c050e28bf3d Content-Type: text/plain; charset=ISO-8859-1 On the "Copyright (C) 2014 Johan Andersson", are you suggesting I change the copyright notice in ert-async.el myself, or that I should contact the author and tell him to change it? In either case that seems inappropriate. context-coloring/languages/javascript/libraries/ also includes 3 JavaScript libraries with their own copyright notices. These appear to be licensed under the FreeBSD license. Should they be handled specially? Regards, Jackson On Mon, Feb 2, 2015 at 9:58 AM, Stefan Monnier wrote: > > which included 247 commits. I am not sure if these should be squashed, > but > > based on the commit log it seems like this subtree approach is how other > > people are managing their externally-maintained packages, so I assume it > is > > okay to add the whole history. > > Indeed, it's OK to keep the history. > > > On top of that, I added 2 patches so that I could test ELPA locally. I > was > > able to install my package via a "local-elpa" as described in the README. > > The patches for that are attached in this email. > > I think the hydra-test.el has been fixed by someone else in the > mean time. As for your change: > > > +./context-coloring/libraries/ert-async.el:;; Copyright (C) 2014 Johan > Andersson > > I think this change is incorrect. IIUC this is johan.rejeep@gmail.com > we're talking bout, and he signed the copyright assignment forms, so > the line in ert-async.el should say "Copyright (C) 2014 Free Software > Foundation, Inc" (at which point you won't need any change to > copyright_exceptions). > > > Stefan > --001a11c3025ef56c1c050e28bf3d Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On the "Copyright (C) = 2014 Johan Andersson", are you suggesting I change the copyright notic= e in ert-async.el myself, or that I should contact the author and tell him = to change it?

In either case that seems inappropr= iate.

context-coloring/languages/javascript/librar= ies/ also includes 3 JavaScript libraries with their own copyright notices.= These appear to be licensed under the FreeBSD license. Should they be hand= led specially?

Regards,
Jackson
On Mon, Feb 2, 2015 at 9:58 AM, Stefan Monnier= <monnier@iro.umontreal.ca> wrote:
> which included 247 commits. I am no= t sure if these should be squashed, but
> based on the commit log it seems like this subtree approach is how oth= er
> people are managing their externally-maintained packages, so I assume = it is
> okay to add the whole history.

Indeed, it's OK to keep the history.

> On top of that, I added 2 patches so that I could test ELPA locally. I= was
> able to install my package via a "local-elpa" as described i= n the README.
> The patches for that are attached in this email.

I think the hydra-test.el has been fixed by someone else in the
mean time.=A0 As for your change:

> +./context-coloring/libraries/ert-async.el:;; Copyright (C) 2014 Johan= Andersson

I think this change is incorrect.=A0 IIUC this is johan.rejeep@gmail.com
we're talking bout, and he signed the copyright assignment forms, so the line in ert-async.el should say "Copyright (C) 2014 Free Software<= br> Foundation, Inc" (at which point you won't need any change to copy= right_exceptions).


=A0 =A0 =A0 =A0 Stefan

--001a11c3025ef56c1c050e28bf3d--