From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.devel Subject: Re: Requesting patch review Date: Mon, 9 Mar 2015 18:34:16 -0700 Message-ID: References: <54FC8D03.1060503@yandex.ru> <54FE2E7C.2050905@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e89a8f838e091d25fd0510e526f2 X-Trace: ger.gmane.org 1425951278 20096 80.91.229.3 (10 Mar 2015 01:34:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Mar 2015 01:34:38 +0000 (UTC) Cc: emacs-devel To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 10 02:34:37 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YV947-0000TH-R1 for ged-emacs-devel@m.gmane.org; Tue, 10 Mar 2015 02:34:36 +0100 Original-Received: from localhost ([::1]:46058 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV947-0005uF-3f for ged-emacs-devel@m.gmane.org; Mon, 09 Mar 2015 21:34:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV93w-0005md-I4 for emacs-devel@gnu.org; Mon, 09 Mar 2015 21:34:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YV93p-0001aY-Ib for emacs-devel@gnu.org; Mon, 09 Mar 2015 21:34:24 -0400 Original-Received: from mail-oi0-x22c.google.com ([2607:f8b0:4003:c06::22c]:43623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YV93p-0001aS-BV for emacs-devel@gnu.org; Mon, 09 Mar 2015 21:34:17 -0400 Original-Received: by oibg201 with SMTP id g201so32916990oib.10 for ; Mon, 09 Mar 2015 18:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=hGuJuV6nHUMen3SfaXzxyZ5P3JSdrx1NZzaCzQ+m3nI=; b=l570/alpqpGZk15iAjg423Iirg+mQRpinakRxCfimrfFzaZPrhgGaSEyncXxrbx8vW SuJcGITacIkvsldvrOCt+mIMg68V//ekVmcBd3+XvaVaQKJM5Fu9tNUxXQ8zzJWdZSzK n6hjLYJqOB5kgx/E9rs5WKyXBZN3Oy22h75i9Pv0h6PLOo4d4koJCkMVIZMwPixklRAl cZWH5c5RMLYo6gQojlyRkmVQa34is2e2OaFCmZq3FjIdz7lvTJbce7tQjAkrZXipc0SI Hi59VG0lyrN+pb0YVopRdEpyFTt8xuTG1EMh1Q380qZY4FgTQDRZfpZQfG8bJhpvyd/E UBaw== X-Received: by 10.182.20.237 with SMTP id q13mr3968233obe.82.1425951256551; Mon, 09 Mar 2015 18:34:16 -0700 (PDT) Original-Received: by 10.76.195.8 with HTTP; Mon, 9 Mar 2015 18:34:16 -0700 (PDT) In-Reply-To: <54FE2E7C.2050905@yandex.ru> X-Google-Sender-Auth: sUR4cdHsnBENmNukjYYjiGy5gR4 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c06::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:183756 Archived-At: --e89a8f838e091d25fd0510e526f2 Content-Type: text/plain; charset=ISO-8859-1 > Regarding the meat of the change, it should be "initializer" (Emacs prefers US spelling) I used that spelling because that's what ECMAScript uses; from http://www.ecma-international.org/ecma-262/5.1/#sec-12.2: > VariableDeclaration : Identifier Initialiser opt (Dunno who has priority here, Emacs or the spec, but I'm fine with changing it.) > maybe we should also extract the added lines into a utility function How does `js--maybe-goto-declaration-keyword-end` sound? On Mon, Mar 9, 2015 at 4:36 PM, Dmitry Gutov wrote: > On 03/09/2015 12:01 AM, Jackson Hamilton wrote: > >> For the sake of continuity I'll send my next patch through this email >> thread, but in the future I will send them to the bug tracker. >> > > Exactly what I was thinking. > > Refactored the code to be less tricky, added the additional level of >> configuration and ported the tests. >> > > Thanks! That's a bit too many test examples for my taste (especially in > js-indent-first-initialiser-t.js, since that piece of implementation is > relatively trivial), but I guess that's still much better than no tests. > > Regarding the meat of the change, it should be "initializer" (Emacs > prefers US spelling), and maybe we should also extract the added lines into > a utility function, in order not to make `js--proper-indentation' even > longer than it is now. > --e89a8f838e091d25fd0510e526f2 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
>=A0Regard= ing the meat of the change, it should be "initializer" (Emacs pre= fers US spelling)
<= br>
I used th= at spelling because that's what ECMAScript uses; from http://www.ecma-international.org/ecma-262/5.1= /#sec-12.2:

> = VariableDeclaration :=A0Identifier Initialiser opt

(Dunno who has priority here, Emacs or the spec, but I'm fine wi= th changing it.)

>= =A0maybe we should also= extract the added lines into a utility function

How does `js--maybe-goto-declaration-keyword-en= d` sound?

On Mon, Mar 9, 2015 at 4:36 PM, Dmitry Gutov &= lt;dgutov@yandex.ru> wrote:
On = 03/09/2015 12:01 AM, Jackson Hamilton wrote:
For the sake of continuity I'll send my next patch through this email thread, but in the future I will send them to the bug tracker.

 Exactly what I was thinking.

Refactored the code to be less tricky, added the additional level of
configuration and ported the tests.

 Thanks! That's a bit too many test examples for my taste (especially in= js-indent-first-initialiser-t.js, since that piece of implementatio= n is relatively trivial), but I guess that's still much better than no = tests.

Regarding the meat of the change, it should be "initializer" (Ema= cs prefers US spelling), and maybe we should also extract the added lines i= nto a utility function, in order not to make `js--proper-indentation' e= ven longer than it is now.

--e89a8f838e091d25fd0510e526f2--