> Regarding the meat of the change, it should be "initializer" (Emacs prefers US spelling) I used that spelling because that's what ECMAScript uses; from http://www.ecma-international.org/ecma-262/5.1/#sec-12.2: > VariableDeclaration : Identifier Initialiser opt (Dunno who has priority here, Emacs or the spec, but I'm fine with changing it.) > maybe we should also extract the added lines into a utility function How does `js--maybe-goto-declaration-keyword-end` sound? On Mon, Mar 9, 2015 at 4:36 PM, Dmitry Gutov wrote: > On 03/09/2015 12:01 AM, Jackson Hamilton wrote: > >> For the sake of continuity I'll send my next patch through this email >> thread, but in the future I will send them to the bug tracker. >> > > Exactly what I was thinking. > > Refactored the code to be less tricky, added the additional level of >> configuration and ported the tests. >> > > Thanks! That's a bit too many test examples for my taste (especially in > js-indent-first-initialiser-t.js, since that piece of implementation is > relatively trivial), but I guess that's still much better than no tests. > > Regarding the meat of the change, it should be "initializer" (Emacs > prefers US spelling), and maybe we should also extract the added lines into > a utility function, in order not to make `js--proper-indentation' even > longer than it is now. >