From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master e2ceef9 57/79: Prepend function symbols with octothorpes. Date: Thu, 18 Jun 2015 01:59:22 -0700 Message-ID: References: <20150614000510.19796.66727@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a11c306ee0b7d790518c7068c X-Trace: ger.gmane.org 1434618053 18994 80.91.229.3 (18 Jun 2015 09:00:53 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 18 Jun 2015 09:00:53 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 18 11:00:52 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Z5Vgi-00075r-BE for ged-emacs-devel@m.gmane.org; Thu, 18 Jun 2015 11:00:44 +0200 Original-Received: from localhost ([::1]:51096 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5Vgh-0001uh-P8 for ged-emacs-devel@m.gmane.org; Thu, 18 Jun 2015 05:00:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33033) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5VfQ-0008DS-KD for emacs-devel@gnu.org; Thu, 18 Jun 2015 04:59:25 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z5VfP-0001yg-Eg for emacs-devel@gnu.org; Thu, 18 Jun 2015 04:59:24 -0400 Original-Received: from mail-ob0-x22b.google.com ([2607:f8b0:4003:c01::22b]:36161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z5VfP-0001yW-Aq for emacs-devel@gnu.org; Thu, 18 Jun 2015 04:59:23 -0400 Original-Received: by obctg8 with SMTP id tg8so50074155obc.3 for ; Thu, 18 Jun 2015 01:59:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=8ycqdsG77ahfSGqds+vaXcoTrXPUnuczeIfGJyhE3Yw=; b=dh3/2+rlVNb9tJQP47EebCfnYESTWHD7gW3u4otg53Thb/U879Nb6wSEPHVB/JvX0a QtikcgLQJj2cujsEbXH4rDlqrWI1zZCqBkPoTDM2WaQgxw4mwXoVp16lICsrFtUe1PT0 HvLi26zHcfMMrYlALqQRQmElR2iSVnG0Y7s+4vr8I48TgWiEFNICjQ1zTMm4hO6PTOEf RAA7MlJRGK+Dm1F028IUNDrVhZKOXHtiCJCoArDCN316Q1tDunGL8/7EiFqgpQjcrlO5 0pmpcdmvwzHwhdGo9vu/hfr9i82C9s9PeQpdEwwxV0/MTc/+JtHkM2p4V8zSKlUR8nT0 Skbw== X-Received: by 10.182.246.9 with SMTP id xs9mr8059451obc.45.1434617962526; Thu, 18 Jun 2015 01:59:22 -0700 (PDT) Original-Received: by 10.76.6.73 with HTTP; Thu, 18 Jun 2015 01:59:22 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: FM4wPl-xPp1nGsiDRzbgqUOyKVI X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187277 Archived-At: --001a11c306ee0b7d790518c7068c Content-Type: text/plain; charset=UTF-8 I figured I could generate more spelling error related compiler errors if I added the hash. By that motivation, I'd prefer to add them in as many places as possible. On Sat, Jun 13, 2015 at 7:59 PM, Stefan Monnier wrote: > > - (advice-remove 'context-coloring-colorize advice) > > + (advice-remove #'context-coloring-colorize advice) > > Actually, the first argument of `advice-remove' has to be a *symbol* > (bound to a function value) rather than a function, so I think it's > better to write > > (advice-remove 'context-coloring-colorize advice) > rather than > (advice-remove #'context-coloring-colorize advice) > > IOW, I think #' only makes sense at those places where one could also > use a (lambda ...). It's largely philosophical, admittedly. > > > Stefan > --001a11c306ee0b7d790518c7068c Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
I figured I could generate more spelling error related com= piler errors if I added the hash. By that motivation, I'd prefer to add= them in as many places as possible.

On Sat, Jun 13, 2015 at 7:59 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0(advice-remove 'context-coloring-colorize advice)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= (advice-remove #'context-coloring-colorize advice)

Actually, the first argument of `advice-remove' has to be a *symbol* (bound to a function value) rather than a function, so I think it's
better to write

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(advic= e-remove 'context-coloring-colorize advice)
rather than
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(advic= e-remove #'context-coloring-colorize advice)

IOW, I think #' only makes sense at those places where one could also use a (lambda ...).=C2=A0 It's largely philosophical, admittedly.


=C2=A0 =C2=A0 =C2=A0 =C2=A0 Stefan

--001a11c306ee0b7d790518c7068c--