* Re: [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799)
[not found] ` <E1ZscOw-0003zo-CG@vcs.savannah.gnu.org>
@ 2015-10-31 20:16 ` Dmitry Gutov
2015-10-31 20:20 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Dmitry Gutov @ 2015-10-31 20:16 UTC (permalink / raw)
To: emacs-devel, Jackson Ray Hamilton
On 10/31/2015 10:05 PM, Jackson Ray Hamilton wrote:
> branch: master
> commit 958da7ff63d1d647f45fd649654136da78529324
Thank you.
> Author: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
> Commit: Jackson Ray Hamilton <jackson@jacksonrayhamilton.com>
>
> Add JSX indentation via js-jsx-mode. (Bug#21799)
>
> * progmodes/js.el: Add JSX indentation support.
> (js-jsx-indent-line)
> (js-jsx-mode): New functions.
Someone please correct me if I'm wrong, but I don't think the guidelines
allow omitting entries for "private" functions and variables. And this
commit adds several of them.
> +** js-jsx-mode (a minor variant of js-mode) provides indentation
> +support for JSX, an XML-like syntax extension to ECMAScript
This needs a period at the end.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799)
2015-10-31 20:16 ` [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799) Dmitry Gutov
@ 2015-10-31 20:20 ` Eli Zaretskii
2015-10-31 20:21 ` Jackson Hamilton
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2015-10-31 20:20 UTC (permalink / raw)
To: Dmitry Gutov; +Cc: jackson, emacs-devel
> From: Dmitry Gutov <dgutov@yandex.ru>
> Date: Sat, 31 Oct 2015 22:16:31 +0200
>
> > * progmodes/js.el: Add JSX indentation support.
> > (js-jsx-indent-line)
> > (js-jsx-mode): New functions.
>
> Someone please correct me if I'm wrong, but I don't think the guidelines
> allow omitting entries for "private" functions and variables.
You are not wrong. All new/changed functions in the changeset should
be mentioned.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799)
2015-10-31 20:20 ` Eli Zaretskii
@ 2015-10-31 20:21 ` Jackson Hamilton
2015-10-31 20:33 ` Eli Zaretskii
0 siblings, 1 reply; 7+ messages in thread
From: Jackson Hamilton @ 2015-10-31 20:21 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel, Dmitry Gutov
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
Sorry about this :( Can/how do we fix the first problem?
On Sat, Oct 31, 2015 at 1:20 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Dmitry Gutov <dgutov@yandex.ru>
> > Date: Sat, 31 Oct 2015 22:16:31 +0200
> >
> > > * progmodes/js.el: Add JSX indentation support.
> > > (js-jsx-indent-line)
> > > (js-jsx-mode): New functions.
> >
> > Someone please correct me if I'm wrong, but I don't think the guidelines
> > allow omitting entries for "private" functions and variables.
>
> You are not wrong. All new/changed functions in the changeset should
> be mentioned.
>
[-- Attachment #2: Type: text/html, Size: 1043 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799)
2015-10-31 20:21 ` Jackson Hamilton
@ 2015-10-31 20:33 ` Eli Zaretskii
2015-10-31 20:42 ` Jackson Hamilton
0 siblings, 1 reply; 7+ messages in thread
From: Eli Zaretskii @ 2015-10-31 20:33 UTC (permalink / raw)
To: Jackson Hamilton; +Cc: emacs-devel, dgutov
> Date: Sat, 31 Oct 2015 13:21:24 -0700
> From: Jackson Hamilton <jackson@jacksonrayhamilton.com>
> Cc: Dmitry Gutov <dgutov@yandex.ru>, emacs-devel <emacs-devel@gnu.org>
>
> Sorry about this :( Can/how do we fix the first problem?
Wait till ChangeLog.2 at top level is updated (should happen in a day
or two), then fix your entries there and commit ChangeLog.2.
The commit log messages cannot be fixed.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799)
2015-10-31 20:33 ` Eli Zaretskii
@ 2015-10-31 20:42 ` Jackson Hamilton
2015-11-03 5:16 ` Jackson Hamilton
0 siblings, 1 reply; 7+ messages in thread
From: Jackson Hamilton @ 2015-10-31 20:42 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel, Brief Busters
[-- Attachment #1: Type: text/plain, Size: 589 bytes --]
Pushed a fix for the missing period. Added an entry to my calendar to
update the ChangeLog.
On Sat, Oct 31, 2015 at 1:33 PM, Eli Zaretskii <eliz@gnu.org> wrote:
> > Date: Sat, 31 Oct 2015 13:21:24 -0700
> > From: Jackson Hamilton <jackson@jacksonrayhamilton.com>
> > Cc: Dmitry Gutov <dgutov@yandex.ru>, emacs-devel <emacs-devel@gnu.org>
> >
> > Sorry about this :( Can/how do we fix the first problem?
>
> Wait till ChangeLog.2 at top level is updated (should happen in a day
> or two), then fix your entries there and commit ChangeLog.2.
>
> The commit log messages cannot be fixed.
>
[-- Attachment #2: Type: text/html, Size: 1092 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799)
2015-10-31 20:42 ` Jackson Hamilton
@ 2015-11-03 5:16 ` Jackson Hamilton
2015-11-03 10:08 ` Dmitry Gutov
0 siblings, 1 reply; 7+ messages in thread
From: Jackson Hamilton @ 2015-11-03 5:16 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel, Brief Busters
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
Added the missing variables and functions to ChangeLog.2. Closes
Bug#21799.5 :-)
On Sat, Oct 31, 2015 at 1:42 PM, Jackson Hamilton <
jackson@jacksonrayhamilton.com> wrote:
> Pushed a fix for the missing period. Added an entry to my calendar to
> update the ChangeLog.
>
> On Sat, Oct 31, 2015 at 1:33 PM, Eli Zaretskii <eliz@gnu.org> wrote:
>
>> > Date: Sat, 31 Oct 2015 13:21:24 -0700
>> > From: Jackson Hamilton <jackson@jacksonrayhamilton.com>
>> > Cc: Dmitry Gutov <dgutov@yandex.ru>, emacs-devel <emacs-devel@gnu.org>
>> >
>> > Sorry about this :( Can/how do we fix the first problem?
>>
>> Wait till ChangeLog.2 at top level is updated (should happen in a day
>> or two), then fix your entries there and commit ChangeLog.2.
>>
>> The commit log messages cannot be fixed.
>>
>
>
[-- Attachment #2: Type: text/html, Size: 1657 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799)
2015-11-03 5:16 ` Jackson Hamilton
@ 2015-11-03 10:08 ` Dmitry Gutov
0 siblings, 0 replies; 7+ messages in thread
From: Dmitry Gutov @ 2015-11-03 10:08 UTC (permalink / raw)
To: Jackson Hamilton, Eli Zaretskii; +Cc: emacs-devel
On 11/03/2015 07:16 AM, Jackson Hamilton wrote:
> Added the missing variables and functions to ChangeLog.2. Closes
> Bug#21799.5 :-)
Thanks!
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-11-03 10:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151031200522.15326.84667@vcs.savannah.gnu.org>
[not found] ` <E1ZscOw-0003zo-CG@vcs.savannah.gnu.org>
2015-10-31 20:16 ` [Emacs-diffs] master 958da7f: Add JSX indentation via js-jsx-mode. (Bug#21799) Dmitry Gutov
2015-10-31 20:20 ` Eli Zaretskii
2015-10-31 20:21 ` Jackson Hamilton
2015-10-31 20:33 ` Eli Zaretskii
2015-10-31 20:42 ` Jackson Hamilton
2015-11-03 5:16 ` Jackson Hamilton
2015-11-03 10:08 ` Dmitry Gutov
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).