From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master b7d8d3c 9/9: * fixtures/test/: Don't byte-compile Date: Sat, 6 Aug 2016 10:42:55 -0700 Message-ID: References: <20160805013757.31623.20092@vcs.savannah.gnu.org> <20160805013758.9B5BB2201A4@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c03bb7290348c05396ab602 X-Trace: blaine.gmane.org 1470505445 4035 195.159.176.226 (6 Aug 2016 17:44:05 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 6 Aug 2016 17:44:05 +0000 (UTC) To: emacs-devel , Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Aug 06 19:44:01 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bW5cr-0006Z5-AY for ged-emacs-devel@m.gmane.org; Sat, 06 Aug 2016 19:43:09 +0200 Original-Received: from localhost ([::1]:50146 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW5co-0003h8-4k for ged-emacs-devel@m.gmane.org; Sat, 06 Aug 2016 13:43:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW5ch-0003T7-I3 for emacs-devel@gnu.org; Sat, 06 Aug 2016 13:43:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bW5ce-0000Al-Tw for emacs-devel@gnu.org; Sat, 06 Aug 2016 13:42:58 -0400 Original-Received: from mail-ua0-x22a.google.com ([2607:f8b0:400c:c08::22a]:36023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bW5ce-0000Ab-Mr for emacs-devel@gnu.org; Sat, 06 Aug 2016 13:42:56 -0400 Original-Received: by mail-ua0-x22a.google.com with SMTP id k91so19860426uak.3 for ; Sat, 06 Aug 2016 10:42:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to; bh=dIHjADZuYbfbwnMTgYO2AzU5roiT8SJ12C9RxZr09Oo=; b=ZqACG8M5gInQh8m9AQ9e4QusccRysNhkAZfPuMuuDsdu+ha37xL+DV40LNwE5B0AVD s7OLTMigUAxUsG8F+0pguPsWOMTnweCZ1b2AW9PcGx3yn0pEgAcHUTLMCR43dY2IBR0R MZgvX5fwBJdKYLuk10/WEeedJr3s1xsyH2vfl88r9CDKcJECMz0Pqy/Uf63IPmHVb0iH Q+B0OQSkTR/hFMR6dUPps/d0V1FTvtgALpC2oepUMK8u406l4vOAB14gN3f6nbtu4QMV 4KLaRSTCSeL+7SV2yKcjydwZl+rnSEFyATL51tNq6H8knOjEGmkC1G3+u9J2ax/FxkOC 69Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to; bh=dIHjADZuYbfbwnMTgYO2AzU5roiT8SJ12C9RxZr09Oo=; b=lxE3Ya9ji8pIcFB6BLyF0N9z39UMLuocsJDL+VZcCziTPzcDv2MAil7FUm5T5vkVMN oWOsGG1oIKGn+yYn5UZpTtv+5UJuo3lgd9zRyAz9kg3BFThfozeAIF6yfDr9T98LCGyl SzpQTbHt/HRKnzGgkCGyPPmK12x31U1IsT3XY/az2oQPPpzUMjtXpFiZg86iQq88GrQE Zu9mSY6UfwMs5vGcEyhCqhRZBZWqZQLlYq3pFp6GYn4zlWn9lQAvNgJM5jCiDoQLFuIs 7nAPPiKaheOAFabzvEh5oUNw9HTzow96wAxtZo0yFzoJByWFlQ0Swo2HrLrFZC6TRu3R F2TA== X-Gm-Message-State: AEkoousVMlKFuS64ObWcpHNjAOirviR5HtfdLf2DuitMA2aJMlb3i/UVBBxHnGbobPPnOEH4lDdnic7geHBtmg== X-Received: by 10.159.54.237 with SMTP id p100mr44527261uap.147.1470505375772; Sat, 06 Aug 2016 10:42:55 -0700 (PDT) Original-Received: by 10.103.118.134 with HTTP; Sat, 6 Aug 2016 10:42:55 -0700 (PDT) In-Reply-To: <20160805013758.9B5BB2201A4@vcs.savannah.gnu.org> X-Google-Sender-Auth: tEKSNX1bwLWL9um7OB850zzI8pk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c08::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206460 Archived-At: --94eb2c03bb7290348c05396ab602 Content-Type: text/plain; charset=UTF-8 The contents of these test fixtures are significant. Changing them caused the project's tests to fail. Can byte compilation be disabled for these files without modifying their source? (For instance, by disabling byte-compilation for the whole fixtures/ directory? Maybe through .dir-locals.el? Or maybe by respecting .elpaignore?) On Thu, Aug 4, 2016 at 6:37 PM, Stefan Monnier wrote: > branch: master > commit b7d8d3ca7f1bc279a3e8b21646ccea481c93ed46 > Author: Stefan Monnier > Commit: Stefan Monnier > > * fixtures/test/: Don't byte-compile > --- > packages/context-coloring/fixtures/test/cond.el | 1 > + > packages/context-coloring/fixtures/test/condition-case.el | 1 > + > packages/context-coloring/fixtures/test/defun.el | 1 > + > packages/context-coloring/fixtures/test/ignored.el | 1 > + > packages/context-coloring/fixtures/test/let.el | 1 > + > packages/context-coloring/fixtures/test/macroexp-let2.el | 1 > + > packages/context-coloring/fixtures/test/unbalanced-parenthesis.el | 1 > + > packages/context-coloring/fixtures/test/varlist-spacing.el | 1 > + > 8 files changed, 8 insertions(+) > > diff --git a/packages/context-coloring/fixtures/test/cond.el > b/packages/context-coloring/fixtures/test/cond.el > index d5aae5b..5ed1ec2 100644 > --- a/packages/context-coloring/fixtures/test/cond.el > +++ b/packages/context-coloring/fixtures/test/cond.el > @@ -1,3 +1,4 @@ > +;; -*- no-byte-compile:t' -*- > (let (a) > (cond > (a t) > diff --git a/packages/context-coloring/fixtures/test/condition-case.el > b/packages/context-coloring/fixtures/test/condition-case.el > index 151f591..56a5f44 100644 > --- a/packages/context-coloring/fixtures/test/condition-case.el > +++ b/packages/context-coloring/fixtures/test/condition-case.el > @@ -1,3 +1,4 @@ > +;; -*- no-byte-compile:t' -*- > (condition-case err > (progn err free) > (error err free) > diff --git a/packages/context-coloring/fixtures/test/defun.el > b/packages/context-coloring/fixtures/test/defun.el > index 10a52f6..173ba0b 100644 > --- a/packages/context-coloring/fixtures/test/defun.el > +++ b/packages/context-coloring/fixtures/test/defun.el > @@ -1,3 +1,4 @@ > +;; -*- no-byte-compile:t' -*- > (defun abc (def ghi &optional jkl) > (+ def ghi jkl free)) > > diff --git a/packages/context-coloring/fixtures/test/ignored.el > b/packages/context-coloring/fixtures/test/ignored.el > index 1f5fd42..0c540ff 100644 > --- a/packages/context-coloring/fixtures/test/ignored.el > +++ b/packages/context-coloring/fixtures/test/ignored.el > @@ -1,2 +1,3 @@ > +;; -*- no-byte-compile:t' -*- > (defun a () > (+ a 1 +1 -1 1.0 #x0 ,a :a t nil (0 . 0))) > diff --git a/packages/context-coloring/fixtures/test/let.el > b/packages/context-coloring/fixtures/test/let.el > index 49edb50..761a265 100644 > --- a/packages/context-coloring/fixtures/test/let.el > +++ b/packages/context-coloring/fixtures/test/let.el > @@ -1,3 +1,4 @@ > +;; -*- no-byte-compile:t' -*- > (let (a > (b a) > (c free) > diff --git a/packages/context-coloring/fixtures/test/macroexp-let2.el > b/packages/context-coloring/fixtures/test/macroexp-let2.el > index 1b61df2..97fbb23 100644 > --- a/packages/context-coloring/fixtures/test/macroexp-let2.el > +++ b/packages/context-coloring/fixtures/test/macroexp-let2.el > @@ -1,3 +1,4 @@ > +;; -*- no-byte-compile:t' -*- > (let (exp) > (macroexp-let2 macroexp-copyable-p v exp > v exp)) > diff --git a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el > b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el > index caaf7e2..e028aef 100644 > --- a/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el > +++ b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el > @@ -1,2 +1,3 @@ > +;; -*- no-byte-compile:t' -*- > (let ()) > (let () > diff --git a/packages/context-coloring/fixtures/test/varlist-spacing.el > b/packages/context-coloring/fixtures/test/varlist-spacing.el > index 97ec208..399cd18 100644 > --- a/packages/context-coloring/fixtures/test/varlist-spacing.el > +++ b/packages/context-coloring/fixtures/test/varlist-spacing.el > @@ -1,3 +1,4 @@ > +;; -*- no-byte-compile:t' -*- > (let ( > (a (lambda ())))) > > --94eb2c03bb7290348c05396ab602 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
The contents of these test fixtures are significant.=C2=A0= Changing them caused the project's tests to fail.=C2=A0 Can byte compi= lation be disabled for these files without modifying their source? (For ins= tance, by disabling byte-compilation for the whole fixtures/ directory?=C2= =A0 Maybe through .dir-locals.el?=C2=A0 Or maybe by respecting .elpaignore?= )

On Thu= , Aug 4, 2016 at 6:37 PM, Stefan Monnier <monnier@iro.umontreal.ca<= /a>> wrote:
branch: master
commit b7d8d3ca7f1bc279a3e8b21646ccea481c93ed46
Author: Stefan Monnier <monn= ier@iro.umontreal.ca>
Commit: Stefan Monnier <monn= ier@iro.umontreal.ca>

=C2=A0 =C2=A0 * fixtures/test/: Don't byte-compile
---
=C2=A0packages/context-coloring/fixtures/test/cond.el=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 1 +
=C2=A0packages/context-coloring/fixtures/test/condition-case.el= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0|=C2=A0 =C2=A0 1 +
=C2=A0packages/context-coloring/fixtures/test/defun.el=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 1 +
=C2=A0packages/context-coloring/fixtures/test/ignored.el=C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 1 +
=C2=A0packages/context-coloring/fixtures/test/let.el=C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 1 +
=C2=A0packages/context-coloring/fixtures/test/macroexp-let2.el=C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 1 +
=C2=A0packages/context-coloring/fixtures/test/unbalanced-parenthe= sis.el |=C2=A0 =C2=A0 1 +
=C2=A0packages/context-coloring/fixtures/test/varlist-spacing.el= =C2=A0 =C2=A0 =C2=A0 =C2=A0 |=C2=A0 =C2=A0 1 +
=C2=A08 files changed, 8 insertions(+)

diff --git a/packages/context-coloring/fixtures/test/cond.el b/package= s/context-coloring/fixtures/test/cond.el
index d5aae5b..5ed1ec2 100644
--- a/packages/context-coloring/fixtures/test/cond.el
+++ b/packages/context-coloring/fixtures/test/cond.el
@@ -1,3 +1,4 @@
+;; -*- no-byte-compile:t' -*-
=C2=A0(let (a)
=C2=A0 =C2=A0(cond
=C2=A0 =C2=A0 (a t)
diff --git a/packages/context-coloring/fixtures/test/condition-case.el b/packages/context-coloring/fixtures/test/condition-case.el=
index 151f591..56a5f44 100644
--- a/packages/context-coloring/fixtures/test/condition-case.el +++ b/packages/context-coloring/fixtures/test/condition-case.el @@ -1,3 +1,4 @@
+;; -*- no-byte-compile:t' -*-
=C2=A0(condition-case err
=C2=A0 =C2=A0 =C2=A0(progn err free)
=C2=A0 =C2=A0(error err free)
diff --git a/packages/context-coloring/fixtures/test/defun.el b/packag= es/context-coloring/fixtures/test/defun.el
index 10a52f6..173ba0b 100644
--- a/packages/context-coloring/fixtures/test/defun.el
+++ b/packages/context-coloring/fixtures/test/defun.el
@@ -1,3 +1,4 @@
+;; -*- no-byte-compile:t' -*-
=C2=A0(defun abc (def ghi &optional jkl)
=C2=A0 =C2=A0(+ def ghi jkl free))

diff --git a/packages/context-coloring/fixtures/test/ignored.el b/pack= ages/context-coloring/fixtures/test/ignored.el
index 1f5fd42..0c540ff 100644
--- a/packages/context-coloring/fixtures/test/ignored.el
+++ b/packages/context-coloring/fixtures/test/ignored.el
@@ -1,2 +1,3 @@
+;; -*- no-byte-compile:t' -*-
=C2=A0(defun a ()
=C2=A0 =C2=A0(+ a 1 +1 -1 1.0 #x0 ,a=C2=A0 =C2=A0:a t nil (0 . 0)))
diff --git a/packages/context-coloring/fixtures/test/let.el b/packages= /context-coloring/fixtures/test/let.el
index 49edb50..761a265 100644
--- a/packages/context-coloring/fixtures/test/let.el
+++ b/packages/context-coloring/fixtures/test/let.el
@@ -1,3 +1,4 @@
+;; -*- no-byte-compile:t' -*-
=C2=A0(let (a
=C2=A0 =C2=A0 =C2=A0 =C2=A0(b a)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(c free)
diff --git a/packages/context-coloring/fixtures/test/macroexp-let2.el = b/packages/context-coloring/fixtures/test/macroexp-let2.el
index 1b61df2..97fbb23 100644
--- a/packages/context-coloring/fixtures/test/macroexp-let2.el
+++ b/packages/context-coloring/fixtures/test/macroexp-let2.el
@@ -1,3 +1,4 @@
+;; -*- no-byte-compile:t' -*-
=C2=A0(let (exp)
=C2=A0 =C2=A0(macroexp-let2 macroexp-copyable-p v exp
=C2=A0 =C2=A0 =C2=A0v exp))
diff --git a/packages/context-coloring/fixtures/test/unbalanced-p= arenthesis.el b/packages/context-coloring/fixtures/test/unbalanced-parenthesis.el
index caaf7e2..e028aef 100644
--- a/packages/context-coloring/fixtures/test/unbalanced-parenthe= sis.el
+++ b/packages/context-coloring/fixtures/test/unbalanced-parenthe= sis.el
@@ -1,2 +1,3 @@
+;; -*- no-byte-compile:t' -*-
=C2=A0(let ())
=C2=A0(let ()
diff --git a/packages/context-coloring/fixtures/test/varlist-spacing.<= wbr>el b/packages/context-coloring/fixtures/test/varlist-spacing.= el
index 97ec208..399cd18 100644
--- a/packages/context-coloring/fixtures/test/varlist-spacing.el<= br> +++ b/packages/context-coloring/fixtures/test/varlist-spacing.el<= br> @@ -1,3 +1,4 @@
+;; -*- no-byte-compile:t' -*-
=C2=A0(let (
=C2=A0 =C2=A0 =C2=A0 =C2=A0(a (lambda ()))))


--94eb2c03bb7290348c05396ab602--