From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jackson Hamilton Newsgroups: gmane.emacs.devel Subject: Re: Requesting review before pushing patch to ELPA Date: Wed, 4 Feb 2015 11:46:31 -0800 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a1134fd4ab83f10050e4871d8 X-Trace: ger.gmane.org 1423079240 2081 80.91.229.3 (4 Feb 2015 19:47:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 4 Feb 2015 19:47:20 +0000 (UTC) Cc: emacs-devel To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 04 20:47:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YJ5uw-0000rW-Sq for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 20:47:19 +0100 Original-Received: from localhost ([::1]:38448 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ5uw-0000QU-Fp for ged-emacs-devel@m.gmane.org; Wed, 04 Feb 2015 14:47:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52397) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ5uE-0008Mm-0Z for emacs-devel@gnu.org; Wed, 04 Feb 2015 14:46:35 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YJ5uC-00005X-Sa for emacs-devel@gnu.org; Wed, 04 Feb 2015 14:46:33 -0500 Original-Received: from mail-ob0-x236.google.com ([2607:f8b0:4003:c01::236]:34681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YJ5uC-00005S-Ed for emacs-devel@gnu.org; Wed, 04 Feb 2015 14:46:32 -0500 Original-Received: by mail-ob0-f182.google.com with SMTP id nt9so3254182obb.13 for ; Wed, 04 Feb 2015 11:46:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=EXgGcrYK8DNyYWoj47j14Mp2pLzlUop+ba3y9Dnbrrk=; b=i7iYMNnr3S8OkwzXDdo8jRkeD0C/ZljdYHLujie/PzdZIQL8iI7UR772uMjtdkHVH7 LxPdVZUhnrQTuQI+LrUFZleXbwt+syy7hRnqSpQa8q4WhF81qccxFWxUy1HCrEVASSox kg1WkFZuBbtqFZN7F2xqdIqtMySGjJOUqUd88MCtA7PfxKDa1JX3d2iRQXCAQhgv53IG vqD/qnSRp+teIWvZPRVuQr+pzQTuJ4uGkXahzfmrmsHLaS3gS14soRJpPEq8iAZo/71L fqNhuzLlgZEsU9V7hIlCCviBsiv3mlBzxJC36Qgl/rL7HfKcO/N3SDGIa7V8f31yUwlB 7/Eg== X-Received: by 10.202.195.199 with SMTP id t190mr18676340oif.105.1423079191885; Wed, 04 Feb 2015 11:46:31 -0800 (PST) Original-Received: by 10.76.24.106 with HTTP; Wed, 4 Feb 2015 11:46:31 -0800 (PST) In-Reply-To: X-Google-Sender-Auth: bJh0ZhmhTN0LMelTdYezjYftwZs X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::236 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:182394 Archived-At: --001a1134fd4ab83f10050e4871d8 Content-Type: text/plain; charset=ISO-8859-1 js2-mode is included in the repo for development and CI purposes. I want to test in a clean environment (emacs -Q) and also on Travis CI. Having that file available lets me easily add it to the load path. I do exclude it in .elpaignore, because I expect that when context-coloring is installed, the package manager will handle the dependency instead. Yes, it is a truer statement that (in its current state) context-coloring works fine for some modes, but requires those files for non-js2-mode JavaScript modes. esprima.js is sourced from here: https://github.com/jquery/esprima/blob/1114c32c4e0ffaf47864967a835fdc0a37909f14/esprima.js escope.js is sourced from here: https://github.com/estools/escope/blob/b191ec36b744f65df094c614510ca6125284a958/escope.js extraverse.js is sourced from here: https://github.com/estools/estraverse/blob/c280df4aa75d7846328aa436ee5acd04afafc543/estraverse.js On Wed, Feb 4, 2015 at 7:14 AM, Stefan Monnier wrote: > > There are a whole bunch of people who claim copyright on those files; > their > > names are listed in the files' headers. I'll note that when I requested > > copyright assignment, I alerted the clerk that I was using these > libraries. > > The plugin doesn't work without them. > > Does context-coloring not work at all without those files, or does it > work just fine for some modes but not for others (presumably not for > javascript mode)? > > > I could probably externalize those files into an "npm" package and > instruct > > users to install a separate executable to run the JavaScript portion of > the > > plugin. But I'd much rather just include them in the package, because > then > > it "works out-of-the-box". > > Can you give me some background about where those files come from? > Have they been written specifically for context-coloring or are they > taken from some other project? > > > As for ert-async, what would be our course of action if he does not > agree? > > While it's of course possible, it seems highly unlikely, so I wouldn't > worry about it until that happens. > > > Stefan > --001a1134fd4ab83f10050e4871d8 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
js2-mode is included in the repo for development and CI pu= rposes. I want to test in a clean environment (emacs -Q) and also on Travis= CI. Having that file available lets me easily add it to the load path. I d= o exclude it in .elpaignore, because I expect that when context-coloring is= installed, the package manager will handle the dependency instead.
Yes, it is a truer statement that (in its current state) contex= t-coloring works fine for some modes, but requires those files for non-js2-= mode JavaScript modes.


On Wed, Feb 4, 2015 at 7:14 AM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
> There are a whole bunch of people who c= laim copyright on those files; their
> names are listed in the files' headers. I'll note that when I = requested
> copyright assignment, I alerted the clerk that I was using these libra= ries.
> The plugin doesn't work without them.

Does context-coloring not work at all without those files, or does i= t
work just fine for some modes but not for others (presumably not for
javascript mode)?

> I could probably externalize those files into an "npm" packa= ge and instruct
> users to install a separate executable to run the JavaScript portion o= f the
> plugin.=A0 But I'd much rather just include them in the package, b= ecause then
> it "works out-of-the-box".

Can you give me some background about where those files come from? Have they been written specifically for context-coloring or are they
taken from some other project?

> As for ert-async, what would be our course of action if he does not ag= ree?

While it's of course possible, it seems highly unlikely, so I wo= uldn't
worry about it until that happens.


=A0 =A0 =A0 =A0 Stefan

--001a1134fd4ab83f10050e4871d8--