From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.devel Subject: Re: Imports / inclusion of s.el into Emacs Date: Fri, 1 May 2020 18:56:56 +0200 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000003a49c105a499137e" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="125091"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs developers To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 01 19:09:58 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUZAh-000WFB-UR for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 19:09:55 +0200 Original-Received: from localhost ([::1]:37798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUZ0O-0003aV-0R for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 12:59:16 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:57512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUYzE-0001hG-MI for emacs-devel@gnu.org; Fri, 01 May 2020 12:58:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUYyb-0007wO-9v for emacs-devel@gnu.org; Fri, 01 May 2020 12:58:04 -0400 Original-Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]:41874) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUYya-0007w2-RN for emacs-devel@gnu.org; Fri, 01 May 2020 12:57:24 -0400 Original-Received: by mail-lj1-x22e.google.com with SMTP id j3so3148034ljg.8 for ; Fri, 01 May 2020 09:57:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ei/8uNmPIMHoYgbZTvswpGlt4aPoHxCBoy9fXxABKj4=; b=U4ueEdxDuV85Ad2G2JP1E32UmjTo7RXwa/CiuFFkiuKfMLD7ApOpIVl1E63F6LJay5 A2WYRTSSJ+JX1uU1eonpkCugqYyRRGvbKrkWi2+oBpoSLKFmimYdRzPqS1DiHnjttOP6 k5agjZVttL9PwmL/oJQwfP3n8rvpvp9IcmkOU/vaYREgRB4pWh2DBI9d4M11z52VRvKS N4SKgLrWXzew++XRb44LL+cWd76p0XRqz4RFXDd9a0JeI9+jgo1InRusT7BHercqq4E4 boc3VT3t7ou6khXdhllCRSURJ1iba8T3vfvYIcvA22pUxu31b6V2At7bmHR2UeRpZ/Fh ULkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ei/8uNmPIMHoYgbZTvswpGlt4aPoHxCBoy9fXxABKj4=; b=ZxUr8QjfceqsADpyh3uqu6cgQt1n2lWReKkdD4ybNt2TPl/yw18hqO144BpkcBbHWF nq45Te4XbX2ZwvJhD73ZuxqHiEceSPeyT/dF58mgXHXD7v9dY+h+PYTSVtY9W5pjcBBt pBQfXwZwW93Hhr0q7E8SkZv0tteH+eXACBlNhgHtk9WlG1KaZ5n6/y3QJ5okrv5IZOAW qUJbzc3/34ne3WAzi16sGUJ5OJmilqDi5urtciI+0XujioFIZlRCBVroHJQe/KY4hfk6 rdUsQBByoAZKLFWX2BLSk6Daannv41A4Ee8zZ3DE2/ULS0Tp7Q2QOJPL2ljctxDcK1zD 2iPg== X-Gm-Message-State: AGi0PuYZkye/gF02xPIc9CkX12BpmRjxQZ116x2EHYDtYMcADu2nm/NH oPwIgSf9QIQn5FlmN0A9Y+xUNVM+fhVLHSZPvDI= X-Google-Smtp-Source: APiQypKFOzcr+ttIEJHZQoY+cE3UAdRgJstvwxpnsrFV+8jYVQojLHW/lEWuaSQGBhT0yM1lQ3m4Q5wNCjrmAE1gS9g= X-Received: by 2002:a2e:9e97:: with SMTP id f23mr2827035ljk.228.1588352243087; Fri, 01 May 2020 09:57:23 -0700 (PDT) In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::22e; envelope-from=philippe.vaucher@gmail.com; helo=mail-lj1-x22e.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::22e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248317 Archived-At: --0000000000003a49c105a499137e Content-Type: text/plain; charset="UTF-8" > > > Decide how we import these, either by copyright assignments or by > importing the function signature and "simply" reimplementing these. Their > implementation is usually trivial. > > How many people have contributed to s.el? And how many lines of code > is it? I haven't looked at the code. 31 contributors, but > 90% of the commits is done by the author ( https://github.com/magnars/s.el/graphs/contributors). I have good news, basically he's 100% behind the idea, is already on the assignment file and gave us permission to use his code wholesale. Some other contributors (if not most) also already gave their assignments, so I expect them to be ok as well. I think we can move on with my proposal. You can look at https://github.com/magnars/s.el/blame/master/s.el and see which line was written by who. As you can see there's no other dependency than Emacs. Before we get going, is there something else I should wait for? Philippe --0000000000003a49c105a499137e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Decide how we import these, either by copyright ass= ignments or by importing the function signature and "simply" reim= plementing these. Their implementation is usually trivial.

How many people have contributed to s.el?=C2=A0 And how many lines of code<= br> is it?=C2=A0 I haven't looked at the code.

<= div>31 contributors, but > 90% of the commits is done by the author (https://github= .com/magnars/s.el/graphs/contributors).

I have= good news, basically he's 100% behind the idea, is already on the assi= gnment file and gave us permission to use his code wholesale.
Some other contributors (if not most) also already gave their a= ssignments, so I expect them to be ok as well.

I t= hink we can move on with my proposal. You can look at=C2=A0https://github.com/magnars/s.= el/blame/master/s.el=C2=A0and see which line was written by who. As you= can see there's no other dependency than Emacs.

Before we get going, is there something else I should wait for?

Philippe
--0000000000003a49c105a499137e--