From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.devel Subject: Imports / inclusion of s.el into Emacs Date: Fri, 1 May 2020 16:56:13 +0200 Message-ID: Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007e7f5305a497636a" Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="65341"; mail-complaints-to="usenet@ciao.gmane.io" To: Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri May 01 16:59:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jUX8n-000Gol-8F for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 16:59:49 +0200 Original-Received: from localhost ([::1]:59726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUX8m-0006G5-8G for ged-emacs-devel@m.gmane-mx.org; Fri, 01 May 2020 10:59:48 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34044) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jUX7B-0004mp-9Y for emacs-devel@gnu.org; Fri, 01 May 2020 10:58:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jUX5m-0006uU-OW for emacs-devel@gnu.org; Fri, 01 May 2020 10:58:09 -0400 Original-Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:45764) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jUX5m-0006sd-6l for emacs-devel@gnu.org; Fri, 01 May 2020 10:56:42 -0400 Original-Received: by mail-lf1-x133.google.com with SMTP id f8so4039671lfe.12 for ; Fri, 01 May 2020 07:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=JOXmBbVstdF3+OtTXINZY2Xu4AqrTLIGBEmbQART7yY=; b=bXCNPPSW5olFr6C57IOzfh+fkCzH68DN8zwzZi2CtaRcQY2oyfI3sYdWkZWfHIeSkL KWYfIhR2NQ3+slzsSh6n8uEWEfpNGXqECOx1QlbfQ3Mp9Zl4Ukkm3S70079fhxLTrLq6 Hok+Vu5e7nupBmWezI7+50EHbIY8M7kFfmIsHdUAOwfsi9aV2TEzP9YtPVrmvKmicSNb AA0J5xTUU6N/HGaYVSWFDvic19+RoHMbbpIsJaQ6l7eVWMLVNtnrGl4WMxIB3mfCLNAL s9Ptbl5vKaVxm0I2PXwSZgj/AuqKN6VfkHTgE0CYxVIDArv0f5Yu9uxa8HvUMFHR+UvS 2oUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=JOXmBbVstdF3+OtTXINZY2Xu4AqrTLIGBEmbQART7yY=; b=XW17qLlbmYMNW7wK6X8H4z/TB7KlW3eFgVogNb9Zi1ONX3tLAf2LlPxeYefav20IHl HTqwOz7p2od9Gvbpj4Naj9KOcBTIXG1RvmB3z7qiamWOtQJ3bV0+ZsBf1Iwv3qwgwaeq 9xhYoyzbCaTsTJ/ibaZ9tcaehzZI71AWnU3q4WqyiyNAXtwYNES31KeUprf0KmyMe75k 8CroSWrL5t/fKJKVHBr+qxtyU3SNF9O2JP6WCSiodZ7pzmwcYYrXsAB0quRSbR+z7R9l 4Ii0Sr7fWy1OtpCS+An9xxsMxvqphkE5SWnN+kTd2RhUThDoedVGCoBql6rySTtJojaD r3Qg== X-Gm-Message-State: AGi0PubZen5ovx7E4rZ46+mk+Z3dsGQ+UWzi8re8dd77mz0spNzjRu2b D6x7var0hVLCmhT9xA0TUX5tcOhs3IyiBSLObISoHfZp41JKOA== X-Google-Smtp-Source: APiQypLRlwb20cOsyxqmzCYhViJR+3UQrEMr9eNHLzw8nqLsn19Gk6VQSjsX9/HEbq9L7QGeeeilxBwXNMJ+YKQn5DM= X-Received: by 2002:a05:6512:53a:: with SMTP id o26mr2801809lfc.111.1588344999803; Fri, 01 May 2020 07:56:39 -0700 (PDT) Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=philippe.vaucher@gmail.com; helo=mail-lf1-x133.google.com X-detected-operating-system: by eggs.gnu.org: Error: [-] PROGRAM ABORT : Malformed IPv6 address (bad octet value). Location : parse_addr6(), p0f-client.c:67 X-Received-From: 2a00:1450:4864:20::133 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:248307 Archived-At: --0000000000007e7f5305a497636a Content-Type: text/plain; charset="UTF-8" Hello, Following our discussion about namespace I think it's time to start with something concrete where most people are agreeing already. I started an issue at https://github.com/magnars/s.el/issues/136 asking the author how he feels about inclusion/importing into Emacs. Past experiences showed me that inclusion of such public library is always complicated due to copyright assignments, but I believe we can skip that painful part as explained later on. I propose the following plan: 1. Check wether there are existing emacs `*-string-* functions that'd be aliased to start with `string-` and make a patch for that. That is, already unify the existing Emacs string library if needed. 2. Decide of a set of function that we'd "import" from s.el and namespace them under the `string-` namespace. For example, `s-prepend` would become `string-prepend`. Maybe that can be the whole API of s.el but probably that some will object to that while agreeing on a smaller set. 3. Decide how we import these, either by copyright assignments or by importing the function signature and "simply" reimplementing these. Their implementation is usually trivial. On a side note, I'm curious about 3: given the code is already GPL v3, are we allowed to simply implement the Emacs string-* function using s.el? or copy-paste from it? WARNING I know this is a very touchy subject and my goal is not to offend anyone, especially not the author of this wonderful library, I am just genuinely curious of what is allowed and what is not in this case. I'd not like to do that without the author consent. Kind regards, Philippe --0000000000007e7f5305a497636a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

Following our discussion abo= ut namespace I think it's time to start with something concrete where m= ost people are agreeing already.

I started an issu= e at=C2=A0https://gi= thub.com/magnars/s.el/issues/136=C2=A0asking the author how he feels ab= out inclusion/importing into Emacs.

Past experienc= es showed me that inclusion of such public library is always complicated du= e to copyright assignments, but I believe we can skip that painful part as = explained later on.

I propose the following plan:<= /div>
  1. =C2=A0Check wether there are existing emacs `*-string-* f= unctions that'd be aliased to start with `string-` and make a patch for= that. That is, already unify the existing Emacs string library if needed.<= /li>
  2. Decide of a set of function that we'd "import" from s= .el and namespace them under the `string-` namespace. For example, `s-prepe= nd` would become `string-prepend`. Maybe that can be the whole API of s.el = but probably that some will object to that while agreeing on a smaller set.=
  3. Decide how we import these, either by copyright assignments or by = importing the function signature and "simply" reimplementing thes= e. Their implementation is usually trivial.
On a side note, I= 'm curious about 3: given the code is already GPL v3, are we allowed to= simply implement the Emacs string-* function using s.el? or copy-paste fro= m it? WARNING I know this is a very touchy subject and my goal is not to of= fend anyone, especially not the author of this wonderful library, I am just= genuinely curious of what is allowed and what is not in this case. I'd= not like to do that without the author consent.

K= ind regards,
Philippe
--0000000000007e7f5305a497636a--