unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Philippe Vaucher <philippe.vaucher@gmail.com>
To: emacs-devel@gnu.org
Subject: [PATCH] Remove unused variable `command-debug-status'
Date: Wed, 28 Sep 2016 12:45:23 +0200	[thread overview]
Message-ID: <CAGK7Mr6Fyn=v_DZ8jdTR_8MMnSp3j5+-mEBM1vnAoea5W7h8pg@mail.gmail.com> (raw)

Hello,

This is my first attempt at submitting a patch, so keep that in mind
in case I messed up somewhere.

I already did the copyright assignment dance and it was accepted &
sent to me the 2016-09-07, do I need to send the confirmation to
someone in order to post here?

Just to be sure, I should send emails to emacs-devel as plain text
right? no html?

Anyway, back to the subject: this patch removes the variable
`command-debug-status', which really seems to be unused since a long
time to me (that's what "git -G Vcommand-debug-status" says).

I fell on it while looking to solve another problem (which will be
discussed in another email).

Thanks,
Philippe

---
 doc/lispref/debugging.texi | 12 ------------
 src/callint.c              |  6 ------
 2 files changed, 18 deletions(-)

diff --git a/doc/lispref/debugging.texi b/doc/lispref/debugging.texi
index 2f83b40..f4e63ae 100644
--- a/doc/lispref/debugging.texi
+++ b/doc/lispref/debugging.texi
@@ -644,18 +644,6 @@ the debugger.
 This function is used only by the debugger.
 @end defun

-@defvar command-debug-status
-This variable records the debugging status of the current interactive
-command.  Each time a command is called interactively, this variable is
-bound to @code{nil}.  The debugger can set this variable to leave
-information for future debugger invocations during the same command
-invocation.
-
-The advantage of using this variable rather than an ordinary global
-variable is that the data will never carry over to a subsequent command
-invocation.
-@end defvar
-
 @defun backtrace-frame frame-number
 The function @code{backtrace-frame} is intended for use in Lisp
 debuggers.  It returns information about what computation is happening
diff --git a/src/callint.c b/src/callint.c
index 053ee6c..ccb5c6a 100644
--- a/src/callint.c
+++ b/src/callint.c
@@ -928,12 +928,6 @@ Maximum length of the history list is determined
by the value
 of `history-length', which see.  */);
   Vcommand_history = Qnil;

-  DEFVAR_LISP ("command-debug-status", Vcommand_debug_status,
-       doc: /* Debugging status of current interactive command.
-Bound each time `call-interactively' is called;
-may be set by the debugger as a reminder for itself.  */);
-  Vcommand_debug_status = Qnil;
-
   DEFVAR_LISP ("mark-even-if-inactive", Vmark_even_if_inactive,
        doc: /* Non-nil means you can use the mark even when inactive.
 This option makes a difference in Transient Mark mode.
-- 
2.10.0



             reply	other threads:[~2016-09-28 10:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 10:45 Philippe Vaucher [this message]
2016-09-28 11:14 ` [PATCH] Remove unused variable `command-debug-status' Kaushal Modi
2016-09-28 11:24   ` Philippe Vaucher
2016-09-28 14:30     ` Kaushal Modi
2016-09-28 15:04       ` Philippe Vaucher
2016-10-07  6:01     ` Alexey Veretennikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAGK7Mr6Fyn=v_DZ8jdTR_8MMnSp3j5+-mEBM1vnAoea5W7h8pg@mail.gmail.com' \
    --to=philippe.vaucher@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).