From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.devel Subject: Re: tabulated-list sort icon is reversed Date: Fri, 1 Mar 2019 10:48:08 +0100 Message-ID: References: <87d0v1lsns.fsf@fastmail.fm> <532F6D74-E21C-45A2-B85B-01133DE1E8A1@scratch.space> <6e662c5b-3d04-2157-6712-aadcb6077f2b@gmail.com> <83a7j0pzbh.fsf@gnu.org> <83sgwpm92r.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000738bbd0583054f9a" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="138964"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 01 10:53:28 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gzerA-000a1v-2y for ged-emacs-devel@m.gmane.org; Fri, 01 Mar 2019 10:53:28 +0100 Original-Received: from localhost ([127.0.0.1]:53719 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzer9-0004OM-3v for ged-emacs-devel@m.gmane.org; Fri, 01 Mar 2019 04:53:27 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:40300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gzemW-00019G-DH for emacs-devel@gnu.org; Fri, 01 Mar 2019 04:48:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gzemU-00019b-PK for emacs-devel@gnu.org; Fri, 01 Mar 2019 04:48:40 -0500 Original-Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]:46547) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gzemU-000184-Em for emacs-devel@gnu.org; Fri, 01 Mar 2019 04:48:38 -0500 Original-Received: by mail-lf1-x12b.google.com with SMTP id g12so17521178lfb.13 for ; Fri, 01 Mar 2019 01:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qyn1lcL4pzz+EnxbtF58bj63wwGaGRMcqbiAhvx3duU=; b=LXy4LXuD9OqxYYa62sXCgn37n3QGtpIxnBayoqAZ21ayX+Zt8GrvQQ3Zr4ZqdaM7Hg MFnC1LueAPPF9b2JXbwlGD6hu+sr7EdG8thlTEYuG9NIjSxxBllwLNsJr1MO359nwOUb EoqZ+lxNpMJqpnOhFIDhplT9v04S4ryRFMEoXYNz9kuQfffUnEyUVE0nOzN9QHJNFFFu e16jXZI2/mOTYRrA4T4FXAgStFBVEIcN+6PWWDyVVAcf5Y+YqwACy5YjgeSyBcxlDCFS XO5cW4s9CMwMbW7RGBZTJbDtwv2JGzlqHB+hc22q2rjcccdmCxENC61F0k66eG85MnVs d/sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qyn1lcL4pzz+EnxbtF58bj63wwGaGRMcqbiAhvx3duU=; b=DJgoZZBKXMcLyn39GD5n4LfmAicTijJweqmtmV2qBwGHZgY7RiAZBAEqF72cGnqf7X 3Rt/C73Jg4TNvCos6IPIPDoe45oF28Pn6R5LC++/zUS3Y/NuiI20Y0HF4OJosNaxts9J l0Hg65iYQVBK0DuXBlt3HB6gTqsg7n61R8+lfycBNL6SYE4YlcCobBvqeeSg8Z4s4IrV o0OG37z080q5UJ1h/hR0vy8s9BiKUPFkOxSlHNNtqDmg9IX4z+oRfiB2RFOhR3jnlw7I lm1a7Pijugk9ZwGgzAh47GsP2j7vDg26Ag8NimsHk6Mm57+a3u0mgZnRGLCcafJ4GIqG ifGQ== X-Gm-Message-State: APjAAAWgGsrfgK1DKtCQi1eL3bMDCIPO8dIk7OtWp2P/rQ6ZcWMscIJN 0r13uOMatgFFz6kjBgEmNgeDymQxy6fRfouhhb72jQ== X-Google-Smtp-Source: APXvYqxCusEwChr5529fdSso1rAz0NzDe1MIvWgNkh2+rewErDfbPuHXbc78v7t1HpduKJ8HExueHX4iswx1GU4lHMI= X-Received: by 2002:a19:760d:: with SMTP id c13mr2571533lff.102.1551433714599; Fri, 01 Mar 2019 01:48:34 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::12b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233719 Archived-At: --000000000000738bbd0583054f9a Content-Type: text/plain; charset="UTF-8" > > Thanks, here attached is a patch doing that. > Anything else that patch should contain? I remember the commit message is supposed to contain the list of modified files. > I noticed a problem: I can customize the unicode char just fine, but > whenever I try to customize the glyphless char and use `emacs -nw` it > doesn't work, it still uses "^" or "v". > Okay I found that it works if I re-eval the whole `defvar tabulated-list-glyphless-char-display`, but not if I `eval-buffer` the whole buffer. I cannot understand why. I guess that `eval-buffer` triggers the loading of `tabulated-list.elc`, which resets the table to its default value. Also I was wondering if this: (defvar tabulated-list-glyphless-char-display (let ((table (make-char-table 'glyphless-char-display nil))) Should `make-char-table` purpose really be 'glyphless-char-display? I'm not familiar enough with it, but I was wondering if it could clash with the real `glyphless-char-display` variable purpose. Kind regards, Philippe --000000000000738bbd0583054f9a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks, here attached is a patch doing that.

Anything else that patch should contain?= I remember the commit message is supposed to contain the list of modified = files.

=C2=A0
I noticed a problem: I can customize the unicode= char just fine, but whenever I try to customize the glyphless char and use= `emacs -nw` it doesn't work, it still uses "^"=C2=A0 or &quo= t;v".

Okay I found that it works if I re-eval the whole `defvar tabulated-list-= glyphless-char-display`, but not if I `eval-buffer` the whole buffer. I can= not understand why. I guess that `eval-buffer` triggers the loading of `tab= ulated-list.elc`, which resets the table to its default value.
Also I was wondering if this:

(defvar= tabulated-list-glyphless-char-display
=C2=A0 (let ((tab= le (make-char-table 'glyphless-char-display nil)))=C2=A0=C2=A0

Should `make-char-table` purpose really be 'glyp= hless-char-display? I'm not familiar enough with it, but I was wonderin= g if it could clash with the real `glyphless-char-display` variable purpose= .

Kind regards,
Philippe

<= /div>
--000000000000738bbd0583054f9a--