From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.devel Subject: Re: tabulated-list sort icon is reversed Date: Sat, 2 Mar 2019 18:48:37 +0100 Message-ID: References: <87d0v1lsns.fsf@fastmail.fm> <532F6D74-E21C-45A2-B85B-01133DE1E8A1@scratch.space> <6e662c5b-3d04-2157-6712-aadcb6077f2b@gmail.com> <83a7j0pzbh.fsf@gnu.org> <83sgwpm92r.fsf@gnu.org> <83imx1h4rm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000a93fea058320238c" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="222206"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Stefan Monnier , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 02 19:06:08 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h091Q-000vVd-Pv for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 19:06:05 +0100 Original-Received: from localhost ([127.0.0.1]:57261 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h091P-0003iX-MZ for ged-emacs-devel@m.gmane.org; Sat, 02 Mar 2019 13:06:03 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h08yk-0001OE-LN for emacs-devel@gnu.org; Sat, 02 Mar 2019 13:03:19 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h08l1-0005wO-SP for emacs-devel@gnu.org; Sat, 02 Mar 2019 12:49:08 -0500 Original-Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:37040) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h08l0-0005uM-Ha; Sat, 02 Mar 2019 12:49:06 -0500 Original-Received: by mail-lj1-x22d.google.com with SMTP id a17so850460ljd.4; Sat, 02 Mar 2019 09:49:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9ElMblI3sNPoMOlyvl4spx+IFricFyLnHPf5DrD8xYs=; b=eqeMMIeWfhlXfIvgKLEjhKPi/oGJ+psR6c/KZ2cZ/myzJ6cxiLu8JBpalJ/Rh7mhIj pzQuVgqFzvJmrw/adp5C5LEPeViH0ew+8n86N36mKm30KzzZ9fC+NRRFn+03/JQyfR4L YKwXi4GFRIa031bmL8DJKyLIcp523xT/oCS1TIU+Lue8Q7Nbu4ycp4lOvSuXU5OhTyqW FDcn7YeE8L4RIKhcU/+M76al6KRxC2pqQ4WC5YFJ4PylqjzJsJGCotDZD5V3ZR5zORYh 6FtVo6Q2nEsnQ8qYPfDJxpzF1EwO3b2ft7uxAw5pDh/4CrakaUdcY1Z8qswC9SQX9TAJ zzvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9ElMblI3sNPoMOlyvl4spx+IFricFyLnHPf5DrD8xYs=; b=YbeH+wCWfANmGCYajByTacuN46U0e3dqzlf8l7p5puoXE65PFqVnAFwAFXcbBETcLp gXJEMDF8sUxP9qkzvdYVObKJvNpBmYxHZ9APVjF8rxg+ESlMVKk5YHAES3Fx9bcpLNFD 4qSsjsoFzyQH9xOLGnd90QzfyoK6eIZT65CSBpJ2q/9joI9KL80KJF7/XkpFu6tGyn6Z 1fogmnziYSxPXavJE314m7JxCTuJsDu2gWXniuCckAgXHznGNp8texHSMGRkdyVzrVt+ yqFho3GBCGvWrRopSTJ5JNZRsrxCnVMaCZVSCkaHsBewwYPsuzzkoUR2LX4N5FXO224U oHKg== X-Gm-Message-State: APjAAAXqAtNm/VXDP04dq/8xR3jnZ1LTz4el/3+UvLZmhZSQi74FRcxV uVk6yvaKFNmNfZduiDtqCWJcKXBql+7Oh1JgkfpJtw== X-Google-Smtp-Source: APXvYqzPWPquFoEAHwuxDUj02+hAu5W9n/XCaTNy67KWnW+2ph8vmh72B8c0iGb1S7EbaqRMV16QS89saaN5XdP1y3s= X-Received: by 2002:a2e:8659:: with SMTP id i25mr6152110ljj.110.1551548944038; Sat, 02 Mar 2019 09:49:04 -0800 (PST) In-Reply-To: <83imx1h4rm.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233775 Archived-At: --000000000000a93fea058320238c Content-Type: text/plain; charset="UTF-8" > Please use the ChangeLog style in the commit log messages; CONTRIBUTE > has the details. > Will do. > > +(defcustom tabulated-list-glyphless-sort-icon-desc ?^ > > + "Glyphless icon to display when sort order is descending." > > + :group 'tabulated-list > > + :type 'character) > > The doc strings for these options are too laconic, they should tell > what they are used for, and explain when the "glyphless" indicators > will be used instead of the other kind (and calling the "glyphless" > ones "icons" only adds to the confusion, so please don't). Also, > please always include :version tags with new options. > Well I used `glyphless` because that was the nomenclature already used everywhere else. If it was me I'd talk about "the symbol displayed when using the terminal" vs "the symbol displayed when using the GUI". Would you be ok with `tabulated-list-gui-sort-symbol-asc` and `tabulated-list-terminal-sort-symbol-asc` ? > > - (aset table 9650 (cons nil "^")) > > - (aset table 9660 (cons nil "v")) > > + (aset table tabulated-list-sort-icon-desc (cons nil (char-to-string > tabulated-list-glyphless-sort-icon-desc))) > > + (aset table tabulated-list-sort-icon-asc (cons nil (char-to-string > tabulated-list-glyphless-sort-icon-asc))) > > Please break these long lines into shorter ones. > > Finally, these changes should be accompanied by a suitable entry in > NEWS and by updates for the user manual, since this changes > user-visible behavior. > Alright. Thanks, Philippe --000000000000a93fea058320238c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Please use the ChangeLog styl= e in the commit log messages; CONTRIBUTE
has the details.

Will do.
=C2=A0
&= gt; +(defcustom tabulated-list-glyphless-sort-icon-desc ?^
> +=C2=A0 "Glyphless icon to display when sort order is descending.= "
> +=C2=A0 :group 'tabulated-list
> +=C2=A0 :type 'character)

The doc strings for these options are too laconic, they should tell
what they are used for, and explain when the "glyphless" indicato= rs
will be used instead of the other kind (and calling the "glyphless&quo= t;
ones "icons" only adds to the confusion, so please don't).=C2= =A0 Also,
please always include :version tags with new options.
=
Well I used `glyphless` because that was the nomenclature al= ready used everywhere else. If it was me I'd talk about "the symbo= l displayed when using the terminal" vs "the symbol displayed whe= n using the GUI".

Would you be ok with `tabul= ated-list-gui-sort-symbol-asc` and `tabulated-list-terminal-sort-symbol-asc= ` ?

=C2=A0
> -=C2=A0 =C2=A0 (aset table 9650 (cons nil "^"= ;))
> -=C2=A0 =C2=A0 (aset table 9660 (cons nil "v"))
> +=C2=A0 =C2=A0 (aset table tabulated-list-sort-icon-desc (cons nil (ch= ar-to-string tabulated-list-glyphless-sort-icon-desc)))
> +=C2=A0 =C2=A0 (aset table tabulated-list-sort-icon-asc (cons nil (cha= r-to-string tabulated-list-glyphless-sort-icon-asc)))

Please break these long lines into shorter ones.

Finally, these changes should be accompanied by a suitable entry in
NEWS and by updates for the user manual, since this changes
user-visible behavior.

Alright.

Thanks,
Philippe=C2=A0
--000000000000a93fea058320238c--