From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.devel Subject: Re: tabulated-list sort icon is reversed Date: Fri, 10 Aug 2018 22:10:21 +0200 Message-ID: References: <83a7qbtc6l.fsf@gnu.org> <83bmaqq735.fsf@gnu.org> <87d0v1lsns.fsf@fastmail.fm> <532F6D74-E21C-45A2-B85B-01133DE1E8A1@scratch.space> <6e662c5b-3d04-2157-6712-aadcb6077f2b@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="000000000000ef4a1e05731a56d0" X-Trace: blaine.gmane.org 1533931741 11020 195.159.176.226 (10 Aug 2018 20:09:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 10 Aug 2018 20:09:01 +0000 (UTC) Cc: =?UTF-8?Q?Cl=C3=A9ment_Pit=2DClaudel?= , Emacs developers To: yurivkhan@gmail.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 10 22:08:57 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1foDiS-0002kY-2O for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2018 22:08:56 +0200 Original-Received: from localhost ([::1]:57868 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foDkY-0006Na-N7 for ged-emacs-devel@m.gmane.org; Fri, 10 Aug 2018 16:11:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45315) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1foDkK-0006N6-03 for emacs-devel@gnu.org; Fri, 10 Aug 2018 16:10:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1foDkI-00018Y-8A for emacs-devel@gnu.org; Fri, 10 Aug 2018 16:10:51 -0400 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:44236) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1foDkH-00015A-Od for emacs-devel@gnu.org; Fri, 10 Aug 2018 16:10:50 -0400 Original-Received: by mail-lj1-x234.google.com with SMTP id q127-v6so8037039ljq.11 for ; Fri, 10 Aug 2018 13:10:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WOKYpx4kYfHrPJFhrQHPOIFOcu68bhquSEiQjUCUoWY=; b=clGnj/wyO4kBLhwKbyiWR6p4WoEnna3FqUZbw84q9gx/o1IsqBWRtlx6Q0qGkYE61s e0/sxfHqWJqWzXw/RMXxS2M4TThnVW+B/Bh04EFWjwRS9pdWR+Xb3QnbAjp1AzK9lyKN rta1oDhokNLZI+U4dg0/UciXf/NZEinBxYeNk7Aq5Ju6dkyI49aBKo6ubgH4GHo7pwQq dx6nvN4mi1FHm8XMAr0i0HT0brxf/w67bwUv7wRaC43CAJd0eW/+2LcnxCwNHR7nQhDD a6fxzSSDLNWb8//Dbaj+o0Io42XjC8tw2wtUpai3aEb7iT8SAVVbkh0JPBLAlWQTb7Mk oFPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WOKYpx4kYfHrPJFhrQHPOIFOcu68bhquSEiQjUCUoWY=; b=b9U/REYCpM2YRAmyl+oGFO96rvm8jGOqC7MpMQl2W2Nnz6TX2E2Qn3e9QqjXhD6oXs 25YKM/3iKcKpf0I/k5gaOze0e4PZ2XaD/TLBfbucMEzDAYY+uWU+To2rnL1JPoWF+Egn zn8lHfxl2wyK3KH6UsGw996isrO5hUkXzePeY+T53S1OuJSgwSiJhyVs/uKzEONjnUFp 9gHmEX9YrNnXla263VUL1XT4Gd+4oZCJ8TX3OeUhkdRvx7xKoWVHB5ZsXepinvTNc7rd gHLDOoCO887Wx1lWqrmY9lv2cHWR8ieUaStYOSyR9ZnOo+X67nWizxpvZg/fNlU34JZ2 ZLPA== X-Gm-Message-State: AOUpUlGapjdY4hOhRAQYksLJLbbIf9fqMD3tY6pL+7UgjdCz938lWh4/ Gh8mBdfz8JGCm34+Ktfl3FKJn2XeuH1aYxJ9zhw= X-Google-Smtp-Source: AA+uWPyogUEi3vzh11xN6n/J8yGXqPgjQ3Krifm42VMiQVG5I2z/XX8kvEDZd+JKJJuE86zujZQWPXncT1JNTO+FQhE= X-Received: by 2002:a2e:498:: with SMTP id a24-v6mr5907046ljf.27.1533931848408; Fri, 10 Aug 2018 13:10:48 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228394 Archived-At: --000000000000ef4a1e05731a56d0 Content-Type: multipart/alternative; boundary="000000000000ef4a1a05731a56ce" --000000000000ef4a1a05731a56ce Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 10, 2018 at 4:52 PM Yuri Khan wrote: > On Fri, Aug 10, 2018 at 9:15 PM Philippe Vaucher > wrote: > > > To be honest I'm losing a bit of steam here, I now suspect this patch > will never land because the ACSII part is unsolvable, and because I guess > that using an image requires quite a lot of refactoring (displaying an > inline image instead of a character is likely to be complicated). > > Fortunately there=E2=80=99s an easy escape hatch from this problem: Make = it a > defcustom. Then we can spend an inordinate amount of time bikeshedding > the default. > Good idea! Here's a patch in that direction, here are things that I'm not sure about: - variable name? `tabulated-list-sort-ascending-indicator`? `tabulated-list-sort-ascending-icon`? For ASCII, `-ascii` or `-glyphless= `? - group definition: does tabulated-list belong to another group? - 4 defcustoms or 2? For example, it could be `(defcustom tabulated-list-sort-ascending-texts '(" =E2=96=BC" "v"))`, that way you = customize both icons at the same time (it could even be only one defcustom with :a= sc keywords etc) Thanks, Philippe --000000000000ef4a1a05731a56ce Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri= , Aug 10, 2018 at 4:52 PM Yuri Khan <yurivkhan@gmail.com> wrote:
On Fri, Aug 10, 2018 at 9:15 PM Philippe Vaucher
<philipp= e.vaucher@gmail.com> wrote:

> To be honest I'm losing a bit of steam here, I now suspect this pa= tch will never land because the ACSII part is unsolvable, and because I gue= ss that using an image requires quite a lot of refactoring (displaying an i= nline image instead of a character is likely to be complicated).

Fortunately there=E2=80=99s an easy escape hatch from this problem: Make it= a
defcustom. Then we can spend an inordinate amount of time bikeshedding
the default.

Good idea! Here's a pa= tch in that direction, here are things that I'm not sure about:
  • variable name? `tabulated-list-sort-ascending-indicator`? `tabul= ated-list-sort-ascending-icon`? For ASCII, `-ascii` or `-glyphless`?
    • group definition: does tabulated-list belong to another group?
  • 4 = defcustoms or 2? For example, it could be `(defcustom tabulated-list-sort-a= scending-texts '(" =E2=96=BC" "v"))`, that way you = customize both icons at the same time (it could even be only one=C2=A0defcu= stom with :asc keywords etc)
Thanks,
Philippe=
--000000000000ef4a1a05731a56ce-- --000000000000ef4a1e05731a56d0 Content-Type: text/x-patch; charset="UTF-8"; name="0001-Allow-customization-of-sort-indicators-in-tabulated-.patch" Content-Disposition: attachment; filename="0001-Allow-customization-of-sort-indicators-in-tabulated-.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jkof752z0 RnJvbSAwYjMyNjRlY2RkYzViMjNiMDAwNTUzODdlOGNkOWM1YzRkOWRhNzY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBWYXVjaGVyIDxwaGlsaXBwZS52YXVjaGVyQGdt YWlsLmNvbT4KRGF0ZTogRnJpLCAxMCBBdWcgMjAxOCAyMTo1OToyNCArMDIwMApTdWJqZWN0OiBb UEFUQ0hdIEFsbG93IGN1c3RvbWl6YXRpb24gb2Ygc29ydCBpbmRpY2F0b3JzIGluIHRhYnVsYXRl ZC1saXN0CgoqIGxpc3AvZW1hY3MtbGlzcC90YWJ1bGF0ZWQtbGlzdC5lbDogYWRkIGN1c3RvbWl6 YXRpb24gZ3JvdXAsIGFkZAogIGRlZmN1c3RvbXMuCi0tLQogbGlzcC9lbWFjcy1saXNwL3RhYnVs YXRlZC1saXN0LmVsIHwgMzEgKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0tLQogMSBmaWxl IGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEv bGlzcC9lbWFjcy1saXNwL3RhYnVsYXRlZC1saXN0LmVsIGIvbGlzcC9lbWFjcy1saXNwL3RhYnVs YXRlZC1saXN0LmVsCmluZGV4IDU4NjE5ZWNkYTAuLjQ1NTJlZjdmOTggMTAwNjQ0Ci0tLSBhL2xp c3AvZW1hY3MtbGlzcC90YWJ1bGF0ZWQtbGlzdC5lbAorKysgYi9saXNwL2VtYWNzLWxpc3AvdGFi dWxhdGVkLWxpc3QuZWwKQEAgLTM2LDYgKzM2LDI5IEBACiAKIDs7OyBDb2RlOgogCisoZGVmZ3Jv dXAgdGFidWxhdGVkLWxpc3QgbmlsCisgICJUYWJ1bGF0ZWQtbGlzdCBjdXN0b21pemF0aW9uIGdy b3VwLiIpCisKKyhkZWZjdXN0b20gdGFidWxhdGVkLWxpc3Qtc29ydC1hc2NlbmRpbmctaWNvbiAi IOKWvCIKKyAgIkljb24gdG8gZGlzcGxheSB3aGVuIHNvcnQgb3JkZXIgaXMgYXNjZW5kaW5nLiIK KyAgOmdyb3VwICd0YWJ1bGF0ZWQtbGlzdAorICA6dHlwZSAnc3RyaW5nKQorCisoZGVmY3VzdG9t IHRhYnVsYXRlZC1saXN0LXNvcnQtZGVzY2VuZGluZy1pY29uICIg4payIgorICAiSWNvbiB0byBk aXNwbGF5IHdoZW4gc29ydCBvcmRlciBpcyBkZXNjZW5kaW5nLiIKKyAgOmdyb3VwICd0YWJ1bGF0 ZWQtbGlzdAorICA6dHlwZSAnc3RyaW5nKQorCisoZGVmY3VzdG9tIHRhYnVsYXRlZC1saXN0LXNv cnQtYXNjZW5kaW5nLWdseXBobGVzcyAidiIKKyAgIkdseXBobGVzcyBpY29uIHRvIGRpc3BsYXkg d2hlbiBzb3J0IG9yZGVyIGlzIGFzY2VuZGluZy4iCisgIDpncm91cCAndGFidWxhdGVkLWxpc3QK KyAgOnR5cGUgJ3N0cmluZykKKworKGRlZmN1c3RvbSB0YWJ1bGF0ZWQtbGlzdC1zb3J0LWRlc2Nl bmRpbmctZ2x5cGhsZXNzICJeIgorICAiR2x5cGhsZXNzIGljb24gdG8gZGlzcGxheSB3aGVuIHNv cnQgb3JkZXIgaXMgZGVzY2VuZGluZy4iCisgIDpncm91cCAndGFidWxhdGVkLWxpc3QKKyAgOnR5 cGUgJ3N0cmluZykKKwogOzsgVGhlIHJlYXNvbiBgdGFidWxhdGVkLWxpc3QtZm9ybWF0JyBhbmQg b3RoZXIgdmFyaWFibGVzIGFyZQogOzsgcGVybWFuZW50LWxvY2FsIGlzIHRvIG1ha2UgaXQgY29u dmVuaWVudCB0byBzd2l0Y2ggdG8gYSBkaWZmZXJlbnQKIDs7IG1ham9yIG1vZGUsIHN3aXRjaCBi YWNrLCBhbmQgaGF2ZSB0aGUgb3JpZ2luYWwgVGFidWxhdGVkIExpc3QgZGF0YQpAQCAtMTc2LDgg KzE5OSw4IEBAIElmIEFEVkFOQ0UgaXMgbm9uLW5pbCwgbW92ZSBmb3J3YXJkIGJ5IG9uZSBsaW5l IGFmdGVyd2FyZHMuIgogICAobGV0ICgodGFibGUgKG1ha2UtY2hhci10YWJsZSAnZ2x5cGhsZXNz LWNoYXItZGlzcGxheSBuaWwpKSkKICAgICAoc2V0LWNoYXItdGFibGUtcGFyZW50IHRhYmxlIGds eXBobGVzcy1jaGFyLWRpc3BsYXkpCiAgICAgOzsgU29tZSB0ZXh0IHRlcm1pbmFscyBjYW4ndCBk aXNwbGF5IHRoZSBVbmljb2RlIGFycm93czsgYmUgc2FmZS4KLSAgICAoYXNldCB0YWJsZSA5NjUw IChjb25zIG5pbCAiXiIpKQotICAgIChhc2V0IHRhYmxlIDk2NjAgKGNvbnMgbmlsICJ2IikpCisg ICAgKGFzZXQgdGFibGUgOTY1MCAoY29ucyBuaWwgdGFidWxhdGVkLWxpc3Qtc29ydC1kZXNjZW5k aW5nLWdseXBobGVzcykpCisgICAgKGFzZXQgdGFibGUgOTY2MCAoY29ucyBuaWwgdGFidWxhdGVk LWxpc3Qtc29ydC1hc2NlbmRpbmctZ2x5cGhsZXNzKSkKICAgICB0YWJsZSkKICAgIlRoZSBgZ2x5 cGhsZXNzLWNoYXItZGlzcGxheScgdGFibGUgaW4gVGFidWxhdGVkIExpc3QgYnVmZmVycy4iKQog CkBAIC0yMjksOCArMjUyLDggQEAgUG9wdWxhdGVkIGJ5IGB0YWJ1bGF0ZWQtbGlzdC1pbml0LWhl YWRlcicuIikKIAkJICAoY29uY2F0IGxhYmVsCiAJCQkgIChjb25kCiAJCQkgICAoKD4gKCsgMiAo bGVuZ3RoIGxhYmVsKSkgd2lkdGgpICIiKQotCQkJICAgKChjZHIgdGFidWxhdGVkLWxpc3Qtc29y dC1rZXkpICIg4payIikKLQkJCSAgICh0ICIg4pa8IikpKQorCQkJICAgKChjZHIgdGFidWxhdGVk LWxpc3Qtc29ydC1rZXkpIHRhYnVsYXRlZC1saXN0LXNvcnQtZGVzY2VuZGluZy1pY29uKQorCQkJ ICAgKHQgdGFidWxhdGVkLWxpc3Qtc29ydC1hc2NlbmRpbmctaWNvbikpKQogCQkgICdmYWNlICdi b2xkCiAJCSAgJ3RhYnVsYXRlZC1saXN0LWNvbHVtbi1uYW1lIGxhYmVsCiAJCSAgYnV0dG9uLXBy b3BzKSkKLS0gCjIuMTguMAoK --000000000000ef4a1e05731a56d0--