From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Philippe Vaucher Newsgroups: gmane.emacs.devel Subject: Re: branch master segfault (2019-02-05) Date: Wed, 6 Feb 2019 17:23:11 +0100 Message-ID: References: <83ftt2tc0e.fsf@gnu.org> <83y36ssyzq.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000e9b4ac05813c25b2" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="51817"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 06 17:23:55 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1grPzN-000DM3-EQ for ged-emacs-devel@m.gmane.org; Wed, 06 Feb 2019 17:23:53 +0100 Original-Received: from localhost ([127.0.0.1]:53397 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grPzM-00043c-De for ged-emacs-devel@m.gmane.org; Wed, 06 Feb 2019 11:23:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1grPzG-000433-8i for emacs-devel@gnu.org; Wed, 06 Feb 2019 11:23:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1grPzE-0005nr-AL for emacs-devel@gnu.org; Wed, 06 Feb 2019 11:23:46 -0500 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:39695) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1grPzA-0005kZ-NV; Wed, 06 Feb 2019 11:23:41 -0500 Original-Received: by mail-lj1-x234.google.com with SMTP id t9-v6so6600981ljh.6; Wed, 06 Feb 2019 08:23:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P2B5pGUPIdt7E1819qiiYAhUgH+V0Mekdoexwvp0hDA=; b=nvkBOrCRWiYZRAAYW+9s4RjJX4DUpuu7bQ9kH7FJgGqLycmC6tuUHxDatQC2nbP/eF Gey080mZqkzTHO9bwN9caHPw2Cj759X2cw2EedGsfYeUT9u9p+B0D4BJviAOozqLmBDI PGuteM8OCYYYJi427C+VkjJeiyHcvzC8hoamHJf8KvY45RgGH/VYeXauDuymcwKbkEPi VdYZJQgMIQIM14qqnEr3y3SjwMGEbmakaUHqThiB99OlLS/GTT7/qu8rESU9P9zh8vfD 5Z/bqS5s32aqgvUsuYM+QCzXCLnD1r+Ozyd/+dw9MsjUiA6IZx+G4Vz+MsvLT9pAYzRx NSdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P2B5pGUPIdt7E1819qiiYAhUgH+V0Mekdoexwvp0hDA=; b=nJqrgcJcELdU2LJWimuYBcrBh+BZlSzGSLL8YnBUXPwu/v8I3xQWob80aG4SzyQSwj g2el8yYb2B1ZWK1PEo0xv2CeihSnYt0vXOvCMg1XP174f6PyHsBGsapKIUOvKd6KHOTG 0ORUbRVXcE8RRgBZhNC5WNC0IwzbEHdjSqkc84U5d5HZzqp1FtArqAsc5mFzVqaOf5A7 eUIjA+zYRjgvEMMB7qNDBUAX5iUGVOTq99PqxE8T2AaT8FT8skpc0vGFcer34zNB3K1P 2iN47YRJfve65a/Oxs74uqxCYGmhMoqWB52Lm/bWdDKycJJFu3miKScAaug7apWRIqIE zeuA== X-Gm-Message-State: AHQUAuZBT2PA6mkycEWPU/7P5y8wBvjAbYajtNLcOhaN4e/jYoQp6bdN t6jX90NXrp99pxKt1HRxpSo4FI+wU9eO32Jx8BrKJG3f X-Google-Smtp-Source: AHgI3IaqjUY46JMjosU1XwKLGN5TwSIxH+NseSBTQaKv/EZ/Fy/yQyx9RZbWnWmkJr2dgJ/7RKTpust2MFPXQOYTauA= X-Received: by 2002:a2e:45d:: with SMTP id 90-v6mr7100354lje.110.1549470217645; Wed, 06 Feb 2019 08:23:37 -0800 (PST) In-Reply-To: <83y36ssyzq.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:233051 Archived-At: --000000000000e9b4ac05813c25b2 Content-Type: text/plain; charset="UTF-8" > > > Okay, Emacs works if I in term.c:753 if I use this: > > > > ``` > > coding = FRAME_TERMINAL_CODING (f); > > ``` > > > > instead of: > > > > ``` > > coding = (FRAME_TERMINAL_CODING (f)->common_flags & > CODING_REQUIRE_ENCODING_MASK ? > > FRAME_TERMINAL_CODING (f) : &safe_terminal_coding); > > ``` > > > > I know docker allocates a "pseudo TTY", so probably that there's a > misdetection happening here. > > No, it isn't misdetection. The problem is that safe_terminal_coding > is not set up. > Your patch works, thanks! Just curious, does that mean that in "normal terminals" (not docker) it uses `FRAME_TERMINAL_CODING (f)` but in docker it uses `safe_terminal_coding`? If yes, why does it also work in Docker when using `FRAME_TERMINAL_CODING (f)`? Kind regards, Philippe --000000000000e9b4ac05813c25b2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
> Okay, Emacs works if I in term.c:753 if I use this:=
>
> ```
> coding =3D FRAME_TERMINAL_CODING (f);
> ```
>
> instead of:
>
> ```
> coding =3D (FRAME_TERMINAL_CODING (f)->common_flags & CODING_RE= QUIRE_ENCODING_MASK ?
> FRAME_TERMINAL_CODING (f) : &safe_terminal_coding);
> ```
>
> I know docker allocates a "pseudo TTY", so probably that the= re's a misdetection happening here.

No, it isn't misdetection.=C2=A0 The problem is that safe_terminal_codi= ng
is not set up.

Your patch works, thanks= !

Just curious, does that mean that in "norma= l terminals" (not docker) it uses `FRAME_TERMINAL_CODING (f)` but in d= ocker it uses `safe_terminal_coding`?

If yes, why = does it also work in Docker when using `FRAME_TERMINAL_CODING (f)`?

Kind regards,
Philippe
--000000000000e9b4ac05813c25b2--