From: Philippe Vaucher <philippe.vaucher@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: branch master segfault (2019-02-05)
Date: Wed, 6 Feb 2019 17:23:11 +0100 [thread overview]
Message-ID: <CAGK7Mr413K1uLVQ4R1MdBbmY2yWSO6HEzceJms9LeFGmy7WTww@mail.gmail.com> (raw)
In-Reply-To: <83y36ssyzq.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 785 bytes --]
>
> > Okay, Emacs works if I in term.c:753 if I use this:
> >
> > ```
> > coding = FRAME_TERMINAL_CODING (f);
> > ```
> >
> > instead of:
> >
> > ```
> > coding = (FRAME_TERMINAL_CODING (f)->common_flags &
> CODING_REQUIRE_ENCODING_MASK ?
> > FRAME_TERMINAL_CODING (f) : &safe_terminal_coding);
> > ```
> >
> > I know docker allocates a "pseudo TTY", so probably that there's a
> misdetection happening here.
>
> No, it isn't misdetection. The problem is that safe_terminal_coding
> is not set up.
>
Your patch works, thanks!
Just curious, does that mean that in "normal terminals" (not docker) it
uses `FRAME_TERMINAL_CODING (f)` but in docker it uses
`safe_terminal_coding`?
If yes, why does it also work in Docker when using `FRAME_TERMINAL_CODING
(f)`?
Kind regards,
Philippe
[-- Attachment #2: Type: text/html, Size: 1207 bytes --]
next prev parent reply other threads:[~2019-02-06 16:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 14:48 branch master segfault (2019-02-05) Philippe Vaucher
2019-02-05 16:50 ` Eli Zaretskii
2019-02-06 9:00 ` Philippe Vaucher
[not found] ` <CAGK7Mr5KL6HPuemBXEHNQ_g6+KqhCoQPAOtQZ+zQ0mMsjQ8--A@mail.gmail.com>
2019-02-06 9:30 ` Philippe Vaucher
2019-02-06 10:33 ` Philippe Vaucher
2019-02-06 15:33 ` Eli Zaretskii
2019-02-06 15:44 ` Eli Zaretskii
2019-02-06 16:23 ` Philippe Vaucher [this message]
2019-02-06 16:45 ` Eli Zaretskii
2019-02-06 19:00 ` Philippe Vaucher
2019-02-06 19:46 ` Eli Zaretskii
2019-02-09 17:15 ` Philippe Vaucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGK7Mr413K1uLVQ4R1MdBbmY2yWSO6HEzceJms9LeFGmy7WTww@mail.gmail.com \
--to=philippe.vaucher@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).