From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: use-package.el -> Emacs core Date: Tue, 10 Nov 2015 00:37:04 -0500 Message-ID: References: <871tbyo7zd.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e013a06be9995f805242919f6 X-Trace: ger.gmane.org 1447133852 1342 80.91.229.3 (10 Nov 2015 05:37:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 10 Nov 2015 05:37:32 +0000 (UTC) Cc: Emacs developers To: Bruce Connor , johnw@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 10 06:37:26 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zw1cR-0002kS-Ca for ged-emacs-devel@m.gmane.org; Tue, 10 Nov 2015 06:37:23 +0100 Original-Received: from localhost ([::1]:57659 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw1cQ-0007dc-1X for ged-emacs-devel@m.gmane.org; Tue, 10 Nov 2015 00:37:22 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw1cC-0007dW-Ha for emacs-devel@gnu.org; Tue, 10 Nov 2015 00:37:09 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zw1cB-0001VE-In for emacs-devel@gnu.org; Tue, 10 Nov 2015 00:37:08 -0500 Original-Received: from mail-ob0-x22f.google.com ([2607:f8b0:4003:c01::22f]:34143) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw1c9-0001Um-Q6; Tue, 10 Nov 2015 00:37:05 -0500 Original-Received: by obbza9 with SMTP id za9so157568598obb.1; Mon, 09 Nov 2015 21:37:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=sVTBbBUTzA937q/0IRPGzdk5GxL+Yh9QVJ8CqeIjNUw=; b=f6XR2fGn80YnsrCU0jyqWE40Irm1Qx0FB2FzXyGIbC0DejS2E6Br4JzG6N9F7QMZEI mE2Sv7/sgi57ky5cP0C8K96TbAQo5j1ZYTHRqEPV3EX5xzCmD6D2cpne26idLuOwmzem tQC8No9tSmBc193EUS8QOVOgv8txAzp74CWvv/5FCRufcNFjj06b0sHLJI2Z3aQ0a1yS WkJpOS/A2jb7O9WH9WpBe9n3Qc4/AwHvEQhWmt1DLW5YKUc6N9pccNEJFUB+Aa6IliPe pgvxWkuGLmozD6dhbYxzbaNLDijMebuaTAEH0Gfs8l4mGUk2CaPIUdCbHwm91ToACPGr OB0A== X-Received: by 10.182.153.101 with SMTP id vf5mr735368obb.81.1447133825305; Mon, 09 Nov 2015 21:37:05 -0800 (PST) Original-Received: by 10.202.80.133 with HTTP; Mon, 9 Nov 2015 21:37:04 -0800 (PST) Original-Received: by 10.202.80.133 with HTTP; Mon, 9 Nov 2015 21:37:04 -0800 (PST) In-Reply-To: <871tbyo7zd.fsf@gmail.com> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c01::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:193817 Archived-At: --089e013a06be9995f805242919f6 Content-Type: text/plain; charset=UTF-8 I use the use-package and bind-key packages in my config. The use-package would be nice to have in the core but I think bind-key should not be put into the core as it is. The primary reason is that it creates duplication and thus confusion for new users. For define-key, we have (define-key MAP KEY-VECTOR COMMAND) whereas we have (bind-key KEY-STRING COMMAND MAP) Notice the shuffling of arguments and difference between the way the keys are to be represented in the argument. I see the benefits of bind-key*, bind-keys and bind-keys*, but I believe that that should be merged with define-key. The describe-personal-keybindings is useful. But how will it work as expected if packages in the core started using bind-key macros. We then need a robust means to distinguish between the default bindings and the bindings in user config. I don't have a proposal for the complete solution, but these are few things that didn't feel right to me about putting bind-keys in core. --089e013a06be9995f805242919f6 Content-Type: text/html; charset=UTF-8

I use the use-package and bind-key packages in my config.

The use-package would be nice to have in the core but I think bind-key should not be put into the core as it is.

The primary reason is that it creates duplication and thus confusion for new users.

For define-key, we have

(define-key MAP KEY-VECTOR COMMAND)

whereas we have

(bind-key KEY-STRING COMMAND MAP)

Notice the shuffling of arguments and difference between the way the keys are to be represented in the argument.

I see the benefits of bind-key*, bind-keys and bind-keys*, but I believe that that should be merged with define-key.

The describe-personal-keybindings is useful. But how will it work as expected if packages in the core started using bind-key macros. We then need a robust means to distinguish between the default bindings and the bindings in user config.

I don't have a proposal for the complete solution, but these are few things that didn't feel right to me about putting bind-keys in core.

--089e013a06be9995f805242919f6--