From: Kaushal <kaushal.modi@gmail.com>
To: Juri Linkov <juri@linkov.net>
Cc: Eli Zaretskii <eliz@gnu.org>,
Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: Suggestion to have highlight related bindings consistent between search-map and hi-lock-map
Date: Thu, 20 Aug 2015 01:09:12 +0000 [thread overview]
Message-ID: <CAFyQvY3bkbGRtrr6z_mYOPd902r0PnA2B+0=cXsRd+E493oL0w@mail.gmail.com> (raw)
In-Reply-To: <878u96yl2o.fsf@mail.linkov.net>
[-- Attachment #1: Type: text/plain, Size: 1980 bytes --]
Great! Then should the patch be applied? I haven't heard from anyone that
this change will break a 3rd party package.
I don't have commit rights. So either you, Stefan or someone else having
the commit rights will have to apply the patch.
Thanks.
On Wed, Aug 19, 2015 at 6:28 PM Juri Linkov <juri@linkov.net> wrote:
> > @Juri So what did you think?
>
> Stefan says, it is not worth it, if it is not breaking third-party
> packages.
>
> > On Thu, Jul 30, 2015 at 9:32 PM Kaushal <kaushal.modi@gmail.com> wrote:
> >> I thought quite some bit on how we can add in a warning for key binding
> >> change. But as Stefan says, it is probably not worth it.
> >>
> >> First of, we would need to create a wrapper function or a wrapper macro
> to
> >> create wrapper functions for all the commands that we want to phase out
> >> from being bound with the "C-x w" prefix map. The wrapper function will
> >> call the wrapped function and then issue a warning/message in the echo
> area
> >> saying that that function is already bound to "M-s h" prefix and will no
> >> longer be bound to "C-x w" prefix in future. After that, in a future
> emacs
> >> version, the final step to unbind those "C-x w" bindings will remain.
> >>
> >> On Thu, Jul 30, 2015 at 6:48 PM Stefan Monnier <
> monnier@iro.umontreal.ca>
> >> wrote:
> >>
> >>> > Do we have a 2-step deprecation process where the first step
> >>> > is to warn the users about the planned changes by issuing
> >>> > a message like “use the new key instead” like we do with
> >>> > ‘define-obsolete-function-alias’ and ‘make-obsolete-variable’?
> >>>
> >>> No, for key-bindings we just make the change, since we don't pay nearly
> >>> as much attention to breaking "user compatibility" (which can be fixed
> >>> with a define-key in ~/.emacs).
> >>> OTOH if the change ends up breaking third-party packages it might be
> >>> more problematic.
> >>>
> >>>
> >>> Stefan
>
[-- Attachment #2: Type: text/html, Size: 2722 bytes --]
next prev parent reply other threads:[~2015-08-20 1:09 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 19:02 Suggestion to have highlight related bindings consistent between search-map and hi-lock-map Kaushal
2015-07-11 18:50 ` Kaushal
2015-07-11 19:48 ` Juri Linkov
2015-07-11 19:51 ` Kaushal
2015-07-12 7:07 ` Vaidheeswaran C
2015-07-12 13:21 ` Kaushal
2015-07-12 14:48 ` Vaidheeswaran C
2015-07-12 14:48 ` Vaidheeswaran C
2015-07-12 15:15 ` Eli Zaretskii
2015-07-12 15:33 ` Vaidheeswaran C
2015-07-12 16:25 ` Eli Zaretskii
2015-07-12 16:41 ` Kaushal
2015-07-19 7:59 ` Vaidheeswaran C
2015-07-29 2:00 ` Kaushal
2015-07-29 22:31 ` Juri Linkov
2015-07-30 22:48 ` Stefan Monnier
2015-07-31 1:32 ` Kaushal
2015-08-18 16:22 ` Kaushal
2015-08-19 22:23 ` Juri Linkov
2015-08-20 1:09 ` Kaushal [this message]
2016-02-02 20:45 ` Kaushal Modi
2016-02-05 0:54 ` Juri Linkov
2016-02-05 1:48 ` John Wiegley
2016-02-05 17:00 ` Kaushal Modi
2016-02-07 17:57 ` John Wiegley
2016-02-07 19:23 ` Alan Mackenzie
2015-07-15 15:44 ` David Koppelman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY3bkbGRtrr6z_mYOPd902r0PnA2B+0=cXsRd+E493oL0w@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=juri@linkov.net \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).