From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Remove unused variable `command-debug-status' Date: Wed, 28 Sep 2016 11:14:33 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c03fc92e7b936053d8f7774 X-Trace: blaine.gmane.org 1475061354 20548 195.159.176.226 (28 Sep 2016 11:15:54 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 28 Sep 2016 11:15:54 +0000 (UTC) To: Philippe Vaucher , Emacs developers Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 28 13:15:48 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bpCq2-0004Mv-4s for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2016 13:15:46 +0200 Original-Received: from localhost ([::1]:57726 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpCq0-0005iO-Ax for ged-emacs-devel@m.gmane.org; Wed, 28 Sep 2016 07:15:44 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpCp5-0005fB-QA for emacs-devel@gnu.org; Wed, 28 Sep 2016 07:14:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bpCp3-0000qC-JN for emacs-devel@gnu.org; Wed, 28 Sep 2016 07:14:46 -0400 Original-Received: from mail-ua0-x22d.google.com ([2607:f8b0:400c:c08::22d]:33161) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bpCp3-0000pP-EP for emacs-devel@gnu.org; Wed, 28 Sep 2016 07:14:45 -0400 Original-Received: by mail-ua0-x22d.google.com with SMTP id i25so34636731uab.0 for ; Wed, 28 Sep 2016 04:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=qEaFSCSthnNtnHk1JiHuAI0q8fFnALgM2YM1dfZQ1W8=; b=heCciF19uTLKTJUtAXlnXf4d3vZ3Bovcn6nJb+44xrmViIjOVoigwviZT3PwqKNhOW U9zWmlZ4zpaIGqrhi3hwjp/0PtG4jD1KFLfMf0lsAcDB/gIxJyNoL2kOGcFb2fnOZ9dy GEhYegkgCVfa0XrPrg051z4AGMgPDHJvG5YU54/C1Qp1F5aMayV1IN5JmoRJup68vLsu V8c97YOUwkrm1sUjtyus5Xo+qehBemObi5mr1cET4xaOkiBssjZiDr4WyD9yqOsJwZ1F 1wGpCljCpJqlNEPanBybD3EcQKR14vdfewjiFPWbaxV+Pua5rCe2BSx90O8GM1RXKTko PPkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=qEaFSCSthnNtnHk1JiHuAI0q8fFnALgM2YM1dfZQ1W8=; b=XD0tIDMvKEmWtFloc0nQJ2N5MnRxnScJcmhySQd4X2Ma0CCZEaWkeYNFv71gEusIF+ BjQcKRtgit+THC3zYMSEwaD1IHzvSbgkpwgtG5+Kwx4yrnq5v79ocASDzf3YDbF8EgeR eGfc6Gi4d62nSOqs7vV1NdK1InIa0h3mKbY2t28jGzzQA1ujCvsaQLUrCfKx4+LZ5BQt jmzJknyrnQd0s7CVXZvtA6cogV5vVrHo8JlAMybi3cK0+xGpIfsqSTZrMJI3t4UkTpGr C7nW0MnptXaW/89NnbOzeIsD3OFqqIz2tR4fmlXwlm/2HW4tqvrkQo1UFx/MdU+6sraO AYDg== X-Gm-Message-State: AA6/9RnT3G+5AXyylKFe1dXklbKXK0jZaE0zfQXT4l01rqivH9LaWuJazmyhk+1XzsqpC2uvwbLBHsfQpErbfQ== X-Received: by 10.159.32.101 with SMTP id 92mr5101442uam.123.1475061284844; Wed, 28 Sep 2016 04:14:44 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c08::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:207853 Archived-At: --94eb2c03fc92e7b936053d8f7774 Content-Type: text/plain; charset=UTF-8 On Wed, Sep 28, 2016, 6:47 AM Philippe Vaucher wrote: > Hello, > > This is my first attempt at submitting a patch, so keep that in mind > in case I messed up somewhere. > Awesome! :) > I already did the copyright assignment dance and it was accepted & > sent to me the 2016-09-07, do I need to send the confirmation to > someone in order to post here? > When I sent my first patch, I asked the person who helped commit that to look up my name in the list of people who have assigned their copyright. > Just to be sure, I should send emails to emacs-devel as plain text > right? no html? > The patches should be sent as bug reports. That way, the patch and the reasoning behind it stays together in a clean bug thread. Also the commit to master can then refer to that (Bug#NNNNN). So, no guesswork is involved if someone wants to understand why a particular commit was made. > Anyway, back to the subject: this patch removes the variable .. > Do you want to take this discussion to a bug thread? Simply email the exact same thing to bug-gnu-emacs@gnu.org. > -- Kaushal Modi --94eb2c03fc92e7b936053d8f7774 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On Wed, Sep 28, 2016, 6:47 = AM Philippe Vaucher <phili= ppe.vaucher@gmail.com> wrote:
Hello,

This is my first attempt at submitting a patch, so keep that in mind
in case I messed up somewhere.

Aw= esome! :)


I already did the copyright assignment dance and it was accepted &
sent to me the 2016-09-07, do I need to send the confirmation to
someone in order to post here?

Wh= en I sent my first patch, I asked the person who helped commit that to look= up my name in the list of people who have assigned their copyright.=C2=A0<= /div>


Just to be sure, I should send emails to emacs-devel as plain text
right? no html?

The patches shoul= d be sent as bug reports. That way, the patch and the reasoning behind it s= tays together in a clean bug thread. Also the commit to master can then ref= er to that (Bug#NNNNN). So, no guesswork is involved if someone wants to un= derstand why a particular commit was made.=C2=A0


Anyway, back to the subject: this patch removes the variable ..

Do you want to take this discussion to a bug= thread? Simply email the exact same thing to bug-gnu-emacs@gnu.org.=C2=A0
--

Kaushal Modi

--94eb2c03fc92e7b936053d8f7774--