unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Philippe Vaucher <philippe.vaucher@gmail.com>,
	Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] Remove unused variable `command-debug-status'
Date: Wed, 28 Sep 2016 11:14:33 +0000	[thread overview]
Message-ID: <CAFyQvY3=v0G=DO+H1YYHXfo5jHUSc-ao0oMPOACCJzgc5KN7Zg@mail.gmail.com> (raw)
In-Reply-To: <CAGK7Mr6Fyn=v_DZ8jdTR_8MMnSp3j5+-mEBM1vnAoea5W7h8pg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

On Wed, Sep 28, 2016, 6:47 AM Philippe Vaucher <philippe.vaucher@gmail.com>
wrote:

> Hello,
>
> This is my first attempt at submitting a patch, so keep that in mind
> in case I messed up somewhere.
>

Awesome! :)


> I already did the copyright assignment dance and it was accepted &
> sent to me the 2016-09-07, do I need to send the confirmation to
> someone in order to post here?
>

When I sent my first patch, I asked the person who helped commit that to
look up my name in the list of people who have assigned their copyright.


> Just to be sure, I should send emails to emacs-devel as plain text
> right? no html?
>

The patches should be sent as bug reports. That way, the patch and the
reasoning behind it stays together in a clean bug thread. Also the commit
to master can then refer to that (Bug#NNNNN). So, no guesswork is involved
if someone wants to understand why a particular commit was made.


> Anyway, back to the subject: this patch removes the variable ..
>

Do you want to take this discussion to a bug thread? Simply email the exact
same thing to bug-gnu-emacs@gnu.org.

> --

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2282 bytes --]

  reply	other threads:[~2016-09-28 11:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-28 10:45 [PATCH] Remove unused variable `command-debug-status' Philippe Vaucher
2016-09-28 11:14 ` Kaushal Modi [this message]
2016-09-28 11:24   ` Philippe Vaucher
2016-09-28 14:30     ` Kaushal Modi
2016-09-28 15:04       ` Philippe Vaucher
2016-10-07  6:01     ` Alexey Veretennikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY3=v0G=DO+H1YYHXfo5jHUSc-ao0oMPOACCJzgc5KN7Zg@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=philippe.vaucher@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).