From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 9ed3685a77: Lots of refactorings and a few minor improvements. Date: Wed, 04 Jan 2017 13:56:47 +0000 Message-ID: References: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=94eb2c0946467ddac80545452873 X-Trace: blaine.gmane.org 1483538532 30357 195.159.176.226 (4 Jan 2017 14:02:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 4 Jan 2017 14:02:12 +0000 (UTC) Cc: Paul Eggert , Tino Calancha , Emacs developers To: Stefan Merten Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 04 15:02:04 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cOm8W-0006GZ-Ta for ged-emacs-devel@m.gmane.org; Wed, 04 Jan 2017 15:01:53 +0100 Original-Received: from localhost ([::1]:39502 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOm8b-0006kM-2q for ged-emacs-devel@m.gmane.org; Wed, 04 Jan 2017 09:01:57 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57873) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cOm3n-0002l7-RB for emacs-devel@gnu.org; Wed, 04 Jan 2017 08:57:00 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cOm3m-00036t-R9 for emacs-devel@gnu.org; Wed, 04 Jan 2017 08:56:59 -0500 Original-Received: from mail-vk0-x242.google.com ([2607:f8b0:400c:c05::242]:34147) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cOm3m-00036g-Lo for emacs-devel@gnu.org; Wed, 04 Jan 2017 08:56:58 -0500 Original-Received: by mail-vk0-x242.google.com with SMTP id p9so32879698vkd.1 for ; Wed, 04 Jan 2017 05:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xJmNi3kQArTjRelcCqSQAaHHfZIMOBFQ8Z7snGfCpS8=; b=gLaxktqjxzmD6q8rJ/JjD/0N3ZuBBnQT/CniopzXh38WGxc4rboM9A+ijcyZFhDb5J NXkg995zBLPGzRNjCtcIUid5MYWsawfocecF7zUIJ/vrtfeOBoF2Gh2MovUcwO361tbq HsLaDQriNxfNn3bI9JYzuJuh4WDaCCJZrpbUWgXw0oumlZjTmHvfsof9tix7o3/ln/oX h8A5LgD27kigu0EE7oJ4JaSID3xrjj2f/fgZj4fz8HTxNYjlkvPRpYw6dBCefWzO/k4v txr+cdgPfUJ1BaIaUhuQfywcB43jGxrdgjqQ6w46+y+BioDUT32a33KcjUSsLVq5TJJG m+aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xJmNi3kQArTjRelcCqSQAaHHfZIMOBFQ8Z7snGfCpS8=; b=Gy2BNmFx5jAMWGxk1FM7B18minE6Pd8nUnzAbmpq8W/mxk3J/ejpZe4rEFRxaP6BNG grWm7/YfFnu1zVRTq4h9TzJFJ5Fe+0Ca5WPT6HfIYbDlknhknbq7Te03D15mTDpXPJgL h84PniVS6a4UxrTixOQPv7T7tqDfqKVSdL+MHTxfbJk4/iLYwYMxM/mtf27nvoIndLh0 NGqrnwqEK7bow1MeW976oPlX5hJFNdN4Tvj61E2WemuZF5/7LTaMjyM/pCNcWYG1c7MK XN4gQcONocaxw4Cv/6I80yYGFyfCLDJrROA8Idhe6Ic9SomJ8KzTFQW0VPlBduMtVHiO WTJw== X-Gm-Message-State: AIkVDXIc9aE9yH5YkpocK5LV7ZdsVsNkUqBfZIhbYLKPeXZ2xmTa6TShDYoyJcVd7vzU5vOisK3yXG53KAcs8w== X-Received: by 10.31.102.134 with SMTP id a128mr18058196vkc.104.1483538217948; Wed, 04 Jan 2017 05:56:57 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:400c:c05::242 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:211102 Archived-At: --94eb2c0946467ddac80545452873 Content-Type: text/plain; charset=UTF-8 With these many changes, I believe it is worth to make another commit with a proper change log as explained here: http://git.savannah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n44 One should be able to understand which files (and functions) are touched by that commit just by reading the commit log. On Tue, Jan 3, 2017 at 10:05 PM Paul Eggert wrote: > Tino Calancha wrote: > > > This is not a standard Emacs commit message: i need to go throughout > > the whole diffs to know exactly what entities have being modified. > > Yes. Please see the section "Commit messages" in the file CONTRIBUTING for > the > commit-message format that is preferred for Emacs changes. > > -- Kaushal Modi --94eb2c0946467ddac80545452873 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
With these many changes, I believe it is worth to make ano= ther commit with a proper change log as explained here:=C2=A0http://git.sav= annah.gnu.org/cgit/emacs.git/tree/CONTRIBUTE#n44

One should be = able to understand which files (and functions) are touched by that commit j= ust by reading the commit log.

On Tue, Jan 3, 2017 at 10:05 PM Paul Eggert <eggert@cs.ucla.edu> wrote:
Tino Calancha wrote:

> This is not a standard Emacs commit message: i need to go throughout > the whole diffs to know exactly what entities have being modified.

Yes. Please see the section "Commit messages" in the file CONTRIB= UTING for the
commit-message format that is preferred for Emacs changes.

--

Kaushal Modi

--94eb2c0946467ddac80545452873--