unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: "Óscar Fuentes" <ofv@wanadoo.es>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: Change in `revert-buffer' behavior [28.0.50]
Date: Tue, 27 Jul 2021 11:43:35 -0400	[thread overview]
Message-ID: <CAFyQvY2Jo-m4rK5B-8CNect6LZGdk982Qie6QT-_etiY_tHmbA@mail.gmail.com> (raw)
In-Reply-To: <87lf5rg4j5.fsf@telefonica.net>

[-- Attachment #1: Type: text/plain, Size: 1053 bytes --]

On Tue, Jul 27, 2021 at 11:29 AM Óscar Fuentes <ofv@wanadoo.es> wrote:

>
> I think that the author was trying to preserve the user's decision about
> the read-only-ness of the buffer, assuming that the file's permissions
> did not change since last visit.
>
> AFAIK currently we have no method for distinguising if the buffer was
> made read-only/writable by the user or because Emacs reflected the file
> system's permissions.
>

I have used `revert-buffer' for more than (gulp) 13 years to always update
the buffer to changes in files on disk. That would revert the buffer
contents to the latest file contents, read/write permissions, etc.

So this change was pretty much a breaking change for me. For context, I use
the p4.el package[0] to check-in and check-out files from within Emacs. But
after that change, M-x p4-edit checked out the file on the system, but
still kept the buffer read-only. So I had to kill and reopen the buffer to
have the read-only status update correctly.

[0]: https://github.com/gareth-rees/p4.el

[-- Attachment #2: Type: text/html, Size: 1467 bytes --]

      reply	other threads:[~2021-07-27 15:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-27 15:09 Change in `revert-buffer' behavior [28.0.50] Kaushal Modi
2021-07-27 15:25 ` bug#35166: " Lars Ingebrigtsen
2021-07-27 15:39   ` Kaushal Modi
2021-07-27 15:28 ` Óscar Fuentes
2021-07-27 15:43   ` Kaushal Modi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFyQvY2Jo-m4rK5B-8CNect6LZGdk982Qie6QT-_etiY_tHmbA@mail.gmail.com \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).