unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Kaushal Modi <kaushal.modi@gmail.com>
To: Mathias Dahl <mathias.dahl@gmail.com>,
	Tino Calancha <tino.calancha@gmail.com>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [PATCH] New command to invert lines in region
Date: Sat, 15 Oct 2016 23:57:43 +0000	[thread overview]
Message-ID: <CAFyQvY2855Uk+ot+EVd4Tm+1uy_uxP94FE=eO_g1+396wfDXkw@mail.gmail.com> (raw)
In-Reply-To: <CABrcCQ4VpjxLO6ZWpkg5ay46tYJ==Y+WP25-Ki9r50Vo6QvJ6w@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 979 bytes --]

On Sat, Oct 15, 2016, 6:25 PM Mathias Dahl <mathias.dahl@gmail.com> wrote:

>
>
> OK, i found it: reverse-region.  Pretty similar.
> It doesn't allow writting to a different buffer than the current one.
> The proposed command here allow that and save some consing.
>
>
> Writing the result into another buffer sounds quite arbitrary.
>

+1. I have never needed to save the result in a different buffer.

Is it really such a common scenario that this function should do it? Those
> who needs to have the result in another buffer can easily add a few lines
> in the calling code to make it so.
>

Exactly.

Out of curiosity I had a look at the current implementation of
> `reverse-region' and found it quite complicated and hard to understand what
> it does.
>

I don't have any for or against opinion on this (may be a slight against,
based on the "if it's not broken, why 'fix'" motto). I have been using
`reverse-region` for many years and it works just fine.
-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2898 bytes --]

  reply	other threads:[~2016-10-15 23:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03 10:43 [PATCH] New command to invert lines in region Tino Calancha
2016-10-03 11:02 ` Kaushal Modi
2016-10-03 11:21   ` Tino Calancha
2016-10-03 11:33     ` Tino Calancha
2016-10-15 22:25       ` Mathias Dahl
2016-10-15 23:57         ` Kaushal Modi [this message]
2016-10-16 11:03           ` Mathias Dahl
2016-10-16 13:24         ` Noam Postavsky
2016-10-16 14:00           ` Eli Zaretskii
2016-10-16 18:25         ` Kalle Olavi Niemitalo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFyQvY2855Uk+ot+EVd4Tm+1uy_uxP94FE=eO_g1+396wfDXkw@mail.gmail.com' \
    --to=kaushal.modi@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=mathias.dahl@gmail.com \
    --cc=tino.calancha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).