From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: Relics of removed dir-locals-file-2 feature in pretest Date: Wed, 22 Nov 2017 15:58:36 +0000 Message-ID: References: <833757cqy7.fsf@gnu.org> <83tvxmbat5.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f403045e5a1e1608e3055e9465e8" X-Trace: blaine.gmane.org 1511366356 8588 195.159.176.226 (22 Nov 2017 15:59:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 22 Nov 2017 15:59:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 22 16:59:07 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eHXQL-0000xn-IR for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2017 16:58:53 +0100 Original-Received: from localhost ([::1]:40170 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHXQS-0002nr-WD for ged-emacs-devel@m.gmane.org; Wed, 22 Nov 2017 10:59:01 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eHXQJ-0002mG-8l for emacs-devel@gnu.org; Wed, 22 Nov 2017 10:58:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eHXQI-0003eY-79 for emacs-devel@gnu.org; Wed, 22 Nov 2017 10:58:51 -0500 Original-Received: from mail-yw0-x232.google.com ([2607:f8b0:4002:c05::232]:33228) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eHXQG-0003dK-Nk; Wed, 22 Nov 2017 10:58:48 -0500 Original-Received: by mail-yw0-x232.google.com with SMTP id z125so5915194ywb.0; Wed, 22 Nov 2017 07:58:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=B+Oe0YtHpqoGD6m1sfjPNDI0raapuPAAfRAebktERuY=; b=ja/6BrgAE2cPM7a5DOMAGmviqmJEzKMUFLHWIpr4TYzlDhhdWgz0kmz759xWcENzOg nfAzHNl4lB8IjTcEl1/5II3O1a7kBzLTsbyCoxbXH4tYAYsnOG2ZCr05Iu+2Hu0xMqHq 81JNgU9VEqJzEVqzGF82J5RcBUk87lz8Nus8pqFzX0gzJdZA3dyhBo92VIgtRwsBl0tZ LPSQncUwuom50WSKE3wyoeDthFWD4whhNYjo3FCofGQ5U4njpHtU0ISwpljhtc2rK8AQ lD77o1ifJ74u5b6QNUKzHZALyk/vfRyxa6pgIDxmRvT4Av+UL9puTHPsR2QgAUpuX2y6 65dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=B+Oe0YtHpqoGD6m1sfjPNDI0raapuPAAfRAebktERuY=; b=SB+nvcjVSRw92i91MBN8gm1yf0W/Q31xytfF9mEEAb2m0wRAY5JfwYchcuNmZcnvJW 5wa1wgxnCsdoyanonslnm0TdIW+TbJqc67CAAAZ35Snk7vR5ESuZlMNBtBdb7EMtOqH7 l9SFTyg8JBS+CGC+SdptWJh1FwY7ZC++6pGu1e1f1XQjglg4xv4krbpE11AgK0dPUcfO 0Q4sbFlsqlfrwi2FvYLLMz+n1JbVSKxOCJ9cCw3tACVMoUsve7NVriIMCeOLq/1hiOIq XCahzUpLf4+eQaWufKnVSXjaWS4vLeGpgj+5G3kHvoxTROScgHp0+sWk8Ltp5Id/Urdu JwTw== X-Gm-Message-State: AJaThX6GBJvlWcOUnCINqs7g3krZj5GSs71bJ2K5CQ1LT9RnC26eGsVM Ypuy3xNsY+kDkF/bPe9qpq2OGDtaAM5O/H8es4c= X-Google-Smtp-Source: AGs4zMajzIO+DiW/ncXwP5QDFom/3Xrf86Lq/qw7kHuuVtMQKfzhZOi1SzOOvcd+KCFU02jJK+lD83khnXj1ax34WlU= X-Received: by 10.129.175.101 with SMTP id x37mr14124977ywj.289.1511366327664; Wed, 22 Nov 2017 07:58:47 -0800 (PST) In-Reply-To: <83tvxmbat5.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4002:c05::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:220358 Archived-At: --f403045e5a1e1608e3055e9465e8 Content-Type: text/plain; charset="UTF-8" On Wed, Nov 22, 2017 at 10:19 AM Eli Zaretskii wrote: > You keep saying that, but I don't understand why: I still see on the > latest emacs-26 the code which you say was removed. What am I > missing? > OK, I grepped for dir-locals-file-2 in the whole emacs repo, and all I get is: etc/NEWS:369:19:See the variable 'dir-locals-file-2' for more information. etc/DOC:46209:11:See also `dir-locals-file-2', whose values override this one's. etc/DOC:46210:64:See Info node `(elisp)Directory Local Variables' for details. Vdir-locals-file-2 lisp/files.el:3908:11:See also `dir-locals-file-2', whose values override this one's. lisp/files.el:3911:11:(defconst dir-locals-file-2 ".dir-locals-2.el" ChangeLog.2:9419:3: (dir-locals-file-2, dir-locals--all-files): Remove. ChangeLog.2:9935:3: (dir-locals-file-2): New const. I see defconst dir-locals-file-2, but I don't see it being used anywhere. So I thought that the feature was removed. But when you said that emacs-26 still has the feature (yay!), I looked at files.el again.. and of course the feature is there: I see this in dir-locals--all-files: (file-2 (when (string-match "\\.el\\'" file-1) (replace-match "-2.el" t nil file-1))) So.. there's an issue, though of a different kind.. may be dir-locals-file-2 mention should be removed? Or instead be used in the code? -- Kaushal Modi --f403045e5a1e1608e3055e9465e8 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Wed, Nov 22= , 2017 at 10:19 AM Eli Zaretskii <eliz@g= nu.org> wrote:
You keep saying that, but I don't understand why: I still see on the latest emacs-26 the code which you say was removed.=C2=A0 What am I
missing?

OK, I grepped for dir-locals-f= ile-2 in the whole emacs repo, and all I get is:

e= tc/NEWS:369:19:See the variable 'dir-locals-file-2' for more inform= ation.
etc/DOC:46209:11:See also `dir-locals-file-2', whose values o= verride this one's.
etc/DOC:46210:64:See Info node `(elisp)Directory= Local Variables' for details. Vdir-locals-file-2
lisp/files.el:3908= :11:See also `dir-locals-file-2', whose values override this one's.=
lisp/files.el:3911:11:(defconst dir-locals-file-2 ".dir-locals-2.e= l"
ChangeLog.2:9419:3:=C2=A0=C2=A0=C2=A0 (dir-locals-file-2, dir-lo= cals--all-files): Remove.
ChangeLog.2:9935:3:=C2=A0=C2=A0=C2=A0 (dir-loc= als-file-2): New const.

I see defconst dir-locals-= file-2, but I don't see it being used anywhere. So I thought that the f= eature was removed.

But when you said that emacs-2= 6 still has the feature (yay!), I looked at files.el again.. and of course = the feature is there:

I see this in dir-locals--al= l-files:

=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0 (file-2 (when (string-match "\\.el\\'" = file-1)
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (replace-match &q= uot;-2.el" t nil file-1)))

So.. there's a= n issue, though of a different kind.. may be dir-locals-file-2 mention shou= ld be removed? Or instead be used in the code?
--

Kaushal Modi

--f403045e5a1e1608e3055e9465e8--