From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like Date: Fri, 06 Oct 2017 17:49:43 +0000 Message-ID: References: <20171004214511.1405.22257@vcs0.savannah.gnu.org> <20171004214513.6A40E2041C@vcs0.savannah.gnu.org> <4fc424a0-fc11-2565-5bdb-c8691bf0323d@cs.ucla.edu> <83h8vexd94.fsf@gnu.org> <83k209whwr.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="94eb2c07e408e67ccb055ae477b4" X-Trace: blaine.gmane.org 1507312233 9102 195.159.176.226 (6 Oct 2017 17:50:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 17:50:33 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org, monnier@iro.umontreal.ca, oleh@oremacs.com To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 06 19:50:29 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0WlX-0001tz-RZ for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 19:50:28 +0200 Original-Received: from localhost ([::1]:46608 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0Wlf-00014i-D1 for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 13:50:35 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0Wl3-00013N-Gf for emacs-devel@gnu.org; Fri, 06 Oct 2017 13:49:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0Wl2-000312-Im for emacs-devel@gnu.org; Fri, 06 Oct 2017 13:49:57 -0400 Original-Received: from mail-qt0-x234.google.com ([2607:f8b0:400d:c0d::234]:48758) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0Wl1-0002xp-0k; Fri, 06 Oct 2017 13:49:55 -0400 Original-Received: by mail-qt0-x234.google.com with SMTP id d13so32177119qta.5; Fri, 06 Oct 2017 10:49:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TZQ4DSMlroo1+6vVAxZ9xh+tUjFBRQYWRj5oQeMw/7M=; b=ORyanvAEjB48DLLS0qOJkwydqCHSMr0pE1K/IuoYGpatVIzXILYVTJkvb/1YcUmMYA kd/rNPL/QRihC3Kzo9iers+tTNTY7ecX7Ssqc0TtrzO0uSPdbCXb1Gm9QRUE1EzS9nAf 8Xrx2wEBEyNSTxFWocCc/XnKB6YSi7wKyEKpp+DZ1BprEdRkdu92R45nw6VfLNwSUH4T 1t1cPjJ0mWvV2qM0Fmy9ViFryQuoZOLdhG1fRzjL7wa+ct900fFimf19NW+pFt9+yMtM cCdRZog0bt/5TMk1YDwJZDM8RCfEn7OaC0+INC39x3pNZNMdhqRGloMl6LPicZbRNpI6 DlCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TZQ4DSMlroo1+6vVAxZ9xh+tUjFBRQYWRj5oQeMw/7M=; b=gRkP+1rvyUlCshqXArJdbPHt3ZmHVN1fPT1ZyfnqHyOy2DwKM2B7OGZDS8pAOaT+R1 LkxYOw9XShSjDMO6XRZo80sjDbALfEDBozu8GTy9HdCcPcs4ReDYiiBvNDxI3gWJiZ1p JbMuhkPmhImxnGSjP65Fd9Iu58l2PyheYGt+BL+gCqIjNGCo6hJ5FVfON8tS085YQxVL 4vwofThIFt4CO0mkzAOmUpVb5hZmya+OrUB+pdYY/w+QzQ9wucViXflgRFjG7Zpzhp4f 4QsCyIVDyHTotMR68RZN+HpLcVtAZ2qxDkyFFbN/avG5oHRkCcbwDfKCCL37kv3eWfup ahKg== X-Gm-Message-State: AMCzsaU8zdtU/yg8FCXUy6m6zegQAlOIt5gCEB3A+19bxo8AZ/W6aO20 8rNUcqZihwKjz4Z5t7nL9+yUNhw1WCVKnZ8fqh0= X-Google-Smtp-Source: AOwi7QBU0l+bh9Tg4E0USUGoXlE0at1f/ViEXYbr+xrvjD4ub5st+co4kOCu4vrAHh3eVEObHE2+MzpZZUmBDcJ7Ad4= X-Received: by 10.37.204.14 with SMTP id l14mr2217802ybf.447.1507312194188; Fri, 06 Oct 2017 10:49:54 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219203 Archived-At: --94eb2c07e408e67ccb055ae477b4 Content-Type: text/plain; charset="UTF-8" On Fri, Oct 6, 2017 at 1:45 PM Paul Eggert wrote: > > Thanks, that did the trick. I reproduced the problem on an RHEL 6.9 > platform. The problem was due to a significant typo in one of my earlier > commits, a typo that was exposed by the commit that you mentioned. To > fix it, I installed the attached patch into emacs-26 and merged emacs-26 > to master. > Awesome! I'll try the latest commit soon. BTW what would be the simplest way to explain why it worked using the Makefile in hydra pkg, but not when installed via pacakge.el? Inspite of same (right?) .elc files? I looked at the commit, but being C-illiterate, made no sense to me. PS: Also shouldn't bug reports be easier to write (and recipes easy to reproduce) if that macro be made part of emacs core? So that people can assimilate info about packages needing to be installed, followed by elisp forms in a concise fashion? Eli? -- Kaushal Modi --94eb2c07e408e67ccb055ae477b4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 6,= 2017 at 1:45 PM Paul Eggert <egge= rt@cs.ucla.edu> wrote:

Thanks, that did the trick. I reproduced the problem on an RHEL 6.9
platform. The problem was due to a significant typo in one of my earlier commits, a typo that was exposed by the commit that you mentioned. To
fix it, I installed the attached patch into emacs-26 and merged emacs-26 to master.

Awesome! I'll try the la= test commit soon.

BTW what would be the simplest w= ay to explain why it worked using the Makefile in hydra pkg, but not when i= nstalled via pacakge.el? Inspite of same (right?) .elc files?=C2=A0

I looked at the commit, but being C-illiterate, made no s= ense to me.

PS:
Also shouldn't bug r= eports be easier to write (and recipes easy to reproduce) if that macro be = made part of emacs core? So that people can assimilate info about packages = needing to be installed, followed by elisp forms in a concise fashion? Eli?=
--

Kaushal Modi

--94eb2c07e408e67ccb055ae477b4--