From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: Broken ediff in master (and the bulk lexical scope patches) Date: Thu, 20 Jun 2019 17:17:14 -0400 Message-ID: References: <7no92sc6yi.fsf@ecube.ecubist.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="000000000000db7163058bc7e0df" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="259508"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Emacs developers To: Barry Fishman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jun 20 23:31:58 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1he4ez-0015JL-6A for ged-emacs-devel@m.gmane.org; Thu, 20 Jun 2019 23:31:57 +0200 Original-Received: from localhost ([::1]:53172 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he4ev-0006ad-NW for ged-emacs-devel@m.gmane.org; Thu, 20 Jun 2019 17:31:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53431) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1he4Rg-0002iZ-QH for emacs-devel@gnu.org; Thu, 20 Jun 2019 17:18:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1he4Re-00063d-Ui for emacs-devel@gnu.org; Thu, 20 Jun 2019 17:18:12 -0400 Original-Received: from mail-lj1-x234.google.com ([2a00:1450:4864:20::234]:33972) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1he4Re-0005xC-KL for emacs-devel@gnu.org; Thu, 20 Jun 2019 17:18:10 -0400 Original-Received: by mail-lj1-x234.google.com with SMTP id p17so4060474ljg.1 for ; Thu, 20 Jun 2019 14:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XTD/xbGU9vN6n7EwyLO6UGcsQIYo0Ujy9HpJE79hJWI=; b=reR3MS1yAQ7ASKWfFrOVh4+k4Z8GndsIPtsc0K0iVZOtHYT9e6d1oefgU+OQ65CUrr T/hbKfLzgUyZHZldR3xm395ZvVmNyD/x0YXlMmBXiQ7MBtTlXg2drcmBxy5X+iYFa4Cs aXuTXq0KqZ79QZ26FLFWkfUYprsS2nj0b0NC6UyM0hMLof5x/QdoGpkrbOIUIFhK2g3Z 9X9629qMAqfxlqiumUm8azfzYR3ZlcGtx1zRP1tNa8k3/crsSQrzyvl6BF77GYKA3mIb YLOsyUPjZvcsaTpRLBkZO14HZnzcxi7YFzySpd9NfKOJiF+hR3Z0GSSxAd5AM4Xx7wUh ojAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XTD/xbGU9vN6n7EwyLO6UGcsQIYo0Ujy9HpJE79hJWI=; b=hAOG11eW613bzx4LFRZeGVt3Q5bJNwjU3S0yYpBKiACSZ0FXqIGkmKfmb8ApsZQz2D iZ/ULwszoLS8+GTmLXtlRxr2hh5GzVNQwyLgHnyvDpcllqpLxWeyfrBIqZzhP5+IC+AW F5E547X3WeQK/f4cb5sKhZ3zpnqvy435CZ1wbel4hl3NM9+VwtuggGhxrSMKS4vhximW YJ8nyAPYHZnebKEpZYG8cdO2RNTjixoiS6HRK7NJWJY0cRnh9qBSyjgyWYFByWYUSlpS rv9ruYOUverxXVfmGd9KUpxe8vwkF68FUhcDoNee+B4wYnjG+9j2vmwoKMvqBj5C8Ol+ EjFw== X-Gm-Message-State: APjAAAWs/jrt3MSeZ3o6P5xkAJmZPxI8LSRs67DgyUgYrXch21QOK06o l836QbfSmggrv4PXYzRQhAPJ2AvCxBnDTmRlvQxans6i X-Google-Smtp-Source: APXvYqzDmu7iHEHsm4jdIA2wlNOeCGkpPI24xFXZ7N04xPbUALqWh4T1nmFHLf4EfCqlOOEPr8QY4Au4afG2R5hqBGc= X-Received: by 2002:a2e:9dca:: with SMTP id x10mr39000994ljj.17.1561065470782; Thu, 20 Jun 2019 14:17:50 -0700 (PDT) In-Reply-To: <7no92sc6yi.fsf@ecube.ecubist.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::234 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:237991 Archived-At: --000000000000db7163058bc7e0df Content-Type: text/plain; charset="UTF-8" That switch of ediff to lexical binding has already been reverted (I think it got reverted a day or two back). -- Kaushal Modi On Thu, Jun 20, 2019 at 4:55 PM Barry Fishman wrote: > After building from Emacs master on June 15, I found that the ediff > function no longer works, responding with: > > ediff-files-internal: Symbol's value as a variable is void: file-A > > This seem to be due to lisp/vm/ediff.el being compiled with lexical > bindings (explicitly). ediff-files-internal calls ediff-find-file with > its file arguments quoted (as it expects). > > How is such code going to be approached? > > -- > Barry Fishman > > > --000000000000db7163058bc7e0df Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
That switch of ediff to lexical binding has already been r= everted (I think it got reverted a day or two back).
=

--
Kaushal Modi

=

= On Thu, Jun 20, 2019 at 4:55 PM Barry Fishman <barry@ecubist.org> wrote:
After building from Emacs master on June 15, I= found that the ediff
function no longer works, responding with:

ediff-files-internal: Symbol's value as a variable is void: file-A

This seem to be due to lisp/vm/ediff.el being compiled with lexical
bindings (explicitly).=C2=A0 ediff-files-internal calls ediff-find-file wit= h
its file arguments quoted (as it expects).

How is such code going to be approached?

--
Barry Fishman


--000000000000db7163058bc7e0df--