From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] add emacsclient support to open with file:linum syntax Date: Wed, 30 Mar 2016 10:21:53 -0400 Message-ID: References: <8360z3q4bt.fsf@gnu.org> <56FAF35F.8030803@cs.ucla.edu> <56FB0AEF.5040502@cs.ucla.edu> <56FB1FAF.3070202@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0160c90869fb1d052f44e0f6 X-Trace: ger.gmane.org 1459347807 31443 80.91.229.3 (30 Mar 2016 14:23:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Mar 2016 14:23:27 +0000 (UTC) Cc: Jorge Alberto Garcia , Eli Zaretskii , John Wiegley , Yuri Khan , Emacs developers To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 30 16:23:26 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1alH1q-0002bf-Hn for ged-emacs-devel@m.gmane.org; Wed, 30 Mar 2016 16:23:26 +0200 Original-Received: from localhost ([::1]:54447 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alH1p-0001mD-Uz for ged-emacs-devel@m.gmane.org; Wed, 30 Mar 2016 10:23:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alH1l-0001kS-EL for emacs-devel@gnu.org; Wed, 30 Mar 2016 10:23:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1alH1k-0002c5-6B for emacs-devel@gnu.org; Wed, 30 Mar 2016 10:23:21 -0400 Original-Received: from mail-ob0-x22a.google.com ([2607:f8b0:4003:c01::22a]:36840) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1alH1j-0002by-W5; Wed, 30 Mar 2016 10:23:20 -0400 Original-Received: by mail-ob0-x22a.google.com with SMTP id m7so65691885obh.3; Wed, 30 Mar 2016 07:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=l0/QVND25P90jeCg3ysp4NM7RlfPfs2kgfydQy9CD8c=; b=rZjMu+ySx77q1vKzO07JL4NhLxs9pCVEvIBiNpXeBfSSr5LGp6f0sAmnPImOsMN1a4 /PS3u06zs3nfIkLSJugsd/RidiTzExMzciw8pj3UxEFYU+oJ8JnQT1jQCuV6MJyehk8C 9seySy9bezgxVvYmwqj+7VdEdfrIZFxdG4+i7zlGPLEDWjEgoFijrEiTiwsxJhCfVVjw llP8AeFfDKwYDW0rxUax/CQrs23YK38YemOhXURk6sVOMutCiah92VyY9zGEpvEiAKzf QuQQ7oqp5i336Dk91sQM4a9aymBrf2hY4Xcj5tG5k7NyzXohw6vvj+A71sy0bCsN52gd MZxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=l0/QVND25P90jeCg3ysp4NM7RlfPfs2kgfydQy9CD8c=; b=G7TLWTgGiC43yUBMwlmn6u/xPkYQZW0UbliQTsOWxyHQjQCY6p0kGaCIcHOkH+fvcZ WJGOmYTprwi69kxoQrHN94oQoOaz8v0KvCekI4wORyTNAywVpSbo9+eV5v1LaAqSVMY/ 6IoU9k+6C+/a5EysEbJhT9lKCntFdoYoU7Nyn0q9z93/3jZ92wgSmZaJxYsWfwhNppSv O5DpmzSjMADuBCtrywDeDJJp6l0s1N090Z2Hr7QY8pjQU/k6bdtzj9q5i5yyeRYbuMYF 73gEP2nKyZVv5Bwgyw0KXaIjkbj6cjdbSvPJt1YW+p52AYM+JBFnB9qCfG3JFjGH6bj8 GNxQ== X-Gm-Message-State: AD7BkJK7rXRz1GzLVO80vazQ2JKIvQvEa4CZviDSOTAMxtFZSojTWNu5ieVNICv/FvbHFL4W+AcQtew9PfN7XA== X-Received: by 10.182.104.138 with SMTP id ge10mr4948428obb.81.1459347752874; Wed, 30 Mar 2016 07:22:32 -0700 (PDT) Original-Received: by 10.202.204.2 with HTTP; Wed, 30 Mar 2016 07:21:53 -0700 (PDT) In-Reply-To: <56FB1FAF.3070202@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2607:f8b0:4003:c01::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202454 Archived-At: --089e0160c90869fb1d052f44e0f6 Content-Type: text/plain; charset=UTF-8 > > On 03/29/2016 03:35 PM, Kaushal Modi wrote: > I myself, use an awk script to rearrange the arguments to work with the > current +LINE FILE format accepted by emacsclient ( Ref: > https://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00541.html ). > So the existing emacsclient implementation already works for you. > > They are not workarounds, because grep output cannot be used unchanged. > Even with the proposed option syntax, users would need to employ a script > such as yours to pick out the part of the grep output that they need, and > use that information to formulate arguments for emacsclient. > The longstanding +LINE option syntax is compatible with other popular free > editors such as 'vim' and 'nano', and there is some value in encouraging > its usage rather than reinventing the wheel. > Having this patch installed will prevent the need for such workarounds > Jorge, Based on the counter arguments provided by Paul, I now tend to agree to what he says. 1. The current method (+LINE FILE and using awk to arrange stuff) has been working well for me for quite few years. 2. It makes sense to have users stick to one convention (+LINE FILE) instead of having users now split between "+LINE FILE" and "FILE:LINE". I do not use copy/paste manually but instead make a shell alias using that awk snippet do things. So with either "+LINE FILE" or "FILE:LINE", I will need that awk script. That said, I appreciate the effort you put in in creating this patch and this reply, by no means, is intended to discourage you from your future work (especially in C). --089e0160c90869fb1d052f44e0f6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
On 03/29= /2016 03:35 PM, Kaushal Modi wrote:
I myself, use an awk script t= o rearrange the arguments to work with the current +LINE FILE format accept= ed by emacsclient ( Ref:=C2=A0ht= tps://lists.gnu.org/archive/html/emacs-devel/2016-01/msg00541.html=C2= =A0).
So the existing emacsclient implementation already works for you.

They are not workarounds,= because grep output cannot be used unchanged. Even with the proposed optio= n syntax, users would need to employ a script such as yours to pick out the= part of the grep output that they need, and use that information to formul= ate arguments for emacsclient.
The longstanding +LINE option syntax is compatibl= e with other popular free editors such as 'vim' and 'nano',= and there is some value in encouraging its usage rather than reinventing t= he wheel.

Having this patch installed will prevent the = need for such workarounds


Jorge,

Based on the counter ar= guments provided by Paul, I now tend to agree to what he says.
=

1. The curren= t method (+LINE FILE and using awk to arrange stuff) has been working well = for me for quite few years.
2. It makes sense to have users stick to one conve= ntion (+LINE FILE) instead of having users now split between "+LINE FI= LE" and "FILE:LINE".
=
I do not use copy/paste manually but ins= tead make a shell alias using that awk snippet do things. So with either=C2= =A0"+LINE FILE" or "= FILE:LINE", I will need that awk script.

That said, I appreciate the eff= ort you put in in creating this patch and this reply, by no means, is inten= ded to discourage you from your future work (especially in C).
--089e0160c90869fb1d052f44e0f6--