pdf-view removed from mailcap.el

pdf-view removed from mailcap.el

[N. Raghavendra]

It looks like commit c3445aed5194 removed the element

("pdf"
  (viewer . pdf-view-mode)
  (type . "application/pdf")
  (test . (eq window-system 'x)))

from `mailcap-mime-data', with the commit message

* lisp/net/mailcap.el ... (mailcap-mime-data): Remove some entries for
ancient functions.

Support for pdf-view was added fairly recently, in commit 931e7babcb81
on 2015-02-23, and pdf-tools is an active project, so removing it along
with other old functions was perhaps an oversight.  I certainly use it,
and I've seen queries on the Web about using pdf-view in Gnus, so there
are others who seem to be using it too.  So I suggest adding it back to
`mailcap-mime-data'.  Meanwhile, I've added it to
`mailcap-user-mime-data' in my init file as a temporary fix.

Cheers,
Raghu.

--
N. Raghavendra <raghu@hri.res.in>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/

Re: pdf-view removed from mailcap.el

[Mark Oteiza]

"N. Raghavendra" <nyraghu27132@gmail.com> writes:

> It looks like commit c3445aed5194 removed the element
>
> ("pdf"
>   (viewer . pdf-view-mode)
>   (type . "application/pdf")
>   (test . (eq window-system 'x)))

My fault--restored in 34a6774daa.  Thanks for reporting.

Re: pdf-view removed from mailcap.el

[N. Raghavendra]

At 2017-09-17T08:30:30-04:00, Mark Oteiza wrote:

> "N. Raghavendra" <nyraghu27132@gmail.com> writes:
>
>> It looks like commit c3445aed5194 removed the element
>>
>> ("pdf"
>>   (viewer . pdf-view-mode)
>>   (type . "application/pdf")
>>   (test . (eq window-system 'x)))
>
> My fault--restored in 34a6774daa.  Thanks for reporting.

Thanks for the quick action.  The restoration is only in the emacs-26
branch.  Will the new change be incorporated into the master branch
later?  I ask this because I usually build Emacs from the master branch.

Raghu.

--
N. Raghavendra <raghu@hri.res.in>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/

Re: pdf-view removed from mailcap.el

[Óscar Fuentes]

"N. Raghavendra" <nyraghu27132@gmail.com> writes:

> Thanks for the quick action.  The restoration is only in the emacs-26
> branch.  Will the new change be incorporated into the master branch
> later?  I ask this because I usually build Emacs from the master branch.

Yes. Changes made in the release branch are merged into the master
branch from time to time.

Re: pdf-view removed from mailcap.el

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 622 bytes --]

On Sun, Sep 17, 2017, 9:38 AM N. Raghavendra <nyraghu27132@gmail.com> wrote:

>
> Thanks for the quick action.  The restoration is only in the emacs-26
> branch.  Will the new change be incorporated into the master branch
> later?  I ask this because I usually build Emacs from the master branch.
>

I often wonder that. Shouldn't each commit made to the stable branches be
merged to master at the same time?

I like that kind of flow in the Org repo. Notice how each time commits made
to maint (Org stable) branch are followed by merge commits to master: http
://orgmode.org/cgit.cgi/org-mode.git/log/

-- 

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 1271 bytes --]

Re: pdf-view removed from mailcap.el

[N. Raghavendra]

At 2017-09-17T15:49:30+02:00, Óscar Fuentes wrote:

> Yes. Changes made in the release branch are merged into the master
> branch from time to time.

Thanks for the information.  Just curious, how often are these merges
done?

Raghu.

-- 
N. Raghavendra <raghu@hri.res.in>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/

Re: pdf-view removed from mailcap.el

[Eli Zaretskii]

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Sun, 17 Sep 2017 13:52:47 +0000
> 
> Shouldn't each commit made to the stable branches be merged to master at the same
> time?

It would be nice, but it is not required.  Merging from the release
branch to master usually requires some manual work, and is sometimes
not for the faint at heart.

> I like that kind of flow in the Org repo. Notice how each time commits made to maint (Org stable) branch are
> followed by merge commits to master: http://orgmode.org/cgit.cgi/org-mode.git/log/

An example to follow, I'm sure.  Maybe we could have someone volunteer
to be our "merge champion"?

Re: pdf-view removed from mailcap.el

[Eli Zaretskii]

> From: "N. Raghavendra" <nyraghu27132@gmail.com>
> Date: Sun, 17 Sep 2017 19:43:16 +0530
> 
> Just curious, how often are these merges done?

"From time to time" is the best answer we can give, sorry.

Re: pdf-view removed from mailcap.el

[N. Raghavendra]

At 2017-09-17T17:39:29+03:00, Eli Zaretskii wrote:

>> Just curious, how often are these merges done?
>
> "From time to time" is the best answer we can give, sorry.

Sure, thanks.

Cheers,
Raghu.

-- 
N. Raghavendra <raghu@hri.res.in>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/

Re: pdf-view removed from mailcap.el

[Kaushal Modi]

[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]

On Sun, Sep 17, 2017, 10:37 AM Eli Zaretskii <eliz@gnu.org> wrote:

> > From: Kaushal Modi <kaushal.modi@gmail.com>
> > Date: Sun, 17 Sep 2017 13:52:47 +0000
> >
> > Shouldn't each commit made to the stable branches be merged to master at
> the same
> > time?
>
> It would be nice, but it is not required.


It would be great if it is encouraged then.

 Merging

from the release
> branch to master usually requires some manual work, and is sometimes
> not for the faint at heart.
>

If each committer makes sure to merge their commit, others don't have to
review if they are merging others' commits correctly. I can talk of my
experience in Org repo.. after my commits to the maint branch, all I need
to do is check out master and do a merge.. as simple as this in Magit: "b
b" (checkout master) "m m" (merge maint).

> I like that kind of flow in the Org repo. Notice how each time commits
> made to maint (Org stable) branch are
> > followed by merge commits to master:
> http://orgmode.org/cgit.cgi/org-mode.git/log/
>
> An example to follow, I'm sure.  Maybe we could have someone volunteer
> to be our "merge champion"?
>

One doesn't need to be a "champion" as they are just making sure that their
commit is landing in master too.

Would you consider documenting and at least recommending this flow?

Thanks.

> --

Kaushal Modi

[-- Attachment #2: Type: text/html, Size: 2702 bytes --]

Re: pdf-view removed from mailcap.el

[Eli Zaretskii]

> From: Kaushal Modi <kaushal.modi@gmail.com>
> Date: Sun, 17 Sep 2017 14:59:16 +0000
> Cc: emacs-devel@gnu.org, johnw@gnu.org, nyraghu27132@gmail.com
> 
> It would be great if it is encouraged then. 

I think it already is, as we surely don't discourage that.

> If each committer makes sure to merge their commit, others don't have to review if they are merging others'
> commits correctly. I can talk of my experience in Org repo.. after my commits to the maint branch, all I need to
> do is check out master and do a merge.. as simple as this in Magit: "b b" (checkout master) "m m" (merge
> maint). 

It's not that easy in Emacs, see gitmerge.el and the references to it
in CONTRIBUTE.

> One doesn't need to be a "champion" as they are just making sure that their commit is landing in master too.

It's more complicated than that, unfortunately.  Even experienced
people made mistakes with that, so I guess it's not as easy as in
other projects.  Specific suggestions for how to make the process
better will be welcome, I'm sure, but please study the existing
documentation and code first.

> Would you consider documenting and at least recommending this flow?

What we thought needed to be documented is in CONTRIBUTE already.

Re: pdf-view removed from mailcap.el

[Eli Zaretskii]

> From: "N. Raghavendra" <nyraghu27132@gmail.com>
> Date: Sun, 17 Sep 2017 20:11:55 +0530
> 
> At 2017-09-17T17:39:29+03:00, Eli Zaretskii wrote:
> 
> >> Just curious, how often are these merges done?
> >
> > "From time to time" is the best answer we can give, sorry.
> 
> Sure, thanks.

Btw, during the time a new release is being prepared from a release
branch, people who track Emacs development are encouraged to track the
release branch, not master.  This gives the new release more testing
and reveals any problems sooner, thus helping us release Emacs 26.1
sooner rather than later.

TIA

Re: pdf-view removed from mailcap.el

[N. Raghavendra]

At 2017-09-17T19:55:11+03:00, Eli Zaretskii wrote:

> Btw, during the time a new release is being prepared from a release
> branch, people who track Emacs development are encouraged to track the
> release branch, not master.  This gives the new release more testing
> and reveals any problems sooner, thus helping us release Emacs 26.1
> sooner rather than later.
>
> TIA

I don't think I use any special features of the master branch, and am
shifting to the emacs-26 branch.

Cheers,
Raghu.

--
N. Raghavendra <raghu@hri.res.in>, http://www.retrotexts.net/
Harish-Chandra Research Institute, http://www.hri.res.in/

Re: pdf-view removed from mailcap.el

[Eli Zaretskii]

> From: "N. Raghavendra" <nyraghu27132@gmail.com>
> Date: Sun, 17 Sep 2017 23:57:03 +0530
> 
> I don't think I use any special features of the master branch, and am
> shifting to the emacs-26 branch.

Thank you.  (For now, the two branches are very similar anyway.)