From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like Date: Fri, 06 Oct 2017 18:15:18 +0000 Message-ID: References: <20171004214511.1405.22257@vcs0.savannah.gnu.org> <20171004214513.6A40E2041C@vcs0.savannah.gnu.org> <4fc424a0-fc11-2565-5bdb-c8691bf0323d@cs.ucla.edu> <83h8vexd94.fsf@gnu.org> <83k209whwr.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="089e082bb274663cfd055ae4d301" X-Trace: blaine.gmane.org 1507313774 11859 195.159.176.226 (6 Oct 2017 18:16:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 18:16:14 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org, monnier@iro.umontreal.ca, oleh@oremacs.com To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 06 20:16:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0XAJ-0001eI-TE for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 20:16:04 +0200 Original-Received: from localhost ([::1]:46679 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0XAP-0008LX-IN for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 14:16:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0X9p-0008LF-RM for emacs-devel@gnu.org; Fri, 06 Oct 2017 14:15:34 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0X9o-000093-CT for emacs-devel@gnu.org; Fri, 06 Oct 2017 14:15:33 -0400 Original-Received: from mail-qt0-x22d.google.com ([2607:f8b0:400d:c0d::22d]:46656) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e0X9m-00005O-1x; Fri, 06 Oct 2017 14:15:30 -0400 Original-Received: by mail-qt0-x22d.google.com with SMTP id 6so23891821qtw.3; Fri, 06 Oct 2017 11:15:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DtZHG+9x7F5vEylgvi6anSDH3WzHOTA+j5QjcCoWIGg=; b=mfrNbwSGWGqKwBxPcz42fzJguemdu0mfrqtELnnfEpNtpYc8qu6v5djZ4tOD3K6nT6 E1lbrfCqRUzB55s9nvPAx3mPLy6Ao56cBVTY1fOyb2iD1fFQwn7pZf04YuiDW/kkLNzn bNazNXB/sHxN0ZuRtElr4hrwnCt6AQv//6E02GYuruAB50djTKUvc39obYqwZJa63sSm jmgDDKGdnTdo/PMnQ183t60Nk+c6qGmZMpKqmcTKcbrZ8UyqRz+wRVA3pWBdHS6LOV6K X4ModOLVsOahxBFSL86gVi46fdkUjwPlv4Rc3W1qAjNEkAZKoEbFwpY3D2aHuogtIYQ6 Be2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DtZHG+9x7F5vEylgvi6anSDH3WzHOTA+j5QjcCoWIGg=; b=Cxf/sKlaTDdr6LoS2K6uCBAPu8h7Ect2ZXl4GWGYMEoVY8CqkiPZmAr/U4I03feLqB 0mNqRiapiBo5KPMe/PYCTJdApDtVJ8H4BP4MZEa9lXAhC9tTdOegciMU6IV0Eam5HIbI MhIC5TgQ4E/0qH7dpGPPMe4s7CaM/jPu3iqIT2kqQcaXPzD+5YGUQfUbO29O/XATw5eL LlY/gLSVOaH8Lj5s1bH/j0KjjBRlElTlWt14kBO7+h3kpsvzlQSNqsqxFtGFHtzgQ7sN +0XjLjeWE9NIivS1UGFp3G7jRXNQoWuSrg/0Vg5WNZjEPTnXt9MwKSQaSYMfMF7T1CDS Ys3w== X-Gm-Message-State: AMCzsaXfWpla2+eQxRcQUMceqhYleQZD3Q0WJC4DAORMSpiGJ5OAnfQK NZbQW56Sr8EvFf3FrTMk6NB8tIgbBOYiwK5sf88= X-Google-Smtp-Source: AOwi7QD/xfIoJ+HMTbOby0c28osQCLRqO9QfoBqx598zPsQthPQ5PPMIOQxUZ+tnjmEFnVqmz9PuNWrSpVSqxYTVzT0= X-Received: by 10.37.133.3 with SMTP id w3mr2274381ybk.264.1507313729287; Fri, 06 Oct 2017 11:15:29 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c0d::22d X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219205 Archived-At: --089e082bb274663cfd055ae4d301 Content-Type: text/plain; charset="UTF-8" On Fri, Oct 6, 2017 at 2:06 PM Paul Eggert wrote: > The .elc files were not the same. However, I think that was a blind > alley, as .elc differences can be benign. The diagnostic was output only > when (format FOO) was called with a long FOO (greater than 235 chars, > roughly) without any % directives in it, and where the (format FOO) call > was either directly from bytecode or indirectly via channels that never > used unbind_to. The Makefile approach didn't byte-compile one of the > files that the package.el approach compiled, and I suspect that the > different path to (lv-message "long format with no % directives") > explained why I didn't reproduce the bug at first. > Thanks. That explains why the hydra needed to have that many elements.. to create the long lv-message. But does it also explain this observation from my earlier email: > I do not get this error if I remove the head with "" binding: ("" (message "Pressed super space") "Super Space") BTW I confirm the fix. Thanks! -- Kaushal Modi --089e082bb274663cfd055ae4d301 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Fri, Oct 6,= 2017 at 2:06 PM Paul Eggert <egge= rt@cs.ucla.edu> wrote:
The .= elc files were not the same. However, I think that was a blind
alley, as .elc differences can be benign. The diagnostic was output only when (format FOO) was called with a long FOO (greater than 235 chars,
roughly) without any % directives in it, and where the (format FOO) call was either directly from bytecode or indirectly via channels that never
used unbind_to. The Makefile approach didn't byte-compile one of the files that the package.el approach compiled, and I suspect that the
different path to (lv-message "long format with no % directives")=
explained why I didn't reproduce the bug at first.

Thanks. That explains why the hydra needed to have that man= y elements.. to create the long lv-message. But does it also explain this o= bservation from my earlier email:

> I do not get this error if I remove= the head with "<s-SPC>" binding:=C2=A0=C2=A0 ("<s-= SPC>" (message "Pressed super space") "Super Space&q= uot;)=C2=A0=C2=A0

BTW I confirm the fix= . Thanks!
--

Kaushal Modi=

--089e082bb274663cfd055ae4d301--