From: Kaushal Modi <kaushal.modi@gmail.com>
To: Artur Malabarba <bruce.connor.am@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: [ELPA] New package: beacon
Date: Thu, 15 Oct 2015 17:44:07 -0400 [thread overview]
Message-ID: <CAFyQvY0Tnv5ar7hJm2vOPNj+By6PaxSNiAeKXmn+Ecot=xe+XQ@mail.gmail.com> (raw)
In-Reply-To: <CAFyQvY20fO9+sE0DEcpLXSYfxc8O_7bPNZ1ER6_Cj3qmPGJmmg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1870 bytes --]
OK, I think I need to reenable fci-mode at the end of beacon--dec. It seems
to sort of work, just that the fci-mode gets re-enabled too soon, slightly
before the beacon trails finish vanishing.
--
Kaushal Modi
On Thu, Oct 15, 2015 at 5:37 PM, Kaushal Modi <kaushal.modi@gmail.com>
wrote:
> This gif shows the problem with fci-mode enabled:
> http://i.imgur.com/G2ojtKc.gifv
>
> That vertical line on the right is what the Fill Column Indicator package
> is inserting. With that persistently enabled, you can see that it messes up
> the beacon.. the cursor keeps on jumping to the set column.
>
> I tried this to disable fci at the right time:
>
> (defun beacon--shine ()
> "Shine a beacon at point."
> (setq-local sanityinc/fci-mode-suppressed fci-mode)
> (when fci-mode
> (turn-off-fci-mode))
> (let ((colors (beacon--color-range)))
> (save-excursion
> (while colors
> (if (looking-at "$")
> (progn
> (beacon--after-string-overlay colors)
> (setq colors nil))
> (beacon--colored-overlay (pop colors))
> (forward-char 1))))))
>
>
> But I cannot figure out where to reenable it.. it didn't work if I tried
> to renable at the end of beacon--shine or beacon-blink.
>
>
> --
> Kaushal Modi
>
> On Thu, Oct 15, 2015 at 5:27 PM, Artur Malabarba <
> bruce.connor.am@gmail.com> wrote:
>
>>
>> 2015-10-15 18:33 GMT+01:00 Kaushal Modi <kaushal.modi@gmail.com>:
>>
>>> BTW, I just tried it out and it looks great! I like that meteor trail
>>> effect :)
>>>
>>> I now just need to figure out how to make it play nice with fci-mode.
>>>
>>> If a beacon pre/post hook is available, I can disable/enable fci-mode in
>>> there.
>>>
>>
>> Before I push this tomorrow there'll be a way to conditionally avoid
>> blinking. Would that help? What's fci-mode like and why does it conflict?
>>
>
>
[-- Attachment #2: Type: text/html, Size: 4902 bytes --]
next prev parent reply other threads:[~2015-10-15 21:44 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 17:02 [ELPA] New package: beacon Artur Malabarba
2015-10-15 17:24 ` Kaushal Modi
2015-10-15 17:26 ` Kaushal Modi
2015-10-15 17:33 ` Kaushal Modi
2015-10-15 21:27 ` Artur Malabarba
2015-10-15 21:37 ` Kaushal Modi
2015-10-15 21:44 ` Kaushal Modi [this message]
2015-10-15 22:13 ` Artur Malabarba
2015-10-15 22:27 ` Kaushal Modi
2015-10-15 22:40 ` Kaushal Modi
2015-10-16 8:06 ` Tassilo Horn
2015-10-15 22:47 ` Artur Malabarba
2015-10-15 21:21 ` Artur Malabarba
2015-10-16 13:11 ` Phillip Lord
2015-10-16 13:54 ` Artur Malabarba
2015-10-15 21:42 ` Rasmus
2015-10-15 17:36 ` Marcin Borkowski
2015-10-15 17:55 ` Kaushal Modi
2015-10-15 18:17 ` Artur Malabarba
2015-10-15 18:31 ` Howard Melman
2015-10-15 21:36 ` Artur Malabarba
2015-10-21 17:10 ` [ELPA] New package: on-screen (was: [ELPA] New package: beacon) Michael Heerdegen
2015-10-21 18:20 ` [ELPA] New package: on-screen John Wiegley
2015-10-21 18:54 ` John Wiegley
2015-10-21 19:04 ` Michael Heerdegen
2015-10-21 19:28 ` John Wiegley
2015-10-22 7:26 ` David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFyQvY0Tnv5ar7hJm2vOPNj+By6PaxSNiAeKXmn+Ecot=xe+XQ@mail.gmail.com' \
--to=kaushal.modi@gmail.com \
--cc=bruce.connor.am@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).