From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Kaushal Modi Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 ee512e9: Ignore buffers whose name begins with a space in save-some-buffers Date: Tue, 19 Sep 2017 15:50:32 +0000 Message-ID: References: <20170918202953.21378.63492@vcs0.savannah.gnu.org> <20170918202955.5043420AC4@vcs0.savannah.gnu.org> <87ingfcrf6.fsf@ericabrahamsen.net> <87377id77h.fsf@ericabrahamsen.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="f403045eaeaa5ba0ba05598cd2a0" X-Trace: blaine.gmane.org 1505836440 30886 195.159.176.226 (19 Sep 2017 15:54:00 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Sep 2017 15:54:00 +0000 (UTC) To: Eric Abrahamsen , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 19 17:53:56 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duKqR-0007qt-Ca for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 17:53:55 +0200 Original-Received: from localhost ([::1]:43711 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duKqY-0000Jt-RN for ged-emacs-devel@m.gmane.org; Tue, 19 Sep 2017 11:54:02 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duKnR-0006ud-Kq for emacs-devel@gnu.org; Tue, 19 Sep 2017 11:50:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duKnM-00058z-7S for emacs-devel@gnu.org; Tue, 19 Sep 2017 11:50:49 -0400 Original-Received: from mail-yw0-x231.google.com ([2607:f8b0:4002:c05::231]:43999) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1duKnL-00058b-V9 for emacs-devel@gnu.org; Tue, 19 Sep 2017 11:50:44 -0400 Original-Received: by mail-yw0-x231.google.com with SMTP id s62so45040ywg.0 for ; Tue, 19 Sep 2017 08:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=vLEoz+twJJmRwUHNgT/lRsM2nWJs9oDjAfRq8kGjy0c=; b=CxN61G5qC9HkW5U65bH/eNM3X1gBYc3uHGe3mrnEpk/8VmO//dI3DMXxO5fxuVqnvS oPyGejrNyXZJ6f0rgkLqYskQ1RVt2BobVfOxQTjn0xu34E2YAO4XEC81V5JEZ1EWc9Pd k4ZnSxYEOjygNIA3MwrGNaGChvUvazS92hrDD1SOWHi7pgp/O+0reVESIPe5LIhUAKzg gRH1mT/jfaYJGxYq7RDi2CYFFAAUHrNSWmxrsa9ZKAc/GTamvmVOFlbAdVPksbTxGqV8 jzUZG5I46hpUKZMHLdFVETyMGeu3KIvXLxTHUw/z50uAsUpP0rCgj0Z+1yTqLvPLZ3o4 4mdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=vLEoz+twJJmRwUHNgT/lRsM2nWJs9oDjAfRq8kGjy0c=; b=NvqX43CCL7mNCEW/gZKN2borjYqP5eAJpAFeVDrIOu9XJNTXJH2MHxioXpVf+rx5jC g92uU8cMPZdB/ufa6RY1sG3R1E+5jnyDIfXLim+/e4e/HuTyfJ/jQcJ3r1ditTCbT4ew uhYHVwRTkAvnBwrRbfZjwXbXMPDntXF+81JsZQ6iNVWZT+3dOFF9Z83pqf977Gofu2cd 1RmQQB1t7WfIMPXqBG1XD18KvBe1CU4NGNvrmGFPqkfIjGWxzM+y3YwzRXyu/i4OGCay V8wtSXUmQyk0H8Xk05m+Al4m6mvfzWA7A87JEdu9HZUnpkFGsi1aYAJySAU1Xeqa6lGJ SlkQ== X-Gm-Message-State: AHPjjUjW8BnKdrWhWX5xiuY7lF+r9+44ty03dNgwhMMcWSQsc8jAIAHY klCmlc2jOz+qZJlZ4mIE4/NSE1jqEI2hAczzKBo= X-Google-Smtp-Source: AOwi7QANKnUPL7pmD9/l24xH2YuwLBoaM56icKWcvsIH1h58sJfNDQ4o136LgJe9cTWg5tevpPIHTSFx2ZPnHiNsthU= X-Received: by 10.129.181.71 with SMTP id c7mr1406136ywk.113.1505836243064; Tue, 19 Sep 2017 08:50:43 -0700 (PDT) In-Reply-To: <87377id77h.fsf@ericabrahamsen.net> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4002:c05::231 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:218518 Archived-At: --f403045eaeaa5ba0ba05598cd2a0 Content-Type: text/plain; charset="UTF-8" On Tue, Sep 19, 2017 at 11:44 AM Eric Abrahamsen wrote: > > I do think ggtags is doing something weird here. But on the other hand, > it does seem better if `save-some-buffers' required `buffer-offer-save' > to be explicitly set non-nil, rather than drawing an implicit conclusion > from the presence of `write-contents-functions'. > > Ie maybe I should just revert the change to this function, and make sure > to set `buffer-offer-save' to t in my use-case. No one will get > surprised by save prompts they didn't ask for. That way I could also > remove the buffer name check. > > WDYT? > That's my proposal, of course if that resolves the issue you needed to make that change in the first place! Thanks for considering this. -- Kaushal Modi --f403045eaeaa5ba0ba05598cd2a0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, Sep 19= , 2017 at 11:44 AM Eric Abrahamsen <eric@ericabrahamsen.net> wrote:

I do think ggtags is doing something weird here. But on the other hand,
it does seem better if `save-some-buffers' required `buffer-offer-save&= #39;
to be explicitly set non-nil, rather than drawing an implicit conclusion from the presence of `write-contents-functions'.

Ie maybe I should just revert the change to this function, and make sure to set `buffer-offer-save' to t in my use-case. No one will get
surprised by save prompts they didn't ask for. That way I could also remove the buffer name check.

WDYT?

That's my proposal, of course= if that resolves the issue you needed to make that change in the first pla= ce! Thanks for considering this.=C2=A0
--=

Kaushal Modi

--f403045eaeaa5ba0ba05598cd2a0--