From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thibaut Verron Newsgroups: gmane.emacs.devel Subject: Re: PROPOSAL: Repurpose one key and reserve it for third-party packages Date: Wed, 10 Feb 2021 12:35:06 +0100 Message-ID: References: <7ef75c33936136eb3a20@heytings.org> <87czxazbhr.fsf@melete.silentflame.com> <871rdqfaix.fsf@ericabrahamsen.net> <87mtwd42ck.fsf@melete.silentflame.com> Reply-To: thibaut.verron@gmail.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23279"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eric@ericabrahamsen.net, spwhitton@spwhitton.name, rms@gnu.org, emacs-devel@gnu.org To: "Alfred M. Szmidt" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Feb 10 12:36:59 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l9nnm-0005wW-KK for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Feb 2021 12:36:58 +0100 Original-Received: from localhost ([::1]:40964 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9nnl-0005lM-L1 for ged-emacs-devel@m.gmane-mx.org; Wed, 10 Feb 2021 06:36:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57864) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9nm3-0004nc-20 for emacs-devel@gnu.org; Wed, 10 Feb 2021 06:35:11 -0500 Original-Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]:36336) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l9nm1-0004pT-BK; Wed, 10 Feb 2021 06:35:10 -0500 Original-Received: by mail-yb1-xb30.google.com with SMTP id v5so1672164ybi.3; Wed, 10 Feb 2021 03:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=HgkLuRyJ06JYrxKYv410Txsd11macs9csCV0wdMSVR8=; b=HTEIwAsM9Mt27/fsjFc3/IX4P8RGuaEYOLMK8o1wY0GRO50KqJ/WpZyfHb6t8+udL6 FMtaypakTh91++RSuu/+y3WgBb45Qc1drWTgxyxQYAJ9kBi0pd63W/Lgtiwn32l0wZic 3AhcIivmJiX9C62KVH5NerflJ2Ywevnvp8RbI8yNvy+Gcjh0bJPU/pxa5Ni9SW3LXkYA Qa73HVFeJNwefzKe2nquN/0ePwCrCrQpIOy8wde+O5P4pKxngPHJgkH8QJtlQQC5Srya J3L4vE6+qZ8LCtDjABvrg+NfZPZ0c/gSKlqrIAiV0Y6UomFNfjGCgCeiE2Uf5kS4lsLZ TcQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=HgkLuRyJ06JYrxKYv410Txsd11macs9csCV0wdMSVR8=; b=dsSSRPs2hYDqo8rsBgsWZDU8Obi+IBtImnipiyxfAWqXk7DbbO3fcaSzmrJGRoNKv6 yZM2UTuxtwPhUElJR70Z69eqI9RKl29+ZHBc7uiOCGD9lgUnU9Xxmd7Rdkn76JOGehMy rKBlNXJToGgufKv4bLuPv9b9bySgUv2F0gr5IElX2kk5aHJW3cIXwVpx60Qzj6pB6EUo cTu7zwEn5jvJTz8yuRyEARkZ6zJtWLfYDj3xGTP63lkHYPUIFplPA0tmCOP4MqcsxxPH /3KnM+9LKNl8rOOiIOowHX/c42KbWAdiGCTvXfie9XBpqQ1TNyhkMyZZI/7lqGmcVTN2 M2UA== X-Gm-Message-State: AOAM532jmZ/lB1mgDb0siBFYDPEowjsbqb0vL4TBmiS0LO1i4QCsMn31 TqMNvOBjOHHmedOiykVA6FuYBFSvUGaYiPIMJgmp1+YQ421u5Q== X-Google-Smtp-Source: ABdhPJyjOdv0GgnfbqskgGMNX4SfaXD5jXu7WVdZMemgana14r48hNkjHYgjfsTNvY1nIszG0sy8J2GbTT38Y3IPSmQ= X-Received: by 2002:a25:d296:: with SMTP id j144mr3569135ybg.33.1612956907314; Wed, 10 Feb 2021 03:35:07 -0800 (PST) Original-Received: by 2002:a05:7110:6187:b029:31:9798:b166 with HTTP; Wed, 10 Feb 2021 03:35:06 -0800 (PST) In-Reply-To: Received-SPF: pass client-ip=2607:f8b0:4864:20::b30; envelope-from=thibaut.verron@gmail.com; helo=mail-yb1-xb30.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:264270 Archived-At: 2021-02-10 11:42 UTC+01:00, Alfred M. Szmidt : > Since Magit is a VC like mode, wouldn't it make more sense to put it > under C-x v? E.g., why cannot Magit rebind C-x v l -- which I guess > is similar to magit-status or possibly C-x v d. > > From a users perspective, making it seemingly a part of VC-mode makes > more sense than trying to make it a special citizen that needs to take > C-x g (or whatever) since it would make it hard to use MaGit, > MaFossil, MaSubersion (last two are fictious) .... together. Magit > only makes sense for a git repository, you might want to have C-x v l > (or some other status command) invoke the different "viewer". If > Magit (e.g.) has other global bindings that make sense for version > control, those also make more sense to put under C-x v. The problem is that magit-status is both a "visualization" mode, similar to C-x v d or C-x v l, and a "dispatcher" mode, similar to C-x v. An example of usage includes, for example, C-x g c - a c C-c C-c. This is the equivalent of git commit -a C-x C-s C-x k RET. I can't see a 'vc-commit' function in C-x v, but if there was one, C-x g c would essentially replace it. Similarly C-x g P is a vc-push, C-x g F is a (hypothetical) vc-fetch, C-x g d is a vc-diff, etc. As such, magit would be better seen as a replacement of the whole vc keymap than as a part of it. And I don't know if anybody uses both magit and vc-mode for git version control. (I occasionally use vc-merge-conflict, but this is not on C-x v.) But I'm not claiming that rebinding C-x v to magit whenever we are in a git repository would be a good idea. :)