unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Sam Steingold <sds@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 934a72c: User can specify files never subject t
Date: Tue, 5 Jun 2018 12:59:47 -0400	[thread overview]
Message-ID: <CAFsbZ7YbwvDrnjvUG+UGN965WC+PcxS+=YAr9ZpjZw8DQuFGVQ@mail.gmail.com> (raw)
In-Reply-To: <87h8mif6hs.fsf@gmail.com>

Hi,
yes, I actually thought you reverted the patch long ago.
Thanks

On Mon, Jun 4, 2018 at 7:59 PM, João Távora <joaotavora@gmail.com> wrote:
> Hi Sam,
>
> I was going through Flymake in master to perform some refactorings when
> I came across this change:
>
>    commit 934a72c7e4a506a36697fdb98f837cea989e70e1
>    Author: Sam Steingold <sds@gnu.org>
>    Date:   Wed Nov 1 09:36:41 2017 -0400
>
>        User can specify files never subject to flymake.
>
> There was some discussion around it
>
>    https://lists.gnu.org/archive/html/emacs-devel/2017-11/msg00054.html
>
> but I believe we later agreed (though off-list for some reason) that
> using a file or dir-local value of nil for
> `flymake-diagnostic-functions' is a much better alternative in Emacs
> 26.1 onwards. In the case of your "mini-scratch" Python files, just add:
>
> # Local Variables:
> # flymake-diagnostic-functions: nil
> # End:
>
> So, do you mind if I revert the patch?  I'm asking because new
> user-visible complexity in a file I'm trying to refactor is
> counterproductive to that task.
>
> João
>
>



-- 
Sam Steingold <http://sds.podval.org> <http://www.childpsy.net>
<http://steingoldpsychology.com>



      parent reply	other threads:[~2018-06-05 16:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-04 23:59 [Emacs-diffs] master 934a72c: User can specify files never subject t João Távora
2018-06-05 14:52 ` Eli Zaretskii
2018-06-05 15:11   ` João Távora
2018-06-05 15:41     ` Eli Zaretskii
2018-06-05 15:53       ` João Távora
2018-06-05 16:12         ` Eli Zaretskii
2018-06-05 16:59 ` Sam Steingold [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFsbZ7YbwvDrnjvUG+UGN965WC+PcxS+=YAr9ZpjZw8DQuFGVQ@mail.gmail.com' \
    --to=sds@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=joaotavora@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).