From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Fabrice Popineau Newsgroups: gmane.emacs.devel Subject: Re: Windows 64 port Date: Fri, 23 Mar 2012 11:27:15 +0100 Message-ID: References: <20120219211800.0000558f@unknown> <834numv7js.fsf@gnu.org> <4F428780.8070902@cs.ucla.edu> <4F4D507F.7030008@cs.ucla.edu> <834ntfwxa6.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=e89a8ff253d41f50e504bbe679ed X-Trace: dough.gmane.org 1332498497 954 80.91.229.3 (23 Mar 2012 10:28:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 23 Mar 2012 10:28:17 +0000 (UTC) Cc: Eli Zaretskii , eggert@cs.ucla.edu, emacs-devel@gnu.org, ajmr@ilovetortilladepatatas.com To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 23 11:28:15 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SB1jB-0007dz-Tl for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2012 11:28:14 +0100 Original-Received: from localhost ([::1]:45175 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB1jB-00020F-AH for ged-emacs-devel@m.gmane.org; Fri, 23 Mar 2012 06:28:13 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB1j4-0001tW-0E for emacs-devel@gnu.org; Fri, 23 Mar 2012 06:28:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SB1iw-0001ul-OX for emacs-devel@gnu.org; Fri, 23 Mar 2012 06:28:05 -0400 Original-Received: from mail-ob0-f169.google.com ([209.85.214.169]:59660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SB1ic-0001rs-Ew; Fri, 23 Mar 2012 06:27:38 -0400 Original-Received: by obbta14 with SMTP id ta14so2738350obb.0 for ; Fri, 23 Mar 2012 03:27:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=cgd1rcMAeNqp0S8OkHBYfA45L4DUk+4IfVqqVQhHeMY=; b=v1bYjkkraS5yIQ9Wd7GBdV4o9xEyS913prBiL4sx3eKa6IM5qi4PZ58hCGBAG5kzI6 TpAHRf9WnTM/p2MYi0qRQcj36HoNHBrkVIa6hk/bE/GA2bxdM8L64MPR2Z53sDSGcsR0 6y1C7iDBA/8+2EFKxhNyvKDfFCCdGgHR/S5adMYJSw25pKzO3Zhf996QFhA26trvFleo CNu1Dnthm/GLDWx9lNEEsLDhg3ydzVKaPvSgpHZd36hD4YUlZeUgfy1UwZhOnbLiga0C IJ+ZEblOifxNLHg99Mz5NhvZaqn1ZrTh3UzJKTBfvhcRV1H2esvG0fpvIEozd2QTc1pH Sgjw== Original-Received: by 10.60.13.196 with SMTP id j4mr13889126oec.14.1332498455809; Fri, 23 Mar 2012 03:27:35 -0700 (PDT) Original-Received: by 10.60.66.194 with HTTP; Fri, 23 Mar 2012 03:27:15 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: IHaL2KSnDuUkuXoSZ1kx1XNRS5U X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:149193 Archived-At: --e89a8ff253d41f50e504bbe679ed Content-Type: text/plain; charset=ISO-8859-1 > > > Perhaps so, but using that obfuscates the code, so it's undesirable if > > it can be avoided. > > There is no obfuscation. This is the only way to make it work > correctly. > > Well ... maybe write it : if (negative_number) u_number_value = ~ u_number_value + 1; which would more closely match the earlier comment in the code and avoid lame guys like me to ask about it. (And also avoid stupid compiler warnings). I have another question related to strftime.c : is there any reason not to use the system one on Windows ? Fabrice --e89a8ff253d41f50e504bbe679ed Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
> Perhaps= so, but using that obfuscates the code, so it's undesirable if
> it can be avoided.

There is no obfuscation. =A0This is the only way to make it work
correctly.

Well ... maybe write it :
=

=A0 =A0 =A0 =A0 =A0 if (negative_number)
=A0 = =A0 =A0 =A0 =A0 =A0 u_number_value =3D ~ u_number_value + 1;

which would more closely match the earlier comment in the co= de
and avoid lame guys like me to ask about it.
(And al= so avoid stupid compiler warnings).

I have another= question related to strftime.c : is there any reason not to use the system= one on Windows ?

Fabrice
--e89a8ff253d41f50e504bbe679ed--