From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Fabrice Popineau Newsgroups: gmane.emacs.devel Subject: Re: dired-tests.el fails on MS-Windows Date: Fri, 4 Aug 2017 16:23:12 +0200 Message-ID: References: <83zibjz519.fsf@gnu.org> <87d18fw79z.fsf@calancha-pc> <83pocfyurp.fsf@gnu.org> <831sorxyol.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a114005b6f19b010555ee3dbd" X-Trace: blaine.gmane.org 1501857169 3795 195.159.176.226 (4 Aug 2017 14:32:49 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 4 Aug 2017 14:32:49 +0000 (UTC) Cc: Emacs developers , Tino Calancha To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 04 16:32:45 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dddee-0000kb-OD for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 16:32:44 +0200 Original-Received: from localhost ([::1]:34089 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dddek-0007gB-Kw for ged-emacs-devel@m.gmane.org; Fri, 04 Aug 2017 10:32:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dddXv-0007Zr-Rz for emacs-devel@gnu.org; Fri, 04 Aug 2017 10:29:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dddWq-0002HV-VC for emacs-devel@gnu.org; Fri, 04 Aug 2017 10:25:47 -0400 Original-Received: from mail-qk0-x22f.google.com ([2607:f8b0:400d:c09::22f]:32778) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dddVm-00010I-4Z; Fri, 04 Aug 2017 10:23:34 -0400 Original-Received: by mail-qk0-x22f.google.com with SMTP id a77so9808523qkb.0; Fri, 04 Aug 2017 07:23:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=1pAt9Za6lsEDy9U4AAdphWAWlrib3TibjU0ejZluOyE=; b=KvKjcnOStDIFw7lxFQmQ1o5QJLSGftbbTw+1qO/tXVMdQOZlk8Ka9qEm+XO5+9aTz7 b0xUKBI9gCRQThMV4J+g2RpUmrWz6w2z0RulHrnzEPCW3FgekBKvpzfGn18Va5gThUjk WXKHTJmxCt1js/JrfYNhF465XHYU+VWz/RXwAhokWKzd+/KPwL7TaTKC381+OBZ5JCQb 91grSnnf2Can4Vw5PezjCBDKOqfhMvVwSK9R/aXT2kMQww+gQCrgQ6VCxdQb7teKqrrb utwSTmx3848NsH5RDqimPMsJS9Cy3AM3QCXVNh+SOh0waQ3jwSVdrD3K9v158YfaA2WU b+0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=1pAt9Za6lsEDy9U4AAdphWAWlrib3TibjU0ejZluOyE=; b=FelkIKTey2bzHYWrtcudwzIhSs5VteqMchG+ZsKf9vZFlLvy+Rpf4vanilkQkps/7a j73MYm+HE7EPGYS8a1ojicYila94KY5AMS80/ZKZfHluRcoVguzTWyszHpbo6Wy3fpLv BNoxDdsxqUEJaXP5HDOiSSvw5VS5K6q/StmGEKnOA6RBD6LtrexSmIISKmgfvBDdXy0V 6jU/ziE3jOb/hLEfAmL7GmnpL4v9UpLVm6IEPqy4CzVDvRJxWBQuMmuj1lfJvahN/7QV OygFYUpIUJfIrxymq5IINHGfA/CucU4edAcJSJBw0B3eOxqG3k39A88ODgqW2Oyox7ng /JRQ== X-Gm-Message-State: AHYfb5isaE1PZ7No2g5xlzzacwbtomHW/5m+CqTKdy5h83lcqCN9p52s phsNTpwyTd4nwXYN3dnBOXX0x2rO2wYe X-Received: by 10.55.19.138 with SMTP id 10mr3600767qkt.34.1501856613373; Fri, 04 Aug 2017 07:23:33 -0700 (PDT) Original-Received: by 10.140.82.21 with HTTP; Fri, 4 Aug 2017 07:23:12 -0700 (PDT) In-Reply-To: <831sorxyol.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:400d:c09::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:217289 Archived-At: --001a114005b6f19b010555ee3dbd Content-Type: text/plain; charset="UTF-8" 2017-08-04 15:14 GMT+02:00 Eli Zaretskii : > > From: Tino Calancha > > Date: Fri, 4 Aug 2017 14:21:01 +0900 (JST) > > cc: Tino Calancha , > > Emacs developers > > > > > maybe if you could explain the idea behind the code I could think of a > > > reason why it doesn't work here. > > I added more comments and sanity checks in commit > > db5d38ddb0de83d8f920b7a128fe3fd5156fdf85 > > (Fix 2 tests that fail in MS-Windows) > > Does it work now in Windows? > > It didn't, but given the comments I've now succeeded to understand the > idea of dired-test-bug25609, and fixed it. > > dired-test-bug27631 still fails, and it fails because of this: > > (setq buf (dired (expand-file-name "dir*/*.txt" dir))) > > ls-lisp signals an error here: > > wrong-type-argument listp "dir*/*.txt" > > Didn't you add a feature lately that should support this in ls-lisp? > I guess that feature needs to be turned on for this test to pass on > Windows. > > Actually, the problem seems to be in the `insert-directory-wildcard-in-dir-p' function which wrongly splits "c:/tmp/dir*/*.txt" in ("c:/tmp/" . "dir*/*.txt") instead of ("c:/tmp/dir*/" . "*.txt") -- Fabrice --001a114005b6f19b010555ee3dbd Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


2017-08-04 15:14 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
=
> From: Tino Calancha = <tino.calancha@gmail.com&= gt;
> Date: Fri, 4 Aug 2017 14:21:01 +0900 (JST)
> cc: Tino Calancha <tino.= calancha@gmail.com>,
>=C2=A0 =C2=A0 =C2=A0Emacs developers <emacs-devel@gnu.org>
>
> > maybe if you could explain the idea behind= the code I could think of a
> > reason why it doesn't work here.
> I added more comments and sanity checks in commit
> db5d38ddb0de83d8f920b7a128fe3fd5156fdf85
> (Fix 2 tests that fail in MS-Windows)
> Does it work now in Windows?

It didn't, but given the comments I've now succeeded to unde= rstand the
idea of dired-test-bug25609, and fixed it.

dired-test-bug27631 still fails, and it fails because of this:

=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 (setq buf (dired (expand-file-name "= ;dir*/*.txt" dir)))

ls-lisp signals an error here:

=C2=A0 =C2=A0wrong-type-argument listp "dir*/*.txt"

Didn't you add a feature lately that should support this in ls-lisp? I guess that feature needs to be turned on for this test to pass on
Windows.


Actually, the probl= em seems to be in the `insert-directory-wildcard-in-dir-p' function
which wrongly splits "c:/tmp/dir*/*.txt&q= uot; in ("c:/tmp/" . "dir*/*.txt") instead of
("c:/tmp/dir*/" . "*.txt")
=


--
Fa= brice
--001a114005b6f19b010555ee3dbd--