From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Fabrice Popineau Newsgroups: gmane.emacs.devel Subject: Re: Windows 64 port Date: Tue, 27 Mar 2012 14:47:53 +0200 Message-ID: References: <20120219211800.0000558f@unknown> <834numv7js.fsf@gnu.org> <83ty2ltep0.fsf@gnu.org> <4F4EEBC2.5070704@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=bcaec52d58f780c43e04bc38e7d1 X-Trace: dough.gmane.org 1332852522 7986 80.91.229.3 (27 Mar 2012 12:48:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 27 Mar 2012 12:48:42 +0000 (UTC) Cc: Eli Zaretskii , ajmr@ilovetortilladepatatas.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 27 14:48:41 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SCVpJ-0002wI-2v for ged-emacs-devel@m.gmane.org; Tue, 27 Mar 2012 14:48:41 +0200 Original-Received: from localhost ([::1]:50132 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCVpI-0003Fv-Ga for ged-emacs-devel@m.gmane.org; Tue, 27 Mar 2012 08:48:40 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36789) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCVpA-00037R-Rp for emacs-devel@gnu.org; Tue, 27 Mar 2012 08:48:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SCVp4-0007e6-KW for emacs-devel@gnu.org; Tue, 27 Mar 2012 08:48:32 -0400 Original-Received: from mail-bk0-f41.google.com ([209.85.214.41]:52411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SCVow-0007c1-6S; Tue, 27 Mar 2012 08:48:18 -0400 Original-Received: by bkwq16 with SMTP id q16so5991101bkw.0 for ; Tue, 27 Mar 2012 05:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=gKg22t3ZhSicMuLE3YFs7aHioSTLaIyiajMUKknFkNc=; b=IMSF4OwOJTqsVe20GGOJmefDjWzm9Q857O31dk/0S1f3W0yC3mInEcu9kyoxJUYy0G 1GXM4gfgCnbFYXJUO0RH1BfZBuAuNc7ArFKp/Td2NfjdBSPTyTl/iguCFBWNqsrpiR+x 3PhUAlDeZOnSAIICJOSMOem2gKis5//bKrZNVQvhpvTvzk4HkabBMGbTvTeDN1ZMZCYI RwAM9dnNL6SDKy7Pr+ixOw2EkupQr58MosvZtAjR8Q3nlGbK0i7pUOFxsmLO8GsKhj4O a2RzAxsg7hyL+750f7fX3m50rRr0/dWLyQJ+2b5b9NaGmgy5pNyU8CZ6MqhVWCq+fn/I UkNQ== Original-Received: by 10.204.173.11 with SMTP id n11mr10137810bkz.120.1332852495008; Tue, 27 Mar 2012 05:48:15 -0700 (PDT) Original-Received: by 10.204.179.143 with HTTP; Tue, 27 Mar 2012 05:47:53 -0700 (PDT) In-Reply-To: <4F4EEBC2.5070704@cs.ucla.edu> X-Google-Sender-Auth: CzIQLVTcpSNRTSuyZV-u3Q2FagE X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:149227 Archived-At: --bcaec52d58f780c43e04bc38e7d1 Content-Type: text/plain; charset=ISO-8859-1 2012/3/1 Paul Eggert > > - unsigned long int magic; /* Magic number to check header integrity. > */ > > + uint64_t magic; /* Magic number to check header integrity. */ > > Not needed for Windows 64, since the magic number fits in 32 bits. > If it fits in 32 bits, then it shouldn't be long in first place? Unsigned int is enough and will be 32 bits wide ofr x86 and x64. -- Fabrice --bcaec52d58f780c43e04bc38e7d1 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable

2012/3/1 Paul Eggert &= lt;eggert@cs.ucla.edu><= br>
> - =A0 =A0unsigned long int magic; /* Magic number to c= heck header integrity. =A0*/
> + =A0 =A0uint64_t magic; =A0/* Magic number = to check header integrity. =A0*/

Not needed for Windows 64, since the magic number fits in 32 bits.

If it fits in 32 bits, then it shouldn't be long in= first place?=A0
Unsigned int is enough and will be 32 bits wide ofr x8= 6 and x64.

--
Fabrice
--bcaec52d58f780c43e04bc38e7d1--