From: Fabrice Popineau <fabrice.popineau@centralesupelec.fr>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Andy Moreton <andrewjmoreton@gmail.com>,
Emacs developers <emacs-devel@gnu.org>
Subject: Re: Suspicious warning in W64 build
Date: Fri, 15 Sep 2017 17:33:48 +0200 [thread overview]
Message-ID: <CAFgFV9MH-=ixZp4QdmSyST4a7jg0AZA5EDg_22+PF_Q6hS_UiQ@mail.gmail.com> (raw)
In-Reply-To: <83a81wmijy.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 5074 bytes --]
2017-09-15 11:12 GMT+02:00 Eli Zaretskii <eliz@gnu.org>:
> > From: Fabrice Popineau <fabrice.popineau@centralesupelec.fr>
> > Date: Fri, 15 Sep 2017 08:55:06 +0200
> > Cc: Emacs developers <emacs-devel@gnu.org>
> >
> > # define pDWP "16llx"
> > ^
> >
> > Should these be using the ptrdiff_t formatter pD from lisp.h ?
> >
> > I'd rather cast the values to "long long unsigned int" as these values
> are assumed to be positive,
> > and would be meaningless if printed in decimal.
>
> That's what I did.
>
>
That's ok and no more warnings now.
> > There are also a bunch of warnings in dispnew.c:adjust_glyph_matrix()
> > because the w parameter could be NULL. Actually, some parts of the code
> > are protected with if (w) { ... } but much more than those ones assume
> that
> > w is not NULL.
>
> That's because they really cannot be NULL at that point. GCC 7
> doesn't really understand the code, so it shouldn't emit these
> warnings, if it wants them to be useful.
>
> > I wonder if the whole function should not just return if w is NULL.
>
> No!
Ok. I see your eassert() added at this point.
But clearly there is a problem with GCC 7, because it doesn't understand
the implications of this eassert() :
CC dispnew.o
../../emacs/src/dispnew.c: In function 'adjust_frame_glyphs':
../../emacs/src/dispnew.c:392:14: warning: null pointer dereference
[-Wnull-dereference]
left = margin_glyphs_to_reserve (w, dim.width, w->left_margin_cols);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../emacs/src/dispnew.c:322:11: warning: null pointer dereference
[-Wnull-dereference]
int width = w->total_cols;
^~~~~
../../emacs/src/dispnew.c:393:15: warning: null pointer dereference
[-Wnull-dereference]
right = margin_glyphs_to_reserve (w, dim.width,
w->right_margin_cols);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../emacs/src/dispnew.c:322:11: warning: null pointer dereference
[-Wnull-dereference]
int width = w->total_cols;
^~~~~
In file included from ../../emacs/src/frame.h:23:0,
from ../../emacs/src/dispnew.c:34:
../../emacs/src/window.h:651:38: warning: null pointer dereference
[-Wnull-dereference]
#define WINDOW_LEFT_PIXEL_EDGE(W) (W)->pixel_left
~~~^~~
../../emacs/src/dispnew.c:401:36: note: in expansion of macro
'WINDOW_LEFT_PIXEL_EDGE'
&& matrix->window_pixel_left == WINDOW_LEFT_PIXEL_EDGE (w)
^~~~~~~~~~~~~~~~~~~~~~
../../emacs/src/window.h:660:37: warning: null pointer dereference
[-Wnull-dereference]
#define WINDOW_TOP_PIXEL_EDGE(W) (W)->pixel_top
~~~^~~
../../emacs/src/dispnew.c:402:35: note: in expansion of macro
'WINDOW_TOP_PIXEL_EDGE'
&& matrix->window_pixel_top == WINDOW_TOP_PIXEL_EDGE (w)
^~~~~~~~~~~~~~~~~~~~~
../../emacs/src/dispnew.c:404:34: warning: null pointer dereference
[-Wnull-dereference]
&& matrix->window_vscroll == w->vscroll
~^~~~~~~~~
../../emacs/src/dispnew.c:392:14: warning: null pointer dereference
[-Wnull-dereference]
left = margin_glyphs_to_reserve (w, dim.width, w->left_margin_cols);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../emacs/src/dispnew.c:322:11: warning: null pointer dereference
[-Wnull-dereference]
int width = w->total_cols;
^~~~~
../../emacs/src/dispnew.c:393:15: warning: null pointer dereference
[-Wnull-dereference]
right = margin_glyphs_to_reserve (w, dim.width,
w->right_margin_cols);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../emacs/src/dispnew.c:322:11: warning: null pointer dereference
[-Wnull-dereference]
int width = w->total_cols;
^~~~~
In file included from ../../emacs/src/frame.h:23:0,
from ../../emacs/src/dispnew.c:34:
../../emacs/src/window.h:651:38: warning: null pointer dereference
[-Wnull-dereference]
#define WINDOW_LEFT_PIXEL_EDGE(W) (W)->pixel_left
~~~^~~
../../emacs/src/dispnew.c:401:36: note: in expansion of macro
'WINDOW_LEFT_PIXEL_EDGE'
&& matrix->window_pixel_left == WINDOW_LEFT_PIXEL_EDGE (w)
^~~~~~~~~~~~~~~~~~~~~~
../../emacs/src/window.h:660:37: warning: null pointer dereference
[-Wnull-dereference]
#define WINDOW_TOP_PIXEL_EDGE(W) (W)->pixel_top
~~~^~~
../../emacs/src/dispnew.c:402:35: note: in expansion of macro
'WINDOW_TOP_PIXEL_EDGE'
&& matrix->window_pixel_top == WINDOW_TOP_PIXEL_EDGE (w)
^~~~~~~~~~~~~~~~~~~~~
../../emacs/src/dispnew.c:404:34: warning: null pointer dereference
[-Wnull-dereference]
&& matrix->window_vscroll == w->vscroll
~^~~~~~~~~
cc1.exe: warning: null pointer dereference [-Wnull-dereference]
cc1.exe: warning: null pointer dereference [-Wnull-dereference]
--
Fabrice
[-- Attachment #2: Type: text/html, Size: 7372 bytes --]
next prev parent reply other threads:[~2017-09-15 15:33 UTC|newest]
Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-05 13:38 Suspicious warning in W64 build Angelo Graziosi
2017-09-05 14:04 ` Richard Copley
2017-09-07 15:16 ` Eli Zaretskii
2017-09-07 15:42 ` Angelo Graziosi
2017-09-07 17:52 ` Richard Copley
2017-09-07 17:58 ` Richard Copley
2017-09-07 19:00 ` Angelo Graziosi
2017-09-07 19:21 ` Richard Copley
2017-09-09 4:58 ` Herring, Davis
2017-09-09 9:55 ` Richard Copley
2017-09-09 10:20 ` Eli Zaretskii
2017-09-09 11:24 ` Angelo Graziosi
2017-09-09 13:25 ` Eli Zaretskii
2017-09-09 11:16 ` Angelo Graziosi
2017-09-07 18:58 ` Eli Zaretskii
2017-09-07 19:26 ` Paul Eggert
2017-09-07 19:50 ` Richard Copley
2017-09-07 20:02 ` Richard Copley
2017-09-08 6:49 ` Eli Zaretskii
2017-09-08 8:02 ` Eli Zaretskii
2017-09-08 19:31 ` Richard Copley
2017-09-08 20:17 ` Eli Zaretskii
2017-09-08 21:08 ` Richard Copley
2017-09-08 21:37 ` Richard Copley
2017-09-09 7:37 ` Eli Zaretskii
2017-09-08 22:20 ` Richard Copley
2017-09-09 7:33 ` Eli Zaretskii
2017-09-09 9:36 ` Richard Copley
2017-09-09 10:42 ` Eli Zaretskii
2017-09-09 10:52 ` Eli Zaretskii
2017-09-09 11:17 ` Richard Copley
2017-09-09 16:07 ` Eli Zaretskii
2017-09-10 1:01 ` Richard Copley
2017-09-10 14:40 ` Eli Zaretskii
2017-09-10 19:14 ` Richard Copley
2017-09-10 19:38 ` Angelo Graziosi
2017-09-11 16:17 ` Eli Zaretskii
2017-09-11 22:21 ` Angelo Graziosi
2017-09-11 16:39 ` Óscar Fuentes
2017-09-11 17:20 ` Eli Zaretskii
2017-09-12 17:49 ` Eli Zaretskii
2017-09-12 18:01 ` Fabrice Popineau
2017-09-12 18:37 ` Richard Copley
2017-09-12 18:59 ` Eli Zaretskii
2017-09-12 19:14 ` Richard Copley
2017-09-12 18:38 ` Eli Zaretskii
2017-09-14 17:47 ` Eli Zaretskii
2017-09-14 19:34 ` Richard Copley
2017-09-15 8:54 ` Eli Zaretskii
2017-09-15 23:05 ` Richard Copley
2017-09-16 6:40 ` Eli Zaretskii
2017-09-16 8:19 ` Richard Copley
2017-09-16 8:34 ` Richard Copley
2017-09-16 8:54 ` Eli Zaretskii
2017-09-16 9:07 ` Richard Copley
2017-09-16 11:54 ` Fabrice Popineau
2017-09-16 8:52 ` Eli Zaretskii
2017-09-15 8:59 ` Eli Zaretskii
2017-09-15 14:43 ` Eli Zaretskii
2017-09-17 6:42 ` Paul Eggert
2017-09-17 7:14 ` Richard Copley
2017-09-17 14:31 ` Eli Zaretskii
2017-09-17 6:40 ` Paul Eggert
2017-09-17 14:29 ` Eli Zaretskii
2017-09-17 16:39 ` Fabrice Popineau
2017-09-17 16:52 ` Eli Zaretskii
2017-09-18 0:26 ` Paul Eggert
2017-09-18 11:47 ` Fabrice Popineau
2017-09-18 14:46 ` Eli Zaretskii
2017-09-18 0:01 ` Richard Stallman
2017-09-14 19:36 ` Fabrice Popineau
2017-09-14 21:17 ` Andy Moreton
2017-09-15 6:55 ` Fabrice Popineau
2017-09-15 9:12 ` Eli Zaretskii
2017-09-15 15:33 ` Fabrice Popineau [this message]
2017-09-15 15:45 ` Eli Zaretskii
2017-09-15 18:15 ` Fabrice Popineau
2017-09-15 19:00 ` Eli Zaretskii
2017-09-15 21:02 ` Fabrice Popineau
2017-09-16 7:45 ` Eli Zaretskii
2017-09-17 7:01 ` Paul Eggert
2017-09-17 14:31 ` Eli Zaretskii
2017-09-17 14:52 ` Philipp Stephani
2017-09-17 22:34 ` Paul Eggert
2017-09-17 17:07 ` Paul Eggert
2017-09-17 17:14 ` Eli Zaretskii
2017-09-17 18:53 ` Paul Eggert
2017-09-17 19:30 ` Eli Zaretskii
2017-09-17 20:34 ` Paul Eggert
2017-09-18 2:30 ` Eli Zaretskii
2017-09-18 4:52 ` Paul Eggert
2017-09-18 14:41 ` Eli Zaretskii
2017-09-18 17:35 ` Paul Eggert
2017-09-18 17:58 ` Andy Moreton
2017-09-19 9:05 ` Paul Eggert
2017-09-18 18:01 ` Eli Zaretskii
2017-09-17 20:45 ` Paul Eggert
2017-09-16 13:17 ` Andy Moreton
2017-09-16 13:46 ` Eli Zaretskii
2017-09-16 18:57 ` Richard Copley
2017-09-16 19:21 ` Eli Zaretskii
2017-09-15 9:03 ` Eli Zaretskii
2017-09-09 8:49 ` Angelo Graziosi
2017-09-09 10:37 ` Eli Zaretskii
2017-09-09 11:32 ` Angelo Graziosi
2017-09-09 13:28 ` Eli Zaretskii
2017-09-09 13:33 ` Fabrice Popineau
2017-09-09 14:55 ` Angelo Graziosi
2017-09-09 16:37 ` Eli Zaretskii
2017-09-09 18:38 ` Angelo Graziosi
2017-09-09 18:59 ` Eli Zaretskii
2017-09-09 21:29 ` Angelo Graziosi
2017-09-10 14:56 ` Eli Zaretskii
2017-09-10 15:45 ` Angelo Graziosi
2017-09-10 16:02 ` Eli Zaretskii
2017-09-10 18:45 ` Angelo Graziosi
2017-09-10 19:43 ` Eli Zaretskii
2017-09-09 15:40 ` Angelo Graziosi
2017-09-09 16:40 ` Eli Zaretskii
2017-09-09 18:33 ` Fabrice Popineau
2017-09-07 20:20 ` Eli Zaretskii
2017-09-07 21:59 ` Angelo Graziosi
2017-09-08 8:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFgFV9MH-=ixZp4QdmSyST4a7jg0AZA5EDg_22+PF_Q6hS_UiQ@mail.gmail.com' \
--to=fabrice.popineau@centralesupelec.fr \
--cc=andrewjmoreton@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).