From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Fabrice Popineau Newsgroups: gmane.emacs.devel Subject: Re: Windows 64 port Date: Thu, 1 Mar 2012 08:04:41 +0100 Message-ID: References: <20120219211800.0000558f@unknown> <834numv7js.fsf@gnu.org> <4F428780.8070902@cs.ucla.edu> <4F4D507F.7030008@cs.ucla.edu> <83obshcy8n.fsf@gnu.org> <4F4E7FE0.9040907@cs.ucla.edu> <83d38xcoyt.fsf@gnu.org> <4F4EEE4D.4030706@cs.ucla.edu> <83aa41c6hq.fsf@gnu.org> <4F4F1721.6060201@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=0015175cb9d62606e704ba291455 X-Trace: dough.gmane.org 1330585530 8840 80.91.229.3 (1 Mar 2012 07:05:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 1 Mar 2012 07:05:30 +0000 (UTC) Cc: Eli Zaretskii , ajmr@ilovetortilladepatatas.com, emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 01 08:05:29 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S304u-00060R-L9 for ged-emacs-devel@m.gmane.org; Thu, 01 Mar 2012 08:05:28 +0100 Original-Received: from localhost ([::1]:55775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S304u-0002Yy-0D for ged-emacs-devel@m.gmane.org; Thu, 01 Mar 2012 02:05:28 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:58638) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S304e-0001zF-QZ for emacs-devel@gnu.org; Thu, 01 Mar 2012 02:05:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S304d-0002nV-55 for emacs-devel@gnu.org; Thu, 01 Mar 2012 02:05:12 -0500 Original-Received: from mail-bk0-f41.google.com ([209.85.214.41]:44863) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S304W-0002eE-MD; Thu, 01 Mar 2012 02:05:04 -0500 Original-Received: by bkwq16 with SMTP id q16so224594bkw.0 for ; Wed, 29 Feb 2012 23:05:01 -0800 (PST) Received-SPF: pass (google.com: domain of fabrice.popineau@gmail.com designates 10.204.156.204 as permitted sender) client-ip=10.204.156.204; Authentication-Results: mr.google.com; spf=pass (google.com: domain of fabrice.popineau@gmail.com designates 10.204.156.204 as permitted sender) smtp.mail=fabrice.popineau@gmail.com; dkim=pass header.i=fabrice.popineau@gmail.com Original-Received: from mr.google.com ([10.204.156.204]) by 10.204.156.204 with SMTP id y12mr1920730bkw.113.1330585501407 (num_hops = 1); Wed, 29 Feb 2012 23:05:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=MqdD+UutS6GIjkWIidQTKINOa/jvjLQGCuN29MSCHto=; b=TOuXjpfgrhCwvLvuo+UrEmPDkAUfx/72iV5DX8SwmoOHJd/EwUELcAPBsBWaX+Rsp4 4RTC+xl002R7kGhDznuaG6moUt2N2hTzcTOPSxLcPkiusczLXteFS0EzRr2YmpmYHT3O J+lz1aMr6cvcYJgjMcQ+srodV6oGWwBaIV1tU= Original-Received: by 10.204.156.204 with SMTP id y12mr1549370bkw.113.1330585501304; Wed, 29 Feb 2012 23:05:01 -0800 (PST) Original-Received: by 10.204.60.3 with HTTP; Wed, 29 Feb 2012 23:04:41 -0800 (PST) In-Reply-To: <4F4F1721.6060201@cs.ucla.edu> X-Google-Sender-Auth: N64Jts7VZcliAEFtEvEgCmXKm1k X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.214.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:148849 Archived-At: --0015175cb9d62606e704ba291455 Content-Type: text/plain; charset=ISO-8859-1 > > Suppose someone proposed lots of patches like this: > > - size_t len = strlen (string); > + size_t const len = strlen (string); > > on the grounds that the XYZ Corp. compiler warns whenever > code fails to use 'const' at every opportunity. > That would be bogus -- that's not the Emacs > programming style, and we shouldn't slavishly alter > mainstream code merely to pacify a third-party compiler > that prefers a different style. > > The const fixes I proposed are easily isolated: they affect only the src/regex.c file. You are free to submit it or to forget about it. In this file, const is used in a few places only, resulting in dozens of warnings. Either remove the use of const or use it everywhere it is needed. There is always the option to #define const to nothing, but I won't favor it. Fabrice --0015175cb9d62606e704ba291455 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Suppose someone p= roposed lots of patches like this:

- =A0size_t len =3D strlen (string);
+ =A0size_t const len =3D strlen (string);

on the grounds that the XYZ Corp. compiler warns whenever
code fails to use 'const' at every opportunity.
That would be bogus -- that's not the Emacs
programming style, and we shouldn't slavishly alter
mainstream code merely to pacify a third-party compiler
that prefers a different style.


The const fixe= s I proposed are easily isolated: they affect only the src/regex.c file.
You are free to submit it or to forget about it.
In this = file, const is used in a few places only, resulting in dozens of warnings. = Either
remove the use of const or use it everywhere it is needed.=A0
There is always the option to #define const to nothing, but I won't f= avor it.

Fabrice
--0015175cb9d62606e704ba291455--