From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Barry OReilly Newsgroups: gmane.emacs.devel Subject: Re: Simple lisp-tests.el and commit privs Date: Sun, 18 Aug 2013 18:05:26 -0400 Message-ID: References: <87y584c6gv.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=089e0111bcfa624a1c04e4400518 X-Trace: ger.gmane.org 1376863532 27479 80.91.229.3 (18 Aug 2013 22:05:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 18 Aug 2013 22:05:32 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 19 00:05:34 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VBB6L-0007VR-W8 for ged-emacs-devel@m.gmane.org; Mon, 19 Aug 2013 00:05:34 +0200 Original-Received: from localhost ([::1]:40132 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBB6L-0003J4-H3 for ged-emacs-devel@m.gmane.org; Sun, 18 Aug 2013 18:05:33 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44678) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBB6G-0003Ix-2Q for emacs-devel@gnu.org; Sun, 18 Aug 2013 18:05:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VBB6F-000365-0u for emacs-devel@gnu.org; Sun, 18 Aug 2013 18:05:28 -0400 Original-Received: from mail-oa0-x22f.google.com ([2607:f8b0:4003:c02::22f]:48844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VBB6E-00035z-Sc for emacs-devel@gnu.org; Sun, 18 Aug 2013 18:05:26 -0400 Original-Received: by mail-oa0-f47.google.com with SMTP id g12so4570235oah.6 for ; Sun, 18 Aug 2013 15:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=EF088jzqhGIjqB7g4v8wsfcdPM8LSmzRuK3GfLUE8NY=; b=U1xOvjby32vFojCGTiLeF+6/S9avBVvEmG4CZ3TTIGoFXXTJcV7zB8XUaxsUsSm9cA EEN5GM4dmNqCbBVK7gaslzC4rSg1AbJT9aJ1U0kVl/2GZmEor+gYH4zmCvcKe2SgEB50 4+UBYRuPYje2pLSsuUWHsSwM81gVr/KRumTMN9XwubRbEDQIX+MkuQMq6FPdsIL/H+MN w6I0HidFIxrHXSKdFxLTTaODvPFQ7ovDKZjNTgYUTNkuWd1TsPHVvf8CYYe1CkOybj9j Si73JJOepdy0Ss5DM7tPDNVivivNC/ulrDfyC7/Co0iuJD9FUtT+jk4X8sJ9dLT5YH22 kvSQ== X-Received: by 10.182.87.170 with SMTP id az10mr13082109obb.10.1376863526208; Sun, 18 Aug 2013 15:05:26 -0700 (PDT) Original-Received: by 10.76.89.194 with HTTP; Sun, 18 Aug 2013 15:05:26 -0700 (PDT) In-Reply-To: <87y584c6gv.fsf@yandex.ru> X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:4003:c02::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:162862 Archived-At: --089e0111bcfa624a1c04e4400518 Content-Type: text/plain; charset=ISO-8859-1 Thanks for the link to the previous discussion, Dmitry. Dmitry: >> Don't you think it would be better to have these tests in >> test/automated/ruby-mode-tests.el? Stefan: > I find it inconvenient, actually, because when the test fails, it's > a handy to be able to have a ruby-mode buffer where I can try out > sexp movement and indentation functions "in the usual way", together > with Edebug if needed. Surely there's a way to provide this debugging use case without ostracizing the test from the automated test suite. Why not have a ert-with-temp-buffer which if the test fails (within the form), a file would be saved off with the buffer contents. Ideally the test case name would be in the generated filename. Stefan: > use test/indent the general indentation rules, and use ERT rules to > check how indentation obeys the various indentation variables It looks like the test/indent tests are only good for null-diff general indentation rules. And worst of all not automated. --089e0111bcfa624a1c04e4400518 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Thanks for the link to the previous discussion, Dmitry.
Dmitry:
>> Don't you think it would be better to have the= se tests in
>> test/automated/ruby-mode-tests.el?

Stefan: > I find it inconvenient, actually, because when the test fails, it'= s
> a handy to be able to have a ruby-mode buffer where I can try out=
> sexp movement and indentation functions "in the usual way&quo= t;, together
> with Edebug if needed.

Surely there's a way to provide this= debugging use case without
ostracizing the test from the automated test= suite. Why not have a
ert-with-temp-buffer which if the test fails (wit= hin the form), a file
would be saved off with the buffer contents. Ideally the test case
name = would be in the generated filename.

Stefan:
> use test/indent = the general indentation rules, and use ERT rules to
> check how inden= tation obeys the various indentation variables

It looks like the test/indent tests are only good for null-diff
gene= ral indentation rules. And worst of all not automated.


--089e0111bcfa624a1c04e4400518--