unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Barry OReilly <gundaetiapo@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: GC and stack marking
Date: Thu, 22 May 2014 10:59:00 -0400	[thread overview]
Message-ID: <CAFM41H2MX7ZV2t1iK7Zh_-KRLXXXdyN=cj3cqWdtcESugwZe2Q@mail.gmail.com> (raw)
In-Reply-To: <83r43mmt25.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 794 bytes --]

> Yes. I looked at all the local variables in that stack frame, and
> their addresses on the stack are different from the one that
> triggers the problem.

[I assume you mean "void* values on the stack" rather than "addresses
on the stack".]

So when you printed the value of a one byte variable like
stack_top_variable, you printed it with any alignment padding there
might be?

Or in case of GC_POINTER_ALIGNMENT < sizeof(void*), you accounted for
mark_stack's candidate void* coming partially from different stack
variables?

And you accounted for the compiler reordering stack variables, eg to
more optimally align data? I confirmed for example that
stack_top_variable and message_p are allocated next to each other on
the stack in my build, with the i variable not between them in memory.

[-- Attachment #2: Type: text/html, Size: 920 bytes --]

  parent reply	other threads:[~2014-05-22 14:59 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-21 19:31 GC and stack marking Barry OReilly
2014-05-21 20:13 ` Eli Zaretskii
2014-05-21 20:49   ` Barry OReilly
2014-05-22  2:43     ` Eli Zaretskii
2014-05-22  3:12       ` Daniel Colascione
2014-05-22  5:37         ` David Kastrup
2014-05-22 13:57           ` Stefan Monnier
2014-05-22 15:49         ` Eli Zaretskii
2014-05-22 14:59       ` Barry OReilly [this message]
2014-05-22 17:03         ` Eli Zaretskii
  -- strict thread matches above, loose matches on Subject: below --
2014-05-19 16:31 Eli Zaretskii
2014-05-19 18:47 ` Paul Eggert
2014-05-19 19:14   ` Eli Zaretskii
2014-05-19 19:58     ` Paul Eggert
2014-05-19 20:03       ` Eli Zaretskii
2014-05-19 20:17         ` Paul Eggert
2014-05-20 16:37           ` Eli Zaretskii
2014-05-20 13:44 ` Stefan Monnier
2014-05-20 16:57   ` Eli Zaretskii
2014-05-20 17:54     ` Stefan Monnier
2014-05-20 19:28       ` Eli Zaretskii
2014-05-20 22:01         ` Stefan Monnier
2014-05-21  2:48           ` Eli Zaretskii
2014-05-21  3:01             ` Stefan Monnier
2014-05-21 15:39               ` Eli Zaretskii
2014-05-21 15:57                 ` Dmitry Antipov
2014-05-21 16:06                   ` Dmitry Antipov
2014-05-21 16:55                     ` Eli Zaretskii
2014-05-21 16:53                   ` Eli Zaretskii
2014-05-21 17:40                 ` Stefan Monnier
2014-05-21 17:58                   ` Eli Zaretskii
2014-05-22 15:20                     ` Eli Zaretskii
2014-05-22 16:14                       ` Stefan Monnier
2014-05-24 12:03                         ` Eli Zaretskii
2014-05-20 19:12     ` Daniel Colascione
2014-05-20 19:43       ` Eli Zaretskii
2014-05-20 22:03         ` Stefan Monnier
2014-05-21  2:51           ` Eli Zaretskii
2014-05-31  6:31   ` Florian Weimer
2014-05-31 14:24     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFM41H2MX7ZV2t1iK7Zh_-KRLXXXdyN=cj3cqWdtcESugwZe2Q@mail.gmail.com' \
    --to=gundaetiapo@gmail.com \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).