From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: felix Newsgroups: gmane.emacs.devel Subject: Re: PATCH: num3-mode for highlighting groups of digits in long numbers Date: Wed, 26 Sep 2012 14:59:23 -0700 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=00248c6a84d682de5804caa1ef9e X-Trace: ger.gmane.org 1348696776 27262 80.91.229.3 (26 Sep 2012 21:59:36 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 26 Sep 2012 21:59:36 +0000 (UTC) Cc: Noah Lavine , Michal Nazarewicz , emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 26 23:59:41 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TGzdq-0003MH-Ob for ged-emacs-devel@m.gmane.org; Wed, 26 Sep 2012 23:59:38 +0200 Original-Received: from localhost ([::1]:57464 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGzdl-0004o1-Qw for ged-emacs-devel@m.gmane.org; Wed, 26 Sep 2012 17:59:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:52763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGzde-0004U9-0c for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:59:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TGzdc-00076d-TJ for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:59:25 -0400 Original-Received: from mail-qc0-f169.google.com ([209.85.216.169]:54659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TGzdc-00076O-Oj for emacs-devel@gnu.org; Wed, 26 Sep 2012 17:59:24 -0400 Original-Received: by qcqt2 with SMTP id t2so1191471qcq.0 for ; Wed, 26 Sep 2012 14:59:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=RuzDVE2faRMpOG5L39YWetiJqyBtmZnXHDUzCgiHuSQ=; b=DsxiKmtaIlHUwvNvbRAz3t2TaoA8+/lzlo5/5sgw4gccOf0VdLVmVckDWkP1/BxuoS GkgCjEg6SXM8KDpB2KRoYbPjdxfmtL/SBjvYsZk/+k0E8J5V+AfpVhSsLj6klnmcuh0R XFr0oSIr3Pu1X/muPqm7e9APYiEwGxdFgUlS6XwDdVmCzyHtVuStmQoqdxDCHXNWu17y fEjqrE17JT/06YOxOnH4+PJaYRdzLfla1L150h9jAdH3jEzmAnh1dQTy+FX2fbcxZ19i 0fM0c7YFZCjNrMR0Mm/pAO6njlM/28VeV5x8rR1rEmoEFNicy6bGv1QE8Swl6GpoMyhM OsbQ== Original-Received: by 10.229.135.83 with SMTP id m19mr1230691qct.78.1348696763718; Wed, 26 Sep 2012 14:59:23 -0700 (PDT) Original-Received: by 10.49.12.8 with HTTP; Wed, 26 Sep 2012 14:59:23 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.216.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153611 Archived-At: --00248c6a84d682de5804caa1ef9e Content-Type: text/plain; charset=ISO-8859-1 On Wed, Sep 26, 2012 at 1:01 PM, Stefan Monnier wrote: > - Removed turn-on-num3-mode since (num3-mode) does the same anyway. > I do see that when num3-mode is already enabled (turn-on-num3-mode) did > nothing whereas (num3-mode) will call font-lock-fontify-buffer but if > that's a problem, we should fix num3-mode. > the turn-on- thing is a convention from emacs 23 and earlier. yeah, looks like it should go away, and the logic of calling (num3-mode) from lisp might need to be fixed > I'm not sure what the "-num-" prefix is meant to be and I'm not fond > of it. If it's meant for internal functions, then please use > "num--" instead. > yeah that's my fault, I've been flipping back and forth between using -pkg- and pkg--, and at the time I wrote num3 I was using -pkg-, and I prefer pkg-- now. --00248c6a84d682de5804caa1ef9e Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Wed, Sep 26, 2012 at 1:01 PM, Stefan Monnier <monnier@iro.umontr= eal.ca> wrote:
- Removed turn-on-num3-mode since (num3-mode) does the sa= me anyway.
=A0 I do see that when num3-mode is already enabled (turn-on-num3-mode) did=
=A0 nothing whereas (num3-mode) will call font-lock-fontify-buffer but if =A0 that's a problem, we should fix num3-mode.
the turn-on- thing is a convention from emacs 23 and earlier. = =A0yeah, looks like it should go away, and the logic of calling (num3-mode)= from lisp might need to be fixed
=A0
I'm not sure what the "-num-" prefix is meant to be and I'= ;m not fond
of it. =A0If it's meant for internal functions, then please use
"num--" instead.

yeah that= 9;s my fault, I've been flipping back and forth between using -pkg- and= pkg--, and at the time I wrote num3 I was using -pkg-, and I prefer pkg-- = now.
--00248c6a84d682de5804caa1ef9e--