From: Justin Burkett <justin@burkett.cc>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Stefan Kangas <stefan@marxist.se>,
"Alfred M. Szmidt" <ams@gnu.org>, Amin Bandali <bandali@gnu.org>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Include which-key.el in the Emacs distribution
Date: Tue, 8 Sep 2020 14:11:07 -0400 [thread overview]
Message-ID: <CAF5dqN+HLSFgD0jXHO+QG2CCaK_J794OGYfwwJOUHqJ04m_+EA@mail.gmail.com> (raw)
In-Reply-To: <83mu20kusi.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1987 bytes --]
> I don't see the relevance, sorry. When I type "C-h" with
> which-key-mode on, I see a paging hint at the bottom line, and that
> hint simply doesn't work (and nothing else I tried does). By
> contrast, the vanilla "C-h" doesn't say anything about
> describe-prefix-bindings, so the problem will rarely if ever happen.
>
Ah, if it's just about the hint, then yes, that should be hidden in that
case.
IMO, this UI needs to be improved, certainly if we want to turn this
> mode on by default. For starters, how about using the usual Emacs
> scrolling keys for showing the next/previous page?
>
I wasn't advocating for it to be on by default, but yes, the UI could
probably be improved. It's a difficult problem (at least for me), because I
wanted which-key to be passive and not interfere with how emacs processes
key sequences. That's why I used the help-char escape mechanism to do the
paging. As far as the default keys, that's an easy change of course.
On Tue, Sep 8, 2020 at 2:06 PM Eli Zaretskii <eliz@gnu.org> wrote:
> > From: Justin Burkett <justin@burkett.cc>
> > Date: Tue, 8 Sep 2020 13:54:08 -0400
> > Cc: Amin Bandali <bandali@gnu.org>, Eli Zaretskii <eliz@gnu.org>,
> Stefan Kangas <stefan@marxist.se>,
> > emacs-devel <emacs-devel@gnu.org>
> >
> > I.e., you cannot paginate through the commands if you are issuing C-h
> > and have which-key-mode on.
> >
> > You also can't invoke describe-prefix-bindings from C-h in vanilla
> > emacs.
>
> I don't see the relevance, sorry. When I type "C-h" with
> which-key-mode on, I see a paging hint at the bottom line, and that
> hint simply doesn't work (and nothing else I tried does). By
> contrast, the vanilla "C-h" doesn't say anything about
> describe-prefix-bindings, so the problem will rarely if ever happen.
>
> IMO, this UI needs to be improved, certainly if we want to turn this
> mode on by default. For starters, how about using the usual Emacs
> scrolling keys for showing the next/previous page?
>
[-- Attachment #2: Type: text/html, Size: 3104 bytes --]
next prev parent reply other threads:[~2020-09-08 18:11 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-08 13:54 Include which-key.el in the Emacs distribution Stefan Kangas
2020-09-08 14:01 ` Ergus
2020-09-08 14:16 ` Stefan Kangas
2020-09-08 17:29 ` Yuan Fu
2020-09-08 17:40 ` Justin Burkett
2020-09-08 20:40 ` Stefan Kangas
2020-09-08 16:22 ` Alfred M. Szmidt
2020-09-08 17:24 ` Eli Zaretskii
2020-09-08 17:37 ` Amin Bandali
2020-09-08 17:51 ` Alfred M. Szmidt
2020-09-08 17:54 ` Justin Burkett
2020-09-08 18:06 ` Eli Zaretskii
2020-09-08 18:11 ` Justin Burkett [this message]
2020-09-08 20:40 ` Stefan Kangas
2020-09-08 18:10 ` Alfred M. Szmidt
2020-09-08 18:00 ` Eli Zaretskii
2020-09-08 19:12 ` Amin Bandali
2020-09-08 18:25 ` Caio Henrique
2020-09-08 19:19 ` Stefan Monnier
2020-09-08 20:14 ` Ergus
2020-09-08 20:40 ` Stefan Kangas
2022-02-11 21:31 ` Corwin Brust
2022-02-13 17:30 ` Philip Kaludercic
2022-02-14 9:04 ` Pankaj Jangid
2022-02-14 16:23 ` [External] : " Drew Adams
2022-02-14 22:09 ` Tim Cross
2022-02-13 17:59 ` Stephen Leake
2022-02-13 18:17 ` Corwin Brust
2022-02-13 23:25 ` Stephen Leake
2022-02-14 2:47 ` Stefan Monnier
2022-02-14 3:09 ` Justin Burkett
2022-02-14 3:46 ` Corwin Brust
[not found] <<CADwFkmmvVRqnQGA_d8bMA66SXbpjis+j-1UiceY7Lk7eY6iugA@mail.gmail.com>
[not found] ` <<E1kFgO6-0000cE-Dj@fencepost.gnu.org>
2020-09-08 17:55 ` Drew Adams
[not found] ` <<83sgbskwq8.fsf@gnu.org>
2020-09-08 18:05 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF5dqN+HLSFgD0jXHO+QG2CCaK_J794OGYfwwJOUHqJ04m_+EA@mail.gmail.com \
--to=justin@burkett.cc \
--cc=ams@gnu.org \
--cc=bandali@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).