From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipe Silva Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers, final testing Date: Tue, 4 Jul 2017 14:35:55 -0300 Message-ID: References: <83y3s9pm2a.fsf@gnu.org> <83zicmntaq.fsf@gnu.org> <83van9o6l8.fsf@gnu.org> <83mv8knuhi.fsf@gnu.org> <83fuecnr4p.fsf@gnu.org> <83d19gnocd.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a1137dbaad954c405538150f6" X-Trace: blaine.gmane.org 1499189845 29393 195.159.176.226 (4 Jul 2017 17:37:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Jul 2017 17:37:25 +0000 (UTC) Cc: Eli Zaretskii , James Nguyen , Emacs Development To: Richard Copley Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 04 19:37:19 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSRlD-0007CN-C0 for ged-emacs-devel@m.gmane.org; Tue, 04 Jul 2017 19:37:15 +0200 Original-Received: from localhost ([::1]:42407 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSRlI-0003XU-R7 for ged-emacs-devel@m.gmane.org; Tue, 04 Jul 2017 13:37:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48871) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSRjz-0003FH-OY for emacs-devel@gnu.org; Tue, 04 Jul 2017 13:36:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSRjy-00054F-JY for emacs-devel@gnu.org; Tue, 04 Jul 2017 13:35:59 -0400 Original-Received: from mail-oi0-x22f.google.com ([2607:f8b0:4003:c06::22f]:32927) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSRjw-000536-OP; Tue, 04 Jul 2017 13:35:56 -0400 Original-Received: by mail-oi0-x22f.google.com with SMTP id p188so108011916oia.0; Tue, 04 Jul 2017 10:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ofjDtoffJ05emyFSVZ8ozBXNewPaOTlYnPc8FD6tvmo=; b=HtVmDiMs1oyrRlyB+xjKcr4KqOdwxX5hW3ags6Fz9DIbH0JRWegRLDK3nqE1jxadd1 I5+1/KSVO13srY73fzkzULFWoHSqFS793bbARIvD5x21U0si+s+Nu83qzUVVCHqXr3nQ PfAnP+Dg7U/v6hv7cob+1GCmvxOnoOIN/fqUHlNhN0s+0YpwaKyMikXn7oUfUvDmr0cP +htysigWVMvCYiqtq4Orm2CLI1wdp+TQtD1Qh5Icl0etyprEfs9Xs1hOWnYbL1ZcV3+8 yJIp9kRNVJc8a5JwaUZUW2KqKOXXh0p+0hCIwud0NNLTloSoUqGTvS9RVTP4BWfOMhlh W+xA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ofjDtoffJ05emyFSVZ8ozBXNewPaOTlYnPc8FD6tvmo=; b=BOm65bsskl2jt3V/2iY3QLjpkrUc/GrYMi3Ocrr9l5Y0tyuYUpGzAVd0SVgV8MsjN+ TIvVISpu05Fwek2pBJmg94t/ko6BtSUlQWiUKjbPP3+HhM9E1PkpjmEQgCJ904i8vfdz EWRzb2vpayL2zitWwPwfkHSYDUjLlo7obRjK0jbbIFYGRbBGUBgaDt/ychTYSuFgdMPr NPQz4XPQsGzCtZA8ve5jxA4NYLIzkGT61SEgdTAYNG3HLdEtxgigZJa2C3tmASgxiUGU 75Xe6xjfz0Ddx7Fb5ssyyG70G9oB2jyT8v7Vn3n3MXGBDujyp774ydDXaPS/nQso0ZSV tZpA== X-Gm-Message-State: AKS2vOxbUS4V918NpXT0mx+2F4UknEII5EPq8a7ZKHOabwPbTmMEf+Kc V6mjF9YWQL7ehyDVIVSHGil3cCmRaQ== X-Received: by 10.202.45.3 with SMTP id t3mr21879660oit.26.1499189755858; Tue, 04 Jul 2017 10:35:55 -0700 (PDT) Original-Received: by 10.182.2.73 with HTTP; Tue, 4 Jul 2017 10:35:55 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22f X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216164 Archived-At: --001a1137dbaad954c405538150f6 Content-Type: text/plain; charset="UTF-8" About my previous point, this little function takes care of business when you want to toggle the behaviour of display 0 or the absolute line number for the current line with display-line-numbers set to 'visual or 'relative: (defun ninrod/toggle-absolute-current-relative-visual-line-number () "Toogle showing absolute line number or 0 for the current line when display-line-numbers is set to visual or relative" (interactive) (if display-line-numbers-current-absolute (setq display-line-numbers-current-absolute nil) (setq display-line-numbers-current-absolute t))) Boy, is this editor powerful. Holy cow. Eli, the bug is fixed. All seems fine with the face system now. On Tue, Jul 4, 2017 at 2:13 PM, Richard Copley wrote: > On 4 July 2017 at 17:44, Eli Zaretskii wrote: > >> From: Richard Copley > >> Date: Tue, 4 Jul 2017 17:35:16 +0100 > >> Cc: Eli Zaretskii , james@jojojames.com, > >> Emacs developers > >> > >> C-d 0 C-b C-n > >> C-d 1 C-b C-n > >> C-d 2 C-p C-p > >> > >> This is supposed to change the character at point to 0 and the > >> characters in the corresponding column in the next two lines to 1 > >> and 2. > >> > >> I think that's a common use case and it won't work if > >> display-line-numbers is on ... > > > > Does it really not work for you with display-line-numbers on? > > In fact it does work fine, when I test in a new Emacs session > which isn't affected by the bug I mentioned before. > > >> Open xdisp.c and go to line 30, column 30. > >> Type "C-d C-n C-d C-n C-d C-n C-d C-n" > >> The first C-n goes to column 30 on line 31 as expected. > >> The 2nd C-n goes to column 29 on line 31 (expected column 30). > >> The 3rd C-n goes to column 28 on line 31 (expected 30 (or 29?)). > >> The 4th C-n goes to column 27 on line 31. > > > > I cannot reproduce this, I get column 30 all the time, as expected. > > I can't reproduce it either, any more. Sorry about that, the recipe > seemed stable, but it didn't happen when I tried just now in > emacs -Q and no longer happens even with my usual customizations. > > If I see it again _and_ find a reliable recipe, I'll get back to you. > > > Are you running the latest branch? > > I was -- it was from just before your latest commit (committer time 18:43). > > > If so, what are the values of the > > related variables? > > `display-line-numbers' was `t', `column-number-mode' was turned on > and every other relevant variable (as far as I know) had its default value. > --001a1137dbaad954c405538150f6 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
About my previous p= oint, this little function takes care of business when you want=C2=A0
=
to toggle the behaviour of display 0 or the ab= solute line number for the current line with display-line-numbers set to &#= 39;visual or 'relative:

(defun ninrod/toggle-absolute-current-relative-vi= sual-line-number ()
=C2=A0 =C2=A0 =C2=A0 = =C2=A0"Toogle showing absolute line number or 0 for the current line w= hen display-line-numbers is set to visual or relative"
=C2=A0 =C2=A0 =C2=A0 =C2=A0(interactive)
=C2=A0 =C2=A0 =C2=A0 =C2=A0(if display-line-numbers-curr= ent-absolute
=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0(setq display-line-numbers-current-absolute nil)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(setq display-line-n= umbers-current-absolute t)))

Boy, is this editor powerful. Holy cow.=C2=A0

Eli,= the bug is fixed. All seems fine with the face system now.

On Tue, Jul 4, = 2017 at 2:13 PM, Richard Copley <rcopley@gmail.com> wrote:
On 4 July 2017 at 17:44, = Eli Zaretskii <eliz@gnu.org> wrot= e:
>> From: Richard Copley <rcop= ley@gmail.com>
>> Date: Tue, 4 Jul 2017 17:35:16 +0100
>> Cc: Eli Zaretskii <eliz@gnu.org= >, james@jojojames.com, >>=C2=A0 =C2=A0 =C2=A0 =C2=A0Emacs developers <emacs-devel@gnu.org>
>>
>> C-d 0 C-b C-n
>> C-d 1 C-b C-n
>> C-d 2 C-p C-p
>>
>> This is supposed to change the character at point to 0 and the
>> characters in the corresponding column in the next two lines to 1<= br> >> and 2.
>>
>> I think that's a common use case and it won't work if
>> display-line-numbers is on ...
>
> Does it really not work for you with display-line-numbers on?

In fact it does work fine, when I test in a new Emacs session
which isn't affected by the bug I mentioned before.

>> Open xdisp.c and go to line 30, column 30.
>> Type "C-d C-n C-d C-n C-d C-n C-d C-n"
>> The first C-n goes to column 30 on line 31 as expected.
>> The 2nd C-n goes to column 29 on line 31 (expected column 30).
>> The 3rd C-n goes to column 28 on line 31 (expected 30 (or 29?)). >> The 4th C-n goes to column 27 on line 31.
>
> I cannot reproduce this, I get column 30 all the time, as expected.
I can't reproduce it either, any more. Sorry about that, the rec= ipe
seemed stable, but it didn't happen when I tried just now in
emacs -Q and no longer happens even with my usual customizations.

If I see it again _and_ find a reliable recipe, I'll get back to you.
> Are you running the latest branch?

I was -- it was from just before your latest commit (committer time = 18:43).

> If so, what are the values of the
> related variables?

`display-line-numbers' was `t', `column-number-mode' was= turned on
and every other relevant variable (as far as I know) had its default value.=

--001a1137dbaad954c405538150f6--