From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipe Silva Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers, final testing Date: Tue, 4 Jul 2017 11:50:23 -0300 Message-ID: References: <83y3s9pm2a.fsf@gnu.org> <83zicmntaq.fsf@gnu.org> <83van9o6l8.fsf@gnu.org> <83mv8knuhi.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113d6250e2aa8c05537f0016" X-Trace: blaine.gmane.org 1499180332 14213 195.159.176.226 (4 Jul 2017 14:58:52 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Jul 2017 14:58:52 +0000 (UTC) Cc: James Nguyen , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 04 16:58:46 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSPHi-00031E-1v for ged-emacs-devel@m.gmane.org; Tue, 04 Jul 2017 16:58:38 +0200 Original-Received: from localhost ([::1]:41821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSPHn-0001N1-BS for ged-emacs-devel@m.gmane.org; Tue, 04 Jul 2017 10:58:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36527) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSP9p-00025Z-6K for emacs-devel@gnu.org; Tue, 04 Jul 2017 10:50:30 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSP9n-0002jU-RX for emacs-devel@gnu.org; Tue, 04 Jul 2017 10:50:29 -0400 Original-Received: from mail-oi0-x22a.google.com ([2607:f8b0:4003:c06::22a]:34472) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSP9l-0002il-NA; Tue, 04 Jul 2017 10:50:25 -0400 Original-Received: by mail-oi0-x22a.google.com with SMTP id l130so106236343oib.1; Tue, 04 Jul 2017 07:50:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Za/O7Y8IyomtTGrJzALbCgeA5QUuMpdgTz6QYvLm0fo=; b=nUeKwjTT45fF1rF1YgpwRK8yfFzPeja1lIbC79FiMBFqYq3gEdDRre2YBe9Yv15cX6 /Q2GnYQpwiD/3bRX36cMEsujlrGMCkSVePO9HZJO2HWKHs85lvUhFae5IA9Zrasw/9r0 IEYuhod2OStBpGLli6mESbhzquybOYq9TJqd35fQybe5xr8xgv9ec5RBk0KDUp3wfmNW 6F2/5WF1qamGkcDRdRQqfEcEjPTiCI5XBp3k+IS0ntraKt22DQP8+BBcq7ocky75i15n E1HWYc6j+YueFt/uW73aZsou0vHo3FOi+dwiI3QJJSH8160bblCmestyy5g6G8qAe66+ 6UYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Za/O7Y8IyomtTGrJzALbCgeA5QUuMpdgTz6QYvLm0fo=; b=RswVpZV6Rui0DuvcVm8MK6b0jtEeRfF6iUupK4rqyfj+cyNKHQ3quTC9R8xR0RM9/F /9vtUsycAHSLajRDGOun7yt3F4Rpvt+Ioplhqg51aa+9/kJ9s6S+b0OkhWVYKHLRR7tA +xtstmPdTD8Ahd1D1u0paMYaC4ety5Y7QNEnEHFMSX07+i6JfUfJzP4k98481j0dMLVr hMD2ZNSG8FmpJYyWYfxKqk3P/Amu4s1RwubOdfmNE8QW1VYPq4MPfXU1Jxiv5to0J+KW p7Qp0mX1NwFu0eC6FuTyqMOqRqhR8Sjv6IB6u0NSOihQYBL/Th2vSG/9WwGHvV0TPcWd VOrg== X-Gm-Message-State: AIVw110nRFNhFSgLWN35t2R2xHerAfUC4IwzYb1rSOzQQwVm0ktnYz8l H8hcLaLMfxaPWj6BbbxQrBVVX4w91Jqw X-Received: by 10.202.222.139 with SMTP id v133mr1774519oig.42.1499179824357; Tue, 04 Jul 2017 07:50:24 -0700 (PDT) Original-Received: by 10.182.2.73 with HTTP; Tue, 4 Jul 2017 07:50:23 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::22a X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216157 Archived-At: --001a113d6250e2aa8c05537f0016 Content-Type: text/plain; charset="UTF-8" I don't know why the message was garbled, before. here's another try: Eli thanks you for the information. will test that. I found a bug regarding the line-number-current-line face. Here's a screenshot: http://i.imgur.com/I2sneeL.png I'm using this configuration for relative visual numbers: (custom-set-variables ... '(display-line-numbers 'visual) ...) And here's my setup for the faces: ;; MODE SUPPORT: line numbers and relative line numbers (line-number (:inherit 'highlight-numbers-number)) (line-number-current-line (:foreground gruvbox-neutral_red)) In my testing, I found that when point is on line 1, everything is fine. As you go down line by line, the line-number-current-face skips ahead by one so by the time point is on line 10, line-number-current-line face is really acting on a number 9 lines below what should be the current line. On Tue, Jul 4, 2017 at 11:48 AM, Filipe Silva wrote: > Eli thanks you for the information. will test that. > > I found a bug regarding the line-number-current-line face. Here's a > screenshot: http://i.imgur.com/I2sneeL.png > > I'm using this configuration for relative visual numbers: > > (custom-set-variables > ... > '(display-line-numbers 'visual) > ...) > > And here's my setup for the faces: > > ;; MODE SUPPORT: line numbers and relative line numbers > > (line-number (:inherit 'highlight-numbers-number)) > (line-number-current-line (:foreground gruvbox-neutral_red)) > > In my testing, I found that when point is on line 1, everything is fine. > As you go down line by line, the line-number-current-face skips ahead by > one so by the time point is on line 10, line-number-current-line face is > really acting on a number 9 lines below what should be the current line. > > > On Tue, Jul 4, 2017 at 11:32 AM, Eli Zaretskii wrote: > >> > From: Filipe Silva >> > Date: Tue, 4 Jul 2017 07:57:10 -0300 >> > Cc: Eli Zaretskii , Emacs developers > > >> > >> > When working with really large files, 10k+ lines long, having the >> current line display the abs line number can >> > feel "to much" because all lines have max 2 number and the current line >> has 5 number so the fringe has to >> > grow extra 3 columns just to acommodate the current abs line number of >> the current line. >> > >> > Would it be possible to have like a toggle mechanism to switch the >> current line number of the current line from >> > abs to nothing or even to zero? that'd be a great addition to this >> already awesome feature. >> >> You can customize display-line-numbers-current-absolute to do what you >> want. >> >> Thank you for the feedback. >> > > --001a113d6250e2aa8c05537f0016 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
= I don't know why the message was = garbled, before. here's another try:=C2=A0

Eli thanks you = for the information. will test that.

I found a bug regarding t= he line-number-current-line face. Here's a screenshot: http://i.imgur.com/I2sneeL.png
<= div class=3D"gmail_default">
=
I'm using this configuration for relative visual numbers:
=
(custom-set-variables
...
=C2=A0'(display-line-numbers= 'visual)
...)

<= font face=3D"courier new, monospace">And here's my setup for the faces:=

=C2=A0 ;; MODE SUPPORT: line numbers and relative line number= s

=C2=A0 (line-number =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0(:inherit 'highlight-numbers-number))
=C2=A0 (line-numbe= r-current-line (:foreground gruvbox-neutral_red))

In my testin= g, I found that when point is on line 1, everything is fine. As you go down= line by line, the line-number-current-face skips ahead by one so by the ti= me point is on line 10, line-number-current-line face is really acting on a= number 9 lines below what should be the current line.=C2=A0


On Tue, Jul 4, 2017 at 11:48 AM, Filipe Silva <filipe.si= lva@gmail.com> wrote:
Eli tha= nks you for the information. will test that.

I found a bug regarding t= he=C2=A0line-number-current-line face. Here's a screenshot:=C2=A0http://i.imgur.= com/I2sneeL.png

=
I'm using this configuration for rel= ative visual numbers:

(custom-set-variables
...
=C2=A0&= #39;(display-line-numbers 'visual)
..= .)

And here's my setup for the faces:=C2=A0

=C2=A0 ;; MODE SUPPORT: line numbers and relative line num= bers

=C2=A0 (line-number = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(:inherit 'highlight-nu= mbers-number))
= =C2=A0 (line-number-current-line (:foreground gruvbox-neutral_red))<= /div>

In my testing, I found that when= point is on line 1, everything is fine. As you go down line by line, the l= ine-number-current-face skips ahead by one so by the time point is on line = 10, line-number-current-line face is really acting on a number 9 lines belo= w what should be the current line.=C2=A0


On Tue= , Jul 4, 2017 at 11:32 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Fi= lipe Silva <= filipe.silva@gmail.com>
> Date: Tue, 4 Jul 2017 07:57:10 -0300
> Cc: Eli Zaretskii <eliz@gnu.org>, Emacs developers <emacs-devel@gnu.org>
>
> When working with really large files, 10k+ lines long, ha= ving the current line display the abs line number can
> feel "to much" because all lines have max 2 number and the c= urrent line has 5 number so the fringe has to
> grow extra 3 columns just to acommodate the current abs line number of= the current line.
>
> Would it be possible to have like a toggle mechanism to switch the cur= rent line number of the current line from
> abs to nothing or even to zero? that'd be a great addition to this= already awesome feature.

You can customize display-line-numbers-current-absolute to do w= hat you
want.

Thank you for the feedback.


--001a113d6250e2aa8c05537f0016--