From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Filipe Silva Newsgroups: gmane.emacs.devel Subject: Re: Native line numbers, final testing Date: Tue, 4 Jul 2017 11:48:21 -0300 Message-ID: References: <83y3s9pm2a.fsf@gnu.org> <83zicmntaq.fsf@gnu.org> <83van9o6l8.fsf@gnu.org> <83mv8knuhi.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="001a113d38a09b57ec05537ef958" X-Trace: blaine.gmane.org 1499180084 1322 195.159.176.226 (4 Jul 2017 14:54:44 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Jul 2017 14:54:44 +0000 (UTC) Cc: James Nguyen , Emacs developers To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jul 04 16:54:40 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSPDm-0008ID-7w for ged-emacs-devel@m.gmane.org; Tue, 04 Jul 2017 16:54:34 +0200 Original-Received: from localhost ([::1]:41795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSPDr-0005hf-Ey for ged-emacs-devel@m.gmane.org; Tue, 04 Jul 2017 10:54:39 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSP7q-0008IM-Dg for emacs-devel@gnu.org; Tue, 04 Jul 2017 10:48:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSP7p-0001Em-8W for emacs-devel@gnu.org; Tue, 04 Jul 2017 10:48:26 -0400 Original-Received: from mail-oi0-x235.google.com ([2607:f8b0:4003:c06::235]:33471) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dSP7n-0001Cx-Ex; Tue, 04 Jul 2017 10:48:23 -0400 Original-Received: by mail-oi0-x235.google.com with SMTP id p188so104958188oia.0; Tue, 04 Jul 2017 07:48:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Qzmdqm91N9QhrdSiHODTzsCaCCsSVe1113oxqnbwRJA=; b=b7TG6ZAn0YiQ5gEiISPJKJInRoHyepYecB0+Ydx7aLlPML0lJcaXeHI0idwYkv8TXu ON0CSqTFGKMpHysx2b61b4BnOye7PAvSVDl+STyvC6e6J+ieUIdzdSAaJbwUsvjkzQmC WmehAtNnwRiqEmPXZ99SbrGF+CyyfKav6oAW39/zxpjKAdrWed1ym6z9+RXoIGseislv chqdHOxWkctuYkJ66oBCn7SCeZw8gUJWcdZwYTaVb1PNG/A9ZPlFNS2kyIVHbhCqpDe9 S+oRD8MY0qve7v5YP/fyVGvbiksy7vHu0eriuL+/Bwp4kSPNwTG+qt1eBzf5c0/ON8H0 pTcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Qzmdqm91N9QhrdSiHODTzsCaCCsSVe1113oxqnbwRJA=; b=NaaaCWM6mgVeZJ8OJYyZfamcYumoAfxD1aBndnt5UEyR04OTa2sxNo72egqLN78P7B q9aumngGtiElJCZ+dVCBdmRedIpMPSPi/kiRp/RnZGQddApJdHtMYD3X/QfV12vIS1QD ij0G0PHfahkr/dg8YNRxt/1ujJxKIgClt/s8VKQrP8DmGGbOXYhiPLxg3Myvu1s88FCm AbFXTmrYUBMiY5Tp8Y72mCHjrwyXqCKxgv8bGrm75LSx8M1MjzmpwjhnsSkfLlc0tsqW OgwNOiKbnYvSBaUFAZ++QI68ZsM8ZKp8IiVDdXm0a/Y/SHKH9ER0AHR+NzjuKJRLehqT qH8Q== X-Gm-Message-State: AKS2vOyOIDnNARc1qnaBGE659Mn28kjPQg0XFQM4XcMarTuQT1YvAKDs TpZaFK6syMJCOcZSekw5Ss3PnBODZQ0+ X-Received: by 10.202.224.70 with SMTP id x67mr20884303oig.75.1499179702243; Tue, 04 Jul 2017 07:48:22 -0700 (PDT) Original-Received: by 10.182.2.73 with HTTP; Tue, 4 Jul 2017 07:48:21 -0700 (PDT) In-Reply-To: <83mv8knuhi.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4003:c06::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216156 Archived-At: --001a113d38a09b57ec05537ef958 Content-Type: text/plain; charset="UTF-8" Eli thanks you for the information. will test that. I found a bug regarding the line-number-current-line face. Here's a screenshot: http://i.imgur.com/I2sneeL.png I'm using this configuration for relative visual numbers: (custom-set-variables ... '(display-line-numbers 'visual) ...) And here's my setup for the faces: ;; MODE SUPPORT: line numbers and relative line numbers (line-number (:inherit 'highlight-numbers-number)) (line-number-current-line (:foreground gruvbox-neutral_red)) In my testing, I found that when point is on line 1, everything is fine. As you go down line by line, the line-number-current-face skips ahead by one so by the time point is on line 10, line-number-current-line face is really acting on a number 9 lines below what should be the current line. On Tue, Jul 4, 2017 at 11:32 AM, Eli Zaretskii wrote: > > From: Filipe Silva > > Date: Tue, 4 Jul 2017 07:57:10 -0300 > > Cc: Eli Zaretskii , Emacs developers > > > > When working with really large files, 10k+ lines long, having the > current line display the abs line number can > > feel "to much" because all lines have max 2 number and the current line > has 5 number so the fringe has to > > grow extra 3 columns just to acommodate the current abs line number of > the current line. > > > > Would it be possible to have like a toggle mechanism to switch the > current line number of the current line from > > abs to nothing or even to zero? that'd be a great addition to this > already awesome feature. > > You can customize display-line-numbers-current-absolute to do what you > want. > > Thank you for the feedback. > --001a113d38a09b57ec05537ef958 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Eli thanks you for = the information. will test that.

I found a bug regarding the=C2=A0line-number= -current-line face. Here's a screenshot:=C2=A0http://i.imgur.com/I2sneeL.png

I'm using this confi= guration for relative visual numbers:
(custom-se= t-variables
...
=C2=A0'(display-line-numbers 'visual)
...)

And here's my setup for the faces:=C2=A0

=C2=A0 ;; MODE SUPPORT: line numbers and= relative line numbers

= =C2=A0 (line-number =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0(:inher= it 'highlight-numbers-number))
=C2=A0 (line-number-current-line (:foreground gruvbox-n= eutral_red))
In my testin= g, I found that when point is on line 1, everything is fine. As you go down= line by line, the line-number-current-face skips ahead by one so by the ti= me point is on line 10, line-number-current-line face is really acting on a= number 9 lines below what should be the current line.=C2=A0


On Tue, Ju= l 4, 2017 at 11:32 AM, Eli Zaretskii <eliz@gnu.org> wrote:
> From: Filipe Silva <filipe.silva@gmail.com>
> Date: Tue, 4 Jul 2017 07:57:10 -0300
> Cc: Eli Zaretskii <eliz@gnu.org>, Emacs developers <emacs-devel@gnu.org>
>
> When working with really large files, 10k+ lin= es long, having the current line display the abs line number can
> feel "to much" because all lines have max 2 number and the c= urrent line has 5 number so the fringe has to
> grow extra 3 columns just to acommodate the current abs line number of= the current line.
>
> Would it be possible to have like a toggle mechanism to switch the cur= rent line number of the current line from
> abs to nothing or even to zero? that'd be a great addition to this= already awesome feature.

You can customize display-line-numbers-current-absolute to do w= hat you
want.

Thank you for the feedback.

--001a113d38a09b57ec05537ef958--