unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
* Including stdarg.h in 5eb9989 - why?
@ 2016-02-12 10:23 Rostislav Svoboda
  2016-02-12 19:43 ` Paul Eggert
  0 siblings, 1 reply; 3+ messages in thread
From: Rostislav Svoboda @ 2016-02-12 10:23 UTC (permalink / raw)
  To: emacs-devel@gnu.org Development, Alan Mackenzie

Hi, in 5eb9989 Alan just included stdarg.h (see below) with comment:
    * lib-src/make-docfile.c: Include stdarg.h.

Can anybody explain me why? To me such a one-liner makes no sense.
I'm just curious what's the idea behind such a commit...

Thanx Bost


@@ -36,6 +36,7 @@ along with GNU Emacs.  If not, see
<http://www.gnu.org/licenses/>.  */

 #include <config.h>

+#include <stdarg.h>
 #include <stdbool.h>
 #include <stddef.h>
 #include <stdint.h>



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Including stdarg.h in 5eb9989 - why?
  2016-02-12 10:23 Including stdarg.h in 5eb9989 - why? Rostislav Svoboda
@ 2016-02-12 19:43 ` Paul Eggert
  2016-02-13 10:47   ` Rostislav Svoboda
  0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggert @ 2016-02-12 19:43 UTC (permalink / raw)
  To: Rostislav Svoboda, Emacs development discussions

On 02/12/2016 02:23 AM, Rostislav Svoboda wrote:
> Can anybody explain me why?

It's needed because make-docfile.c now uses symbols like va_list and 
va_start that stdarg.h defines. Without the change, make-docfile.c won't 
compile on platforms like MS-Windows where stdarg.h is not already being 
included by other .h files that make-docfile.c includes. See the thread 
starting here:

http://lists.gnu.org/archive/html/emacs-devel/2016-02/msg00630.html




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Including stdarg.h in 5eb9989 - why?
  2016-02-12 19:43 ` Paul Eggert
@ 2016-02-13 10:47   ` Rostislav Svoboda
  0 siblings, 0 replies; 3+ messages in thread
From: Rostislav Svoboda @ 2016-02-13 10:47 UTC (permalink / raw)
  To: Paul Eggert; +Cc: emacs-devel@gnu.org Development

[-- Attachment #1: Type: text/plain, Size: 596 bytes --]

Thanx for clarification Paul.
Le 12 févr. 2016 20:43, "Paul Eggert" <eggert@cs.ucla.edu> a écrit :

> On 02/12/2016 02:23 AM, Rostislav Svoboda wrote:
>
>> Can anybody explain me why?
>>
>
> It's needed because make-docfile.c now uses symbols like va_list and
> va_start that stdarg.h defines. Without the change, make-docfile.c won't
> compile on platforms like MS-Windows where stdarg.h is not already being
> included by other .h files that make-docfile.c includes. See the thread
> starting here:
>
> http://lists.gnu.org/archive/html/emacs-devel/2016-02/msg00630.html
>
>

[-- Attachment #2: Type: text/html, Size: 1074 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-13 10:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-12 10:23 Including stdarg.h in 5eb9989 - why? Rostislav Svoboda
2016-02-12 19:43 ` Paul Eggert
2016-02-13 10:47   ` Rostislav Svoboda

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).